Revert xfail_strict=false for pandas tests - #22913
Conversation
Reverts the temporary xfail_strict=false setting introduced in NVIDIA#22677. If flaky xpasses surface, we should add them to the skip list and investigate individually rather than globally disabling strict xfail. Closes NVIDIA#22681
📝 WalkthroughWalkthroughIn Changespytest configuration and pandas test expected outcomes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Remove 36 stale entries from NODEIDS_THAT_FAIL (tests now pass) - Add 53 pandas-internally-xfailed tests to NODEIDS_TO_SKIP with descriptive reasons (these xpass under cudf.pandas) - Skip flaky test_groupby_all_nan_groups_drop (intermittent assertion failure tracked in NVIDIA#22681)
|
/merge |
Reverts the temporary
xfail_strict=falsesetting introduced in #22677. If flaky xpasses surface, we should add them to the skip list and investigate individually rather than globally disabling strict xfail. Leavingxfail_strict = falsesilently allows tests that should be failing to pass without anyone noticing, and then they could start failing again later. We want to make sure we're always trending upwards in our pass rate.Closes #22681