chore(cudf.pandas): remove stale xfail entries for tests no longer in pandas - #22883
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThis PR updates the cudf.pandas test plugin configuration by removing 38 lines of outdated known-failure entries for datetime searchsorted and interval/period can-hold-element tests, and adding a new entry for a flaky copy_view test. ChangesKnown Test Failures Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bdice
approved these changes
Jun 13, 2026
vyasr
force-pushed
the
chore/remove-stale-xfails
branch
from
June 14, 2026 22:38
ce24b4b to
7febd73
Compare
… pandas Remove 38 entries from NODEIDS_THAT_FAIL that reference test node IDs which no longer exist in the pandas test suite (pandas 3.x): - test_interval_can_hold_element: test removed from pandas (24 entries) - test_period_can_hold_element: test removed from pandas (8 entries) - test_searchsorted_castable_strings: parametrization changed (6 entries) Also add xfail entry for test_infer_objects_reference which is a pre-existing failure (np.shares_memory assertion under cudf.pandas copy-on-write semantics) not previously tracked.
vyasr
force-pushed
the
chore/remove-stale-xfails
branch
from
June 15, 2026 17:22
729887b to
0c2cc84
Compare
Contributor
Author
|
/merge |
This was referenced Jun 17, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 38 stale entries from
NODEIDS_THAT_FAILinpandas-testing-plugin.pythat reference test node IDs which no longer exist in the pandas 3.x test suite. Also add a missing xfail for a pre-existing failure.What changed
Removed 38 stale xfail entries that can never match any collected test (the referenced node IDs no longer exist in pandas 3.x):
test_interval_can_hold_elementtest_period_can_hold_elementtest_searchsorted_castable_stringsAdded 1 xfail entry for
test_infer_objects_reference— a pre-existingnp.shares_memoryassertion failure under cudf.pandas copy-on-write semantics (same class as the already-trackedtest_infer_objects_no_reference).Net change
-38 lines, +1 lineinpython/cudf/cudf/pandas/scripts/pandas-testing-plugin.pyVerification
test_infer_objects_referenceconfirmed as sole remaining failure in CI run after stale removalpython -c "import ast; ast.parse(...)"