Skip to content

chore(cudf.pandas): remove stale xfail entries for tests no longer in pandas - #22883

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
vyasr:chore/remove-stale-xfails
Jun 15, 2026
Merged

chore(cudf.pandas): remove stale xfail entries for tests no longer in pandas#22883
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
vyasr:chore/remove-stale-xfails

Conversation

@vyasr

@vyasr vyasr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Remove 38 stale entries from NODEIDS_THAT_FAIL in pandas-testing-plugin.py that reference test node IDs which no longer exist in the pandas 3.x test suite. Also add a missing xfail for a pre-existing failure.

What changed

Removed 38 stale xfail entries that can never match any collected test (the referenced node IDs no longer exist in pandas 3.x):

Test Function Reason Stale Entries Removed
test_interval_can_hold_element Test removed from pandas 24
test_period_can_hold_element Test removed from pandas 8
test_searchsorted_castable_strings Parametrization changed 6

Added 1 xfail entry for test_infer_objects_reference — a pre-existing np.shares_memory assertion failure under cudf.pandas copy-on-write semantics (same class as the already-tracked test_infer_objects_no_reference).

Net change

-38 lines, +1 line in python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py

Verification

  • Removed tests confirmed absent from pandas 3.0.3 test collection in CI
  • test_infer_objects_reference confirmed as sole remaining failure in CI run after stale removal
  • File parses cleanly: python -c "import ast; ast.parse(...)"
  • All pre-commit hooks pass

@vyasr
vyasr requested a review from a team as a code owner June 13, 2026 01:33
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Jun 13, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the cudf.pandas test plugin configuration by removing 38 lines of outdated known-failure entries for datetime searchsorted and interval/period can-hold-element tests, and adding a new entry for a flaky copy_view test.

Changes

Known Test Failures Configuration

Layer / File(s) Summary
Remove outdated datetime and internals test entries
python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py
Deleted 38 lines of known-failure entries: datetime TestDatetimeArray::test_searchsorted_castable_strings with pyarrow_numpy-series parametrizations, and TestCanHoldElement::test_interval_can_hold_element and test_period_can_hold_element across multiple lambda and dtype parametrizations.
Add flaky copy_view test entry
python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py
Added a known-failures entry for tests/copy_view/test_methods.py::test_infer_objects_reference marked as "Flaky/version-sensitive cudf.pandas dispatch".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cudf#22705: Both PRs modify the same pandas-testing-plugin.py known-failures mapping, updating expected test failure entries.
  • rapidsai/cudf#22618: Both PRs update cudf.pandas expected-failure test mappings for test_searchsorted_castable_strings and related datetime/internals tests.

Suggested reviewers

  • mroeschke
  • galipremsagar
  • brandon-b-miller
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing stale xfail entries for tests no longer in pandas, which is the core objective of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly and specifically describes the changes made: removing 38 stale xfail entries from the pandas-testing-plugin.py file and adding 1 new xfail entry, with detailed tables and reasoning.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 13, 2026
@vyasr
vyasr force-pushed the chore/remove-stale-xfails branch from ce24b4b to 7febd73 Compare June 14, 2026 22:38
… pandas

Remove 38 entries from NODEIDS_THAT_FAIL that reference test node IDs
which no longer exist in the pandas test suite (pandas 3.x):

- test_interval_can_hold_element: test removed from pandas (24 entries)
- test_period_can_hold_element: test removed from pandas (8 entries)
- test_searchsorted_castable_strings: parametrization changed (6 entries)

Also add xfail entry for test_infer_objects_reference which is a
pre-existing failure (np.shares_memory assertion under cudf.pandas
copy-on-write semantics) not previously tracked.
@vyasr
vyasr force-pushed the chore/remove-stale-xfails branch from 729887b to 0c2cc84 Compare June 15, 2026 17:22
@vyasr

vyasr commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants