fix(cudf.pandas): remove stale xfail entries from pandas-testing-plugin - #22904
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
github-actions
Bot
added
Python
mroeschke
approved these changes
Jun 16, 2026
Contributor
There was a problem hiding this comment.
It might be useful to add some runtime validation to pytest_collection_modifyitems to catch these stale tests.
e.g. pytest_collection_modifyitems can pop entries from NODEIDS_THAT_FAIL and NODEIDS_TO_SKIP in its loop, and if either are non-empty at the end of the loop then we still have stale entries.
vyasr
force-pushed
the
stale-xfail-cleanup
branch
from
June 17, 2026 01:53
dfc32d2 to
63d4b65
Compare
Contributor
Author
|
/ok to test |
vyasr
added
improvement
vyasr
force-pushed
the
stale-xfail-cleanup
branch
from
June 18, 2026 15:12
63d4b65 to
c37194a
Compare
Contributor
Author
|
/ok to test |
2 similar comments
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
vyasr
force-pushed
the
stale-xfail-cleanup
branch
from
June 21, 2026 23:16
89a9b2f to
dfe0b4b
Compare
Contributor
Author
|
/ok to test |
Pin matplotlib<3.11 in the pandas test dependency group until pandas 3.0.4 releases with matplotlib 3.11 compat fix (pandas-dev/pandas#65742). Move three local-only non-regression tests to NODEIDS_TO_SKIP for local/CI parity: - complex64-log1p: GPU-architecture-dependent xfail/xpass behavior - test_auto_detect: flaky under xdist due to terminal-width repr - test_construct_dask_float_array_int_dtype_match_ndarray: flaky under xdist due to cross-test state interaction with dask
vyasr
force-pushed
the
stale-xfail-cleanup
branch
from
June 21, 2026 23:53
dfe0b4b to
a67b4a1
Compare
Contributor
Author
|
/ok to test |
…D mismatch Remove 99 xfail entries that are deselected by the test runner's marker expression (-m "not slow and not single_cpu and not db and not network"): - 97 tests/io/test_sql.py entries (module-level single_cpu mark) - 1 test_range_difference (slow mark) - 1 test_dow_parametric (slow mark) Fix 1 node-ID mismatch: test_engine_kwargs_append_data_only was listed without parametrization but the test is parametrized as [True-0] and [False-=1+1]. Split into the two correct entries.
Contributor
Author
|
/ok to test |
vyasr
marked this pull request as ready for review
June 23, 2026 01:16
bdice
requested changes
Jun 23, 2026
bdice
approved these changes
Jun 23, 2026
# Conflicts: # ci/check_style.sh # python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py
Contributor
Author
|
/merge |
This was referenced Jun 23, 2026
mhaseeb123
pushed a commit
to mhaseeb123/cudf
that referenced
this pull request
Jun 24, 2026
…in (NVIDIA#22904) This PR aims to ensure that local runs of the pandas test workflow in a conda-based environment also match CI runs. That is important to reliably run agentic loops to try to fix pandas tests locally. Remove 99 stale entries from `NODEIDS_THAT_FAIL` and fix the openpyxl node-ID mismatch in the pandas-testing-plugin: **Removed xfails (99 entries):** - 97 `tests/io/test_sql.py` entries — these tests now pass because the required I/O packages (`odfpy`, `pytables`, `python-calamine`, `pyxlsb`, `xlrd`) are added as test dependencies - 1 `test_range_difference` — now passes - 1 `test_dow_parametric` — now passes **Fixed node-ID mismatch (net +1 entry):** - Replaced the removed `test_engine_kwargs_append_data_only` (un-parametrized) with the two parametrized variants `[True-0]` and `[False-=1+1]` that actually exist in the pandas 3.0 test suite **Moved to `NODEIDS_THAT_FLAKY_XFAIL` (3 entries):** - `test_numpy_ufuncs_basic[complex64-log1p]` — GPU-architecture-dependent xfail/xpass behavior - `test_auto_detect` — flaky under xdist due to terminal-width-dependent repr truncation - `test_construct_dask_float_array_int_dtype_match_ndarray` — flaky under xdist due to cross-test state interaction with dask - `test_reindexing_with_float64_NA_log` — moved from `NODEIDS_THAT_FAIL` to `NODEIDS_THAT_FLAKY_XFAIL` **Test environment changes:** - Pin `matplotlib<3.11` until pandas 3.0.4 releases with compat fix ([pandas-dev/pandas#65742](pandas-dev/pandas#65742)) - Add missing I/O test dependencies: `odfpy`, `pytables`, `python-calamine`, `pyxlsb`, `xlrd` **CI fix:** - Add `pre-commit clean` in `ci/check_style.sh` to avoid stale pre-commit cache issues Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Matthew Roeschke (https://github.com/mroeschke) - GALI PREM SAGAR (https://github.com/galipremsagar) - Bradley Dice (https://github.com/bdice) URL: NVIDIA#22904
This was referenced Jun 24, 2026
This was referenced Jul 2, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to ensure that local runs of the pandas test workflow in a conda-based environment also match CI runs. That is important to reliably run agentic loops to try to fix pandas tests locally.
Remove 99 stale entries from
NODEIDS_THAT_FAILand fix the openpyxl node-ID mismatch in the pandas-testing-plugin:Removed xfails (99 entries):
tests/io/test_sql.pyentries — these tests now pass because the required I/O packages (odfpy,pytables,python-calamine,pyxlsb,xlrd) are added as test dependenciestest_range_difference— now passestest_dow_parametric— now passesFixed node-ID mismatch (net +1 entry):
test_engine_kwargs_append_data_only(un-parametrized) with the two parametrized variants[True-0]and[False-=1+1]that actually exist in the pandas 3.0 test suiteMoved to
NODEIDS_THAT_FLAKY_XFAIL(3 entries):test_numpy_ufuncs_basic[complex64-log1p]— GPU-architecture-dependent xfail/xpass behaviortest_auto_detect— flaky under xdist due to terminal-width-dependent repr truncationtest_construct_dask_float_array_int_dtype_match_ndarray— flaky under xdist due to cross-test state interaction with dasktest_reindexing_with_float64_NA_log— moved fromNODEIDS_THAT_FAILtoNODEIDS_THAT_FLAKY_XFAILTest environment changes:
matplotlib<3.11until pandas 3.0.4 releases with compat fix (pandas-dev/pandas#65742)odfpy,pytables,python-calamine,pyxlsb,xlrdCI fix:
pre-commit cleaninci/check_style.shto avoid stale pre-commit cache issues