Skip polars tests relying on newer sqlite features - #22870
Conversation
Some polars tests are failing on nightly CI, which runs with both latest and our earliest-supported dependencies. Some of the polars tests uses sqlite features not available with the Python / sqlite used in our earliest-supported matrix. This checks the sqlite version and skips the problematic tests. Closes NVIDIA#22850
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pytest GPU-engine injection plugin now conditionally skips specific string-aggregation and filter-clause tests when running with SQLite versions <= 3.44.0. This addresses OperationalError syntax errors in earlier SQLite versions. The implementation adds version detection imports, updates the skip-list type annotation, and applies a runtime version gate to update the skip list. ChangesSQLite Version-Based Test Skip Logic
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| } | ||
|
|
||
|
|
||
| if packaging.version.parse(sqlite3.sqlite_version) <= packaging.version.parse("3.44.0"): |
There was a problem hiding this comment.
Presumably this would fail with polars CPU and should be fixed there?
There was a problem hiding this comment.
Correct. I opted not to open an issue since sqlite3 is a bit of an odd dependency (typically, though not always bundled with Python).
|
/merge |
Description
Some polars tests are failing on nightly CI, which runs with both latest and our earliest-supported dependencies. Some of the polars tests uses sqlite features not available with the Python / sqlite used in our earliest-supported matrix.
This checks the sqlite version and skips the problematic tests when it's too old.
Note that CI doesn't run polars tests with earliest-supported, so a passing test here doesn't necessarily mean we fixed everything.
Closes #22850
Checklist