Skip to content

Clean up Polars unit tests setup - #22605

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
mroeschke:cudf_polars/ref/clean_polars_unit_tests
May 26, 2026
Merged

Clean up Polars unit tests setup#22605
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
mroeschke:cudf_polars/ref/clean_polars_unit_tests

Conversation

@mroeschke

Copy link
Copy Markdown
Contributor

Description

Follow ups to #22048

closes #20551

  • Removes some Polars dependency pinnings which should no longer be necessary
  • Un-skips some unit tests that should be fixed now

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this May 20, 2026
@mroeschke
mroeschke requested review from a team as code owners May 20, 2026 17:58
@mroeschke
mroeschke requested a review from msarahan May 20, 2026 17:58
@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 20, 2026
@mroeschke
mroeschke requested a review from vyasr May 20, 2026 17:58
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels May 20, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python May 20, 2026
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 645e24e6-29bc-42db-be0d-88800a895a30

📥 Commits

Reviewing files that changed from the base of the PR and between 648d028 and e95d371.

📒 Files selected for processing (2)
  • ci/test_cudf_polars_polars_tests.sh
  • python/cudf_polars/cudf_polars/testing/inject_gpu_engine.py
💤 Files with no reviewable changes (2)
  • python/cudf_polars/cudf_polars/testing/inject_gpu_engine.py
  • ci/test_cudf_polars_polars_tests.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Simplified CI test configuration for Polars testing by removing unnecessary dependency management adjustments.
    • Cleaned up testing module by removing outdated development notes.
  • Tests

    • Removed three obsolete test skip entries from Polars testing configuration that are no longer needed.

Walkthrough

This PR removes outdated test skip entries and simplifies the Polars CI test environment configuration. The test framework no longer needs to skip three previously flaky upstream Polars tests, and the CI setup no longer applies complex dependency constraint rewrites, instead removing only the polars-cloud dependency.

Changes

Test Infrastructure Cleanup

Layer / File(s) Summary
CI test environment simplification
ci/test_cudf_polars_polars_tests.sh
Replaces multi-sed requirement constraint rewrites for deltalake, pydantic, aiosqlite, pandas, pandas-stubs, and pyparsing with a single sed command that removes the polars-cloud line from Polars dev requirements before installation.
Remove obsolete test skips
python/cudf_polars/cudf_polars/testing/inject_gpu_engine.py
Removes a TODO comment and three test skip entries: tests/unit/streaming/test_streaming_group_by.py::test_streaming_group_by_literal[1], tests/unit/io/test_iceberg.py::test_fill_missing_fields_with_identity_partition_values[False], and tests/unit/operations/test_rolling.py::test_rolling_agg_bad_input_types[str].

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Python, cudf-polars

Suggested reviewers

  • TomAugspurger
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main purpose of the PR: cleaning up Polars unit tests setup through dependency removal and test un-skipping.
Description check ✅ Passed The description is directly related to the changeset, referencing follow-ups to PR #22048, closing issue #20551, and explaining the removal of dependency pinnings and un-skipping of tests.
Linked Issues check ✅ Passed The PR addresses issue #20551 by removing the skip entry for test_rolling_agg_bad_input_types[str], which is the flaky rolling test mentioned in the linked issue.
Out of Scope Changes check ✅ Passed All changes are in scope: removing Polars dependency pinnings from the test setup script and un-skipping tests that are now expected to pass based on the linked issue resolution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jameslamb
jameslamb removed the request for review from msarahan May 20, 2026 19:47
@mroeschke

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit a9ebd39 into NVIDIA:main May 26, 2026
118 of 119 checks passed
@mroeschke
mroeschke deleted the cudf_polars/ref/clean_polars_unit_tests branch May 26, 2026 21:03
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf-polars Issues specific to cudf-polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Flaky upstream polars rolling test

4 participants