Skip test_string_agg_aliases on older SQLite versions - #22854
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR adds two SQL test case skip entries to address SQLite version incompatibility in CI. The tests ChangesSQL Test Skip Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Thanks @aryansri05. I'm going to handle this in #22870, which does things a bit differently to cover all the failing tests and makes the skip conditional on the version of python / sqlite. |
Skips
test_string_agg_aliases[STRING_AGG]andtest_string_agg_aliases[GROUP_CONCAT]in the cudf-polars-polars test suite by adding them to
TESTS_TO_SKIPininject_gpu_engine.py.These tests fail with
sqlite3.OperationalError: near "ORDER": syntax errorbecausethe CI environment's SQLite version predates 3.44.0, which is when support for
ORDER BYinsideGROUP_CONCAT/STRING_AGGaggregates was introduced. This is aCI environment constraint, not a bug in cuDF-polars logic.
TODO: remove the skip entries once CI upgrades to SQLite >= 3.44.0.
Closes #22850
Checklist:
I am familiar with the Contributing Guidelines
New or existing tests cover these changes — (N/A: this is a test skip for a CI env limitation)
The documentation is up to date — (N/A: no API/behavior changes)