Skip to content

Remove rapidsmpf from all dependencies - #22655

Merged
rapids-bot[bot] merged 3 commits into
mainfrom
cursor/remove-rapidsmpf-all-deps-43ac
May 30, 2026
Merged

Remove rapidsmpf from all dependencies#22655
rapids-bot[bot] merged 3 commits into
mainfrom
cursor/remove-rapidsmpf-all-deps-43ac

Conversation

@bdice

@bdice bdice commented May 25, 2026

Copy link
Copy Markdown
Contributor

Description

Remove the depends_on_rapidsmpf include from the top-level all conda dependency list so source development environments do not pull in rapidsmpf and its transitive prebuilt libcudf dependency.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Slack Thread

Open in Web Open in Cursor 

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@copy-pr-bot

copy-pr-bot Bot commented May 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@bdice

bdice commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test a74e73d

@bdice
bdice marked this pull request as ready for review May 25, 2026 23:20
@bdice
bdice requested a review from a team as a code owner May 25, 2026 23:20
@bdice
bdice requested a review from gforsyth May 25, 2026 23:20
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 25, 2026
@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 80f84d2d-ca0d-477d-ad7d-3b16fc7267a8

📥 Commits

Reviewing files that changed from the base of the PR and between a74e73d and 86ce963.

📒 Files selected for processing (5)
  • conda/environments/all_cuda-129_arch-aarch64.yaml
  • conda/environments/all_cuda-129_arch-x86_64.yaml
  • conda/environments/all_cuda-132_arch-aarch64.yaml
  • conda/environments/all_cuda-132_arch-x86_64.yaml
  • dependencies.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
  • conda/environments/all_cuda-129_arch-x86_64.yaml
  • dependencies.yaml
  • conda/environments/all_cuda-129_arch-aarch64.yaml
  • conda/environments/all_cuda-132_arch-x86_64.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed the rapidsmpf dependency from conda environment configurations and global dependency includes across multiple CUDA versions and architectures, causing remaining dependencies to shift positions in the environment lists.

Walkthrough

This PR removes the rapidsmpf dependency by deleting depends_on_rapidsmpf from dependencies.yaml and removing rapidsmpf==26.8.*,>=0.0.0a0 from four generated conda environment files for CUDA 12.9 and 13.2 on aarch64 and x86_64.

Changes

Remove rapidsmpf dependency

Layer / File(s) Summary
Dependency includes configuration
dependencies.yaml
Removes depends_on_rapidsmpf from the files.all.includes list, excluding that dependency set from the global "all" group.
Generated conda environments
conda/environments/all_cuda-129_arch-aarch64.yaml, conda/environments/all_cuda-129_arch-x86_64.yaml, conda/environments/all_cuda-132_arch-aarch64.yaml, conda/environments/all_cuda-132_arch-x86_64.yaml
Removes the rapidsmpf==26.8.*,>=0.0.0a0 entry from the dependencies list in each generated conda environment file; surrounding entries remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • rapidsai/cudf#22467: Adjusts CI/workflow removal of wheel-tests-cudf-polars-with-rapidsmpf, related to removing rapidsmpf from environment setup.
  • rapidsai/cudf#22520: Disables cudf-polars recipe smoketest that would pull in rapidsmpf.
  • rapidsai/cudf#22579: Updates devcontainer workflow to clone rapidsmpf before environment creation (related to how rapidsmpf is sourced).

Suggested reviewers

  • gforsyth
  • jameslamb
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing rapidsmpf from dependencies across multiple files.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of removing rapidsmpf from the dependency list and its impact on development environments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/remove-rapidsmpf-all-deps-43ac

Comment @coderabbitai help to get the list of available commands and usage tips.

@jameslamb
jameslamb removed the request for review from gforsyth May 26, 2026 18:13
@bdice

bdice commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@vyasr

vyasr commented May 30, 2026

Copy link
Copy Markdown
Contributor

/ok to test 86ce963

@vyasr vyasr changed the title Remove rapidsmpf from all dependencies Remove rapidsmpf from all dependencies May 30, 2026
@vyasr vyasr changed the title Remove rapidsmpf from all dependencies Remove rapidsmpf from all dependencies May 30, 2026
@rapids-bot
rapids-bot Bot merged commit ebb9da4 into main May 30, 2026
225 of 227 checks passed
@vyasr
vyasr deleted the cursor/remove-rapidsmpf-all-deps-43ac branch May 30, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants