Skip to content

Temporarily WAR rapidsmpf<->libcudf conda package build cycle - #22520

Merged
gforsyth merged 1 commit into
NVIDIA:mainfrom
wence-:wence/rapidsmpf-cycle-tmp
May 15, 2026
Merged

Temporarily WAR rapidsmpf<->libcudf conda package build cycle#22520
gforsyth merged 1 commit into
NVIDIA:mainfrom
wence-:wence/rapidsmpf-cycle-tmp

Conversation

@wence-

@wence- wence- commented May 15, 2026

Copy link
Copy Markdown
Contributor

Description

Building the conda package of cudf-polars needs (for the smoketest) the run dependencies, which include rapidsmpf. But rapidsmpf packages need libcudf conda packages so we have a cycle.

Break that by removing the smoketest, and then we can figure out a proper solution.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
wence- requested a review from a team as a code owner May 15, 2026 13:26
@wence-
wence- requested a review from gforsyth May 15, 2026 13:26
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Disabled certain automated verification checks (import, version and sanity checks) in the package build tests.
  • Chores
    • Updated development container base images to use the latest CUDA-enabled tags across multiple dev environments.

Note: These changes affect build/development infrastructure only and do not change end-user functionality.

Walkthrough

The cudf-polars conda recipe tests block (import/version checks and a polars sanity script) is commented out. Separately, four .devcontainer/*/devcontainer.json files update their build.args.BASE image tags to rapidsai/devcontainers:latest-...; no other configuration changes are present.

Changes

Conda Recipe Tests Disabled

Layer / File(s) Summary
Comment out package tests
conda/recipes/cudf-polars/recipe.yaml
The tests block that performs cudf_polars import checks, version inspection (including runs with RAPIDS_NO_INITIALIZE and CUDF_NO_INITIALIZE), and a polars sanity script is commented out; about metadata remains unchanged.

Devcontainer Base Image Updates

Layer / File(s) Summary
Update devcontainer BASE image tags
.devcontainer/cuda12.9-conda/devcontainer.json, .devcontainer/cuda12.9-pip/devcontainer.json, .devcontainer/cuda13.2-conda/devcontainer.json, .devcontainer/cuda13.2-pip/devcontainer.json
Each file's build.args.BASE value was changed from a rapidsai/devcontainers:26.08-... tag to the corresponding rapidsai/devcontainers:latest-... tag; other devcontainer settings are unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

improvement, non-breaking, cudf-polars

Suggested reviewers

  • msarahan
  • gforsyth
  • bdice
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: commenting out cudf-polars tests as a temporary workaround for a conda build dependency cycle between rapidsmpf and libcudf.
Description check ✅ Passed The description explains the build cycle problem, the temporary solution (removing smoketest), and references finding a proper solution later, which directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.devcontainer/cuda13.2-pip/devcontainer.json (1)

8-8: ⚡ Quick win

Pin the BASE image to an immutable reference instead of latest.

Using latest creates a mutable dependency that can cause non-reproducible environments and unexpected breakage when upstream updates. Pin to a concrete version tag (e.g., 26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10) or better yet, include a digest for full immutability.

Suggested change
-      "BASE": "rapidsai/devcontainers:latest-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10"
+      "BASE": "rapidsai/devcontainers:26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10@sha256:<digest>"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.devcontainer/cuda13.2-pip/devcontainer.json at line 8, The BASE image
reference currently uses the mutable tag
"rapidsai/devcontainers:latest-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" (the BASE
key in the devcontainer config); replace that value with an immutable concrete
tag or an image digest (for example
"rapidsai/devcontainers:26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" or
"rapidsai/devcontainers@sha256:<digest>") so the BASE entry points to a fixed,
reproducible image; update the BASE string accordingly and commit the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.devcontainer/cuda13.2-pip/devcontainer.json:
- Line 8: The BASE image reference currently uses the mutable tag
"rapidsai/devcontainers:latest-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" (the BASE
key in the devcontainer config); replace that value with an immutable concrete
tag or an image digest (for example
"rapidsai/devcontainers:26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" or
"rapidsai/devcontainers@sha256:<digest>") so the BASE entry points to a fixed,
reproducible image; update the BASE string accordingly and commit the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f1ead91c-560d-4552-82d4-cd2024764af0

📥 Commits

Reviewing files that changed from the base of the PR and between 378171f and c941b2f.

📒 Files selected for processing (4)
  • .devcontainer/cuda12.9-conda/devcontainer.json
  • .devcontainer/cuda12.9-pip/devcontainer.json
  • .devcontainer/cuda13.2-conda/devcontainer.json
  • .devcontainer/cuda13.2-pip/devcontainer.json
✅ Files skipped from review due to trivial changes (3)
  • .devcontainer/cuda12.9-pip/devcontainer.json
  • .devcontainer/cuda12.9-conda/devcontainer.json
  • .devcontainer/cuda13.2-conda/devcontainer.json

@gforsyth gforsyth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving -- I'm not completely certain that the cudf-polars package will build, even with the smoketest disabled, so I'll wait until that part of CI completes to confirm, then I can admin-merge this (and skip the test suite)

@wence-
wence- force-pushed the wence/rapidsmpf-cycle-tmp branch from c941b2f to 378171f Compare May 15, 2026 13:55
@wence-

wence- commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Backed out the devcontainer change because it turns out that one was wrong...

@wence-

wence- commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Approving -- I'm not completely certain that the cudf-polars package will build, even with the smoketest disabled, so I'll wait until that part of CI completes to confirm, then I can admin-merge this (and skip the test suite)

The run on main did successfully build the package (because, after all, it's just tarring up some python files): https://github.com/rapidsai/cudf/actions/runs/25888552706/job/76174994010#step:11:1332

@gforsyth

Copy link
Copy Markdown
Contributor

admin merging this

@gforsyth
gforsyth merged commit 7a1bb07 into NVIDIA:main May 15, 2026
74 of 91 checks passed
@wence-
wence- deleted the wence/rapidsmpf-cycle-tmp branch May 15, 2026 14:31
jolorunyomi added a commit that referenced this pull request Jun 3, 2026
#22772)

# Summary

Cherry picked
7a1bb07

Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants