Temporarily WAR rapidsmpf<->libcudf conda package build cycle - #22520
Conversation
📝 WalkthroughSummary by CodeRabbit
Note: These changes affect build/development infrastructure only and do not change end-user functionality. WalkthroughThe cudf-polars conda recipe ChangesConda Recipe Tests Disabled
Devcontainer Base Image Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.devcontainer/cuda13.2-pip/devcontainer.json (1)
8-8: ⚡ Quick winPin the BASE image to an immutable reference instead of
latest.Using
latestcreates a mutable dependency that can cause non-reproducible environments and unexpected breakage when upstream updates. Pin to a concrete version tag (e.g.,26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10) or better yet, include a digest for full immutability.Suggested change
- "BASE": "rapidsai/devcontainers:latest-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" + "BASE": "rapidsai/devcontainers:26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10@sha256:<digest>"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.devcontainer/cuda13.2-pip/devcontainer.json at line 8, The BASE image reference currently uses the mutable tag "rapidsai/devcontainers:latest-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" (the BASE key in the devcontainer config); replace that value with an immutable concrete tag or an image digest (for example "rapidsai/devcontainers:26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" or "rapidsai/devcontainers@sha256:<digest>") so the BASE entry points to a fixed, reproducible image; update the BASE string accordingly and commit the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.devcontainer/cuda13.2-pip/devcontainer.json:
- Line 8: The BASE image reference currently uses the mutable tag
"rapidsai/devcontainers:latest-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" (the BASE
key in the devcontainer config); replace that value with an immutable concrete
tag or an image digest (for example
"rapidsai/devcontainers:26.08-cpp-cuda13.2-ucx1.19.0-openmpi5.0.10" or
"rapidsai/devcontainers@sha256:<digest>") so the BASE entry points to a fixed,
reproducible image; update the BASE string accordingly and commit the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f1ead91c-560d-4552-82d4-cd2024764af0
📒 Files selected for processing (4)
.devcontainer/cuda12.9-conda/devcontainer.json.devcontainer/cuda12.9-pip/devcontainer.json.devcontainer/cuda13.2-conda/devcontainer.json.devcontainer/cuda13.2-pip/devcontainer.json
✅ Files skipped from review due to trivial changes (3)
- .devcontainer/cuda12.9-pip/devcontainer.json
- .devcontainer/cuda12.9-conda/devcontainer.json
- .devcontainer/cuda13.2-conda/devcontainer.json
gforsyth
left a comment
There was a problem hiding this comment.
Approving -- I'm not completely certain that the cudf-polars package will build, even with the smoketest disabled, so I'll wait until that part of CI completes to confirm, then I can admin-merge this (and skip the test suite)
c941b2f to
378171f
Compare
|
Backed out the devcontainer change because it turns out that one was wrong... |
The run on |
|
admin merging this |
Description
Building the conda package of cudf-polars needs (for the smoketest) the run dependencies, which include rapidsmpf. But rapidsmpf packages need libcudf conda packages so we have a cycle.
Break that by removing the smoketest, and then we can figure out a proper solution.
Checklist