Skip to content

Clone rapidsmpf before devcontainer env creation - #22579

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
bdice:fix/devcontainer-rapidsmpf-env
May 23, 2026
Merged

Clone rapidsmpf before devcontainer env creation#22579
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
bdice:fix/devcontainer-rapidsmpf-env

Conversation

@bdice

@bdice bdice commented May 19, 2026

Copy link
Copy Markdown
Contributor

Description

Update the devcontainer PR job to clone rapidsmpf before the repo-owned Python environment creation step, so cudf devcontainers include rapidsmpf from source instead of solving against published rapidsmpf packages pulled in through cudf_polars dependencies.

Depends on rapidsai/shared-workflows#553.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice
bdice requested a review from a team as a code owner May 19, 2026 16:46
@bdice
bdice requested a review from msarahan May 19, 2026 16:46
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The devcontainer job's inline build_command in .github/workflows/pr.yaml was simplified by removing the PYTHON_PACKAGE_MANAGER conditional and the rapids-generate-scripts step; the script now moves from sccache --zero-stats directly to clone-rapidsmpf before continuing to build and telemetry steps.

Changes

Devcontainer workflow update

Layer / File(s) Summary
Simplify devcontainer build_command
.github/workflows/pr.yaml
Removed the PYTHON_PACKAGE_MANAGER branch that called rapids-make-pip-env/rapids-make-conda-env and removed rapids-generate-scripts; the inline build_command now starts with sccache --zero-stats then clone-rapidsmpf, then continues to build-all and telemetry/sccache stats.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • rapidsai/cudf#22490: Edits devcontainer wiring and conditional build_command handling related to Python env creation.
  • rapidsai/cudf#22497: Also modifies the devcontainer build_command to remove the PYTHON_PACKAGE_MANAGER-based env creation and script generation steps.

Suggested reviewers

  • gforsyth
  • KyleFromNVIDIA
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: cloning rapidsmpf before environment creation in the devcontainer workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly explains the change: updating the devcontainer job to clone rapidsmpf before environment creation, ensuring cudf devcontainers use rapidsmpf from source instead of published packages.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 19, 2026
Comment thread .github/workflows/pr.yaml Outdated
bdice and others added 3 commits May 19, 2026 11:58
Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/pr.yaml:
- Line 665: Replace the mutable reusable-workflow ref currently using
"`@fix/make-python-env-creation-success-optional`" in the `uses:` line with the
immutable commit SHA "`@1f8c5fa9761ca52a997faba82174628559903811`" so CI behavior
is pinned (update the `uses:
rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@fix/make-python-env-creation-success-optional`
reference to use the SHA); after the upstream fix merges, revert this ref back
to the branch name (e.g., "`@main`").
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6df3bf36-66e9-4190-87e7-764a5ec0b059

📥 Commits

Reviewing files that changed from the base of the PR and between 7968aba and d2be539.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml

Comment thread .github/workflows/pr.yaml Outdated
secrets: inherit # zizmor: ignore[secrets-inherit]
needs: telemetry-setup
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@main
uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@fix/make-python-env-creation-success-optional

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch the current commit behind the temporary ref so it can be pinned.
gh api repos/rapidsai/shared-workflows/git/ref/heads/fix/make-python-env-creation-success-optional \
  --jq '.object.sha'

Repository: rapidsai/cudf

Length of output: 98


🏁 Script executed:

#!/bin/bash
# Check the actual content around line 665 in pr.yaml
sed -n '660,670p' .github/workflows/pr.yaml

Repository: rapidsai/cudf

Length of output: 451


🏁 Script executed:

#!/bin/bash
# Search for other uses of rapidsai/shared-workflows to see the pinning pattern
rg 'rapidsai/shared-workflows' .github/workflows/ -A 1 -B 1

Repository: rapidsai/cudf

Length of output: 16771


🏁 Script executed:

#!/bin/bash
# Search for any documented policy on SHA-pinning in the repo
find . -type f \( -name "README*" -o -name "CONTRIBUTING*" -o -name "*.md" \) | head -20 | xargs grep -l "pin\|sha\|version\|commit" 2>/dev/null | head -10

Repository: rapidsai/cudf

Length of output: 383


🏁 Script executed:

#!/bin/bash
# Check CONTRIBUTING.md for any guidance on workflow refs or SHA-pinning
grep -A 5 -B 5 -i "workflow\|pin\|sha\|commit" ./CONTRIBUTING.md | head -50

Repository: rapidsai/cudf

Length of output: 1588


🏁 Script executed:

#!/bin/bash
# Check for comments in workflow files about ref pinning or the fix branch
grep -r "fix/make-python-env-creation-success-optional" .github/workflows/ -B 5 -A 5

Repository: rapidsai/cudf

Length of output: 737


Pin this temporary reusable-workflow ref to an immutable commit SHA.

Using @fix/make-python-env-creation-success-optional keeps CI behavior mutable and can break if the branch moves or is deleted. Change to @1f8c5fa9761ca52a997faba82174628559903811, then switch back to @main once the fix is merged upstream.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/pr.yaml at line 665, Replace the mutable reusable-workflow
ref currently using "`@fix/make-python-env-creation-success-optional`" in the
`uses:` line with the immutable commit SHA
"`@1f8c5fa9761ca52a997faba82174628559903811`" so CI behavior is pinned (update the
`uses:
rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@fix/make-python-env-creation-success-optional`
reference to use the SHA); after the upstream fix merges, revert this ref back
to the branch name (e.g., "`@main`").

Comment thread .github/workflows/pr.yaml Outdated
@jameslamb
jameslamb removed the request for review from msarahan May 19, 2026 19:44
@bdice

bdice commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 1759e7c into NVIDIA:main May 23, 2026
288 of 297 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants