Clone rapidsmpf before devcontainer env creation - #22579
Conversation
📝 WalkthroughWalkthroughThe devcontainer job's inline build_command in ChangesDevcontainer workflow update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr.yaml:
- Line 665: Replace the mutable reusable-workflow ref currently using
"`@fix/make-python-env-creation-success-optional`" in the `uses:` line with the
immutable commit SHA "`@1f8c5fa9761ca52a997faba82174628559903811`" so CI behavior
is pinned (update the `uses:
rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@fix/make-python-env-creation-success-optional`
reference to use the SHA); after the upstream fix merges, revert this ref back
to the branch name (e.g., "`@main`").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6df3bf36-66e9-4190-87e7-764a5ec0b059
📒 Files selected for processing (1)
.github/workflows/pr.yaml
| secrets: inherit # zizmor: ignore[secrets-inherit] | ||
| needs: telemetry-setup | ||
| uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@main | ||
| uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@fix/make-python-env-creation-success-optional |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Fetch the current commit behind the temporary ref so it can be pinned.
gh api repos/rapidsai/shared-workflows/git/ref/heads/fix/make-python-env-creation-success-optional \
--jq '.object.sha'Repository: rapidsai/cudf
Length of output: 98
🏁 Script executed:
#!/bin/bash
# Check the actual content around line 665 in pr.yaml
sed -n '660,670p' .github/workflows/pr.yamlRepository: rapidsai/cudf
Length of output: 451
🏁 Script executed:
#!/bin/bash
# Search for other uses of rapidsai/shared-workflows to see the pinning pattern
rg 'rapidsai/shared-workflows' .github/workflows/ -A 1 -B 1Repository: rapidsai/cudf
Length of output: 16771
🏁 Script executed:
#!/bin/bash
# Search for any documented policy on SHA-pinning in the repo
find . -type f \( -name "README*" -o -name "CONTRIBUTING*" -o -name "*.md" \) | head -20 | xargs grep -l "pin\|sha\|version\|commit" 2>/dev/null | head -10Repository: rapidsai/cudf
Length of output: 383
🏁 Script executed:
#!/bin/bash
# Check CONTRIBUTING.md for any guidance on workflow refs or SHA-pinning
grep -A 5 -B 5 -i "workflow\|pin\|sha\|commit" ./CONTRIBUTING.md | head -50Repository: rapidsai/cudf
Length of output: 1588
🏁 Script executed:
#!/bin/bash
# Check for comments in workflow files about ref pinning or the fix branch
grep -r "fix/make-python-env-creation-success-optional" .github/workflows/ -B 5 -A 5Repository: rapidsai/cudf
Length of output: 737
Pin this temporary reusable-workflow ref to an immutable commit SHA.
Using @fix/make-python-env-creation-success-optional keeps CI behavior mutable and can break if the branch moves or is deleted. Change to @1f8c5fa9761ca52a997faba82174628559903811, then switch back to @main once the fix is merged upstream.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/pr.yaml at line 665, Replace the mutable reusable-workflow
ref currently using "`@fix/make-python-env-creation-success-optional`" in the
`uses:` line with the immutable commit SHA
"`@1f8c5fa9761ca52a997faba82174628559903811`" so CI behavior is pinned (update the
`uses:
rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@fix/make-python-env-creation-success-optional`
reference to use the SHA); after the upstream fix merges, revert this ref back
to the branch name (e.g., "`@main`").
|
/merge |
Description
Update the devcontainer PR job to clone rapidsmpf before the repo-owned Python environment creation step, so cudf devcontainers include rapidsmpf from source instead of solving against published rapidsmpf packages pulled in through cudf_polars dependencies.
Depends on rapidsai/shared-workflows#553.
Checklist