Skip to content

Add debug-cudf-pandas skill for fixing pandas test compatibility failures - #22625

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
vyasr:skill/debug-cudf-pandas
May 29, 2026
Merged

Add debug-cudf-pandas skill for fixing pandas test compatibility failures#22625
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
vyasr:skill/debug-cudf-pandas

Conversation

@vyasr

@vyasr vyasr commented May 21, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a skill for debugging cudf.pandas test failures. This skill aims to encode a standardized workflow for failures in a systematic way.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr self-assigned this May 21, 2026
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 21, 2026
@copy-pr-bot

copy-pr-bot Bot commented May 21, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr
vyasr force-pushed the skill/debug-cudf-pandas branch from 6fcae79 to 4fad13d Compare May 21, 2026 19:08
@copy-pr-bot

copy-pr-bot Bot commented May 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment thread .agents/skills/debug-cudf-pandas/SKILL.md
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md
@vyasr
vyasr force-pushed the skill/debug-cudf-pandas branch from 4fad13d to 71d68af Compare May 21, 2026 23:19
@vyasr
vyasr force-pushed the skill/debug-cudf-pandas branch from 71d68af to 5ca310d Compare May 28, 2026 23:51
@vyasr
vyasr marked this pull request as ready for review May 28, 2026 23:51
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 76010c97-0cdb-47cd-9ae7-6ddbdaf76ffd

📥 Commits

Reviewing files that changed from the base of the PR and between 5ca310d and c32d869.

📒 Files selected for processing (1)
  • .agents/skills/debug-cudf-pandas/SKILL.md
💤 Files with no reviewable changes (1)
  • .agents/skills/debug-cudf-pandas/SKILL.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Added a detailed step‑by‑step workflow document covering failure classification, prohibited fix patterns, prerequisites for clean runs, expected input format, investigation and verification flows, commit‑stage guidance, stop conditions, and operational notes for pandas compatibility testing and diagnostics.

Walkthrough

This PR adds a skill documentation file that defines a complete workflow for debugging and fixing pandas test failures under the cuDF.pandas compatibility layer. The documentation covers failure classification, prohibited fix patterns, prerequisites, investigation steps, diagnostic techniques, distinct fix paths for implementation versus proxy bugs, verification procedures, and operational notes.

Changes

Debug cuDF.pandas Skill Definition

Layer / File(s) Summary
Complete skill definition with purpose, workflow, and implementation guide
.agents/skills/debug-cudf-pandas/SKILL.md
Introduces the skill name and purpose, defines prohibited fix patterns and prerequisites, describes the investigation workflow including reproduction and root-cause diagnosis with direct cudf vs pandas comparison and proxy-layer diagnostics, outlines distinct fix paths for cudf implementation bugs versus proxy/dispatch bugs, specifies verification steps and commit-stage instructions, lists stop conditions, and documents operational notes affecting test interpretation and harness behavior.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding a debug skill for pandas test compatibility failures in cudf.pandas.
Description check ✅ Passed The description clearly relates to the changeset by explaining the purpose of the new skill for standardizing debugging workflows for cudf.pandas test failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.agents/skills/debug-cudf-pandas/SKILL.md:
- Line 215: The SKILL.md reference to a non-existent python/CLAUDE.md should be
removed and replaced with the correct guidance: update
.agents/skills/debug-cudf-pandas/SKILL.md to either point to the existing
internal usage or inline the required buffer access pattern, e.g., show the
exact call column.access(mode="read", scope="internal") and/or reference
existing helper usage like access_columns(..., mode="read", scope="internal");
ensure the doc no longer links to python/CLAUDE.md and clearly states the
required buffer access pattern where the current line 215 mentions it.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a37362ca-e8cd-4557-86e6-bfbb8078019e

📥 Commits

Reviewing files that changed from the base of the PR and between ad987ea and 5ca310d.

📒 Files selected for processing (1)
  • .agents/skills/debug-cudf-pandas/SKILL.md

Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
@vyasr
vyasr requested a review from mroeschke May 29, 2026 00:01
@vyasr

vyasr commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@vyasr vyasr mentioned this pull request May 29, 2026
3 tasks
@rapids-bot
rapids-bot Bot merged commit 5967cc2 into NVIDIA:main May 29, 2026
115 checks passed
rapids-bot Bot pushed a commit that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants