Fix various pandas issues using new debugging skill - #22626
Closed
vyasr wants to merge 31 commits into
Closed
Conversation
GroupBy._grouped passed internal storage keys (self.obj._index_names) to _from_columns_like_self, which for a nameless MultiIndex produced [0, 1] instead of the correct public names [None, None]. This caused GroupBy.apply to return results with wrong index level names, making the cudf.pandas accelerated test_cython_transform_frame_column fail when comparing apply() expected values against transform() results. Use self.obj.index.names (public metadata) instead. Fixes the following failing pandas tests: - tests/groupby/transform/test_transform.py::test_cython_transform_frame_column[*-frame_mi-*]
These tests assert that pandas raises NotImplementedError when using engine='numba' with as_index=False for groupby reductions. cuDF computes reductions on GPU without numba, so the pandas-specific limitation does not apply and the operation succeeds. The divergence is intentional. Skips the following pandas tests: - tests/groupby/test_numba.py::TestEngine::test_as_index_false_unsupported[*]
Fix pyarrow-backed StringDtype str.match results to match pandas nullable boolean dtype and end-of-string anchor semantics.
Fixes the following failing pandas test: - tests/strings/test_string_array.py::test_string_array_extract[string[python]]
Fixes the following failing pandas tests: - tests/reshape/concat/test_append.py::TestAppend::test_append_different_columns_types[Index-MultiIndex2] - tests/reshape/concat/test_append.py::TestAppend::test_append_different_columns_types[CategoricalIndex-MultiIndex0] - tests/reshape/concat/test_append.py::TestAppend::test_append_different_columns_types[CategoricalIndex-MultiIndex1]
…pers Removes pd.Series construction from _return_pandas_string_nullable_result and _return_pandas_string_object_result. Uses cudf-native dtype casting and _return_or_inplace instead.
… instead of CPU fallback
vyasr
force-pushed
the
fix/more_pandas_improvements
branch
from
May 28, 2026 23:57
a50a5e1 to
69b09cc
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
Closing since the contents of this branch have been moved to other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applies #22625 to fix various issues with pandas tests discovered locally.
Checklist