Skip to content

Update cudf.pandas skill with recent changes - #22787

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
galipremsagar:cp_skills
Jun 5, 2026
Merged

Update cudf.pandas skill with recent changes#22787
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
galipremsagar:cp_skills

Conversation

@galipremsagar

Copy link
Copy Markdown
Contributor

Description

We recently changes our test plugin, this PR updates and removes old references in SKILL.md.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar
galipremsagar requested review from mroeschke and vyasr June 4, 2026 20:51
@galipremsagar galipremsagar self-assigned this Jun 4, 2026
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 4, 2026
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7bf0f41b-1ddd-450f-83f5-ca1b55f34115

📥 Commits

Reviewing files that changed from the base of the PR and between a47acc2 and 580adb4.

📒 Files selected for processing (1)
  • .agents/skills/debug-cudf-pandas/SKILL.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated debugging skill docs: clarified test-setup categories, added precise guidance for reusing/refreshing local test checkouts, revised validation and troubleshooting steps to match the plugin-based test harness, explained non-failing "xpass" behavior when strictness is disabled, updated example test invocation and final commit staging instructions, and revised Important Notes.

Walkthrough

This PR updates the debug-cudf-pandas skill doc to reflect the current pandas-testing harness: replace conftest-patch.py references with pandas-testing-plugin.py, add explicit rules for reusing or refreshing the test checkout, and document xfail_strict = false XPASS behavior and stale-marker handling.

Changes

Pandas testing harness workflow documentation

Layer / File(s) Summary
Workflow overview and setup prerequisites
.agents/skills/debug-cudf-pandas/SKILL.md
Overview wording reworded; replaced previous cleanup instructions with explicit guidance for reusing vs refreshing the pandas-testing checkout and precise rm -rf rules.
Main debugging steps: validation and reproduction
.agents/skills/debug-cudf-pandas/SKILL.md
Step 0 now targets pandas-testing-plugin.py (describes NODEIDS_THAT_FAIL/NODEIDS_TO_SKIP/NODEIDS_PATHS_TO_SKIP and xfail_strict = false behavior). Step 1 updated to use the current run-pandas-tests.sh invocation and plugin-based troubleshooting flow.
Debugging completion: regression check and commit
.agents/skills/debug-cudf-pandas/SKILL.md
Step 5 instructs investigating failures not already listed in pandas-testing-plugin.py. Step 6 updates commit staging guidance to stage python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py for marker removal.
Implementation behavior documentation
.agents/skills/debug-cudf-pandas/SKILL.md
Important Notes updated to reflect plugin-based marker application loaded each run, xfail_strict = false XPASS behavior, and removed conftest-patch-specific instructions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • rapidsai/cudf#22625: Earlier PR that adjusted the same debug-cudf-pandas skill workflow and harness behavior documentation.

Suggested labels

doc

Suggested reviewers

  • mroeschke
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title references 'cudf.pandas skill' and 'recent changes' which aligns with the changeset updating SKILL.md documentation to reflect recent test plugin modifications.
Description check ✅ Passed The description explains that recent test plugin changes prompted updates and removal of old references in SKILL.md, which directly relates to the documentation changes in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@vyasr vyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
Comment thread .agents/skills/debug-cudf-pandas/SKILL.md Outdated
galipremsagar and others added 3 commits June 4, 2026 16:56
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@galipremsagar

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit b00d56a into NVIDIA:main Jun 5, 2026
120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants