Skip to content

Simplify StringColumn.to_pandas - #21355

Closed
mroeschke wants to merge 3 commits into
NVIDIA:mainfrom
mroeschke:ref/cudf/string_to_pandas
Closed

Simplify StringColumn.to_pandas#21355
mroeschke wants to merge 3 commits into
NVIDIA:mainfrom
mroeschke:ref/cudf/string_to_pandas

Conversation

@mroeschke

Copy link
Copy Markdown
Contributor

Description

Broken off from #21251

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Feb 5, 2026
@mroeschke
mroeschke requested a review from a team as a code owner February 5, 2026 23:03
@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function labels Feb 5, 2026
@mroeschke mroeschke added the non-breaking Non-breaking change label Feb 5, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python Feb 5, 2026

@galipremsagar galipremsagar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is causing some pytest failures.

@mroeschke

Copy link
Copy Markdown
Contributor Author

Looks like this is causing some pytest failures.

Thanks, yeah I'm still a little perplexed by the test failures - but maybe this change isn't valid afterall. Going to mark as draft until I can work through the pandas failures.

@mroeschke
mroeschke marked this pull request as draft February 10, 2026 18:16
@copy-pr-bot

copy-pr-bot Bot commented Feb 10, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@galipremsagar

Copy link
Copy Markdown
Contributor

Looks like this is causing some pytest failures.

Thanks, yeah I'm still a little perplexed by the test failures - but maybe this change isn't valid afterall. Going to mark as draft until I can work through the pandas failures.

No Worries, I pushed new changes to main: #21350 that will now test docstrings of all the string APIs.

@mroeschke mroeschke closed this Feb 26, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python Feb 26, 2026
@mroeschke
mroeschke deleted the ref/cudf/string_to_pandas branch February 26, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants