Allow StringColumn to always accept pandas string extention types - #21251
Closed
mroeschke wants to merge 8 commits into
Closed
Allow StringColumn to always accept pandas string extention types#21251mroeschke wants to merge 8 commits into
mroeschke wants to merge 8 commits into
Conversation
…implify _validate_args
mroeschke
added
the
improvement
Contributor
|
Looks like there are issues with our test suite in addition to the pandas test suite. Hopefully fixing the first will also reduce what you have to xfail in conftest-patch. |
galipremsagar
requested changes
Jan 31, 2026
| if ( | ||
| not cudf.get_option("mode.pandas_compatible") | ||
| and dtype != CUDF_STRING_DTYPE | ||
| and dtype.kind != "U" |
Contributor
There was a problem hiding this comment.
I think you will have to bring back this check(minus the pandas compatibility flag) to make np.dtype(object), np.dtype('str') and nullable dtypes work. Those are probably the causes for the new xfails.
Contributor
Author
|
I'm going to split the changes in this PR to isolate what might be failing the pandas tests. One split is making this validators stricter in #21281 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Towards #21229
is_dtype_obj_stringstricter to only accept dtype objects and subsequently simplified_validate_argsStringColumn.to_pandasto correctly handle extension typesI am also adding some tests to our xfail list. I believe we may be loosing tracking of pandas string extension types in other spots.
Checklist