Remove cudf compat gating at more places - #21350
Merged
Merged
Conversation
galipremsagar
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/okay to test af921e7 |
…VIDIA#21329) General testing done in NVIDIA#20974 Opening a new PR to not disrupt any ongoing downstream testing using artifacts from the original draft PRs. Resolves NVIDIA#20974 xref rapidsai/build-planning#42 Ops-Bot-Merge-Barrier: true Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - James Lamb (https://github.com/jameslamb) URL: NVIDIA#21329
galipremsagar
changed the title
galipremsagar
added
3 - Ready for Review
galipremsagar
marked this pull request as ready for review
February 7, 2026 04:05
wence-
approved these changes
Feb 9, 2026
wence-
left a comment
wence-
left a comment
Contributor
There was a problem hiding this comment.
Minor doc/comment updates needed, otherwise looks good.
Contributor
Author
|
/okay to test c2b9327 |
Contributor
Author
|
/okay to test d4f5bf1 |
Contributor
Author
|
/okay to test 6c143eb |
Contributor
Author
|
/merge |
bdice
approved these changes
Feb 10, 2026
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
Approving for CI. I skimmed the Python changes too.
| Returning any digit using regular expression. | ||
|
|
||
| >>> s1.str.contains('\d', regex=True) | ||
| >>> s1.str.contains('\\d', regex=True) |
Contributor
There was a problem hiding this comment.
There’s something funny about making this backslash syntax work with both doctests and Sphinx rendering. Please verify the docs render as expected.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes cudf compatibility mode gating in more places.
Checklist