Skip to content

Add the missing DeletionVectorInfo constructor parameter [databricks] - #15406

Closed
jihoonson wants to merge 1 commit into
NVIDIA:mainfrom
jihoonson:fix-dvinfo
Closed

Add the missing DeletionVectorInfo constructor parameter [databricks]#15406
jihoonson wants to merge 1 commit into
NVIDIA:mainfrom
jihoonson:fix-dvinfo

Conversation

@jihoonson

@jihoonson jihoonson commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Description

NVIDIA/cudf@5beaa59 changed the signature of DeletionVectorInfo constructor. The premerge CI is failing because of this change.

This PR fixes it by setting the new isRetention parameter to false. It preserves the current behavior which assumes all deletion vectors are the deletion filter (isRetention=false). This change is covered by existing deletion vector tests in delta_lake_test.py and delta_lake_delete_test.py.

Checklists

Documentation

  • Updated for new or modified user-facing features or behaviors
  • No user-facing change

Testing

  • Added or modified tests to cover new code paths
  • Covered by existing tests
    (Please provide the names of the existing tests in the PR description.)
  • Not required

Performance

  • Tests ran and results are added in the PR description
  • Issue filed with a link in the PR description
  • Not required

@jihoonson jihoonson changed the title Fix DeletionVectorInfo constructor parameter [databricks] Add the missing DeletionVectorInfo constructor parameter [databricks] Jul 28, 2026
Signed-off-by: Jihoon Son <ghoonson@gmail.com>
@jihoonson

Copy link
Copy Markdown
Collaborator Author

build

@jihoonson
jihoonson requested a review from a team July 28, 2026 16:13
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR restores compatibility with the updated cuDF DeletionVectorInfo constructor.

  • Passes isRetention=false at all six deletion-vector construction sites.
  • Applies the update to the shared Delta 3.3–4.1 read path and the DBR 17.3 native deletion-vector path.
  • Preserves existing deletion-filter semantics.

Confidence Score: 5/5

The PR appears safe to merge because it consistently supplies the newly required constructor argument while preserving deletion-filter behavior.

All repository construction sites for this API were updated consistently, and the new false value matches the existing paths’ use of standard deletion vectors rather than retention vectors.

Important Files Changed

Filename Overview
delta-lake/common/src/main/delta-33x-41x/scala/com/nvidia/spark/rapids/delta/common/GpuDeltaParquetFileFormatBase2.scala Updates all three shared deletion-vector construction paths to explicitly use deletion-filter semantics.
delta-lake/delta-spark400db173/src/main/scala/com/nvidia/spark/rapids/delta/GpuDeltaParquetFileFormatNativeDV.scala Applies the same constructor adaptation consistently across all three DBR 17.3 native deletion-vector paths.

Reviews (1): Last reviewed commit: "Fix DeletionVectorInfo constructor param..." | Re-trigger Greptile

@sameerz sameerz added the bug Something isn't working label Jul 28, 2026
mythrocks
mythrocks previously approved these changes Jul 28, 2026

@mythrocks mythrocks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, pending formatting change.

abellina
abellina previously approved these changes Jul 28, 2026

@abellina abellina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @mythrocks, line length scalastyle failure seen in the build.

@jihoonson
jihoonson changed the base branch from main to release/26.08 July 28, 2026 17:18
@jihoonson
jihoonson dismissed stale reviews from abellina and mythrocks July 28, 2026 17:18

The base branch was changed.

@jihoonson
jihoonson requested a review from a team as a code owner July 28, 2026 17:18
@jihoonson
jihoonson changed the base branch from release/26.08 to main July 28, 2026 17:19
@jihoonson

Copy link
Copy Markdown
Collaborator Author

Closing in favor of #15408.

@jihoonson jihoonson closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants