Add the missing DeletionVectorInfo constructor parameter [databricks] - #15406
Add the missing DeletionVectorInfo constructor parameter [databricks]#15406jihoonson wants to merge 1 commit into
Conversation
Signed-off-by: Jihoon Son <ghoonson@gmail.com>
|
build |
Greptile SummaryThis PR restores compatibility with the updated cuDF
Confidence Score: 5/5The PR appears safe to merge because it consistently supplies the newly required constructor argument while preserving deletion-filter behavior. All repository construction sites for this API were updated consistently, and the new false value matches the existing paths’ use of standard deletion vectors rather than retention vectors. Important Files Changed
Reviews (1): Last reviewed commit: "Fix DeletionVectorInfo constructor param..." | Re-trigger Greptile |
mythrocks
left a comment
There was a problem hiding this comment.
👍, pending formatting change.
abellina
left a comment
There was a problem hiding this comment.
Same as @mythrocks, line length scalastyle failure seen in the build.
The base branch was changed.
|
Closing in favor of #15408. |
Description
NVIDIA/cudf@5beaa59 changed the signature of
DeletionVectorInfoconstructor. The premerge CI is failing because of this change.This PR fixes it by setting the new
isRetentionparameter to false. It preserves the current behavior which assumes all deletion vectors are the deletion filter (isRetention=false). This change is covered by existing deletion vector tests indelta_lake_test.pyanddelta_lake_delete_test.py.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance