Skip to content

Add the missing DeletionVectorInfo constructor parameter [databricks] #15406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jihoonson wants to merge 1 commit into from
+6 −4
Closed

Add the missing DeletionVectorInfo constructor parameter [databricks] #15406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...a-33x-41x/scala/com/nvidia/spark/rapids/delta/common/GpuDeltaParquetFileFormatBase2.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ class GpuDeltaParquetFileFormatBase2(
val (rowGroupOffsets, rowGroupNumRows) =
RapidsDeletionVectors.getRowGroupMetadata(chunkedBlocks)
val maybeDvInfo = maybeSerializedDV.map(serializedDV =>
new DeletionVector.DeletionVectorInfo(serializedDV, rowGroupOffsets, rowGroupNumRows))
new DeletionVector.DeletionVectorInfo(serializedDV, false, rowGroupOffsets, rowGroupNumRows))

val hostBuf = dataBuffer.getDataHostBuffer()
// Duplicate request is ok, and start to use the GPU just after the host
Expand Down Expand Up @@ -686,6 +686,7 @@ class GpuDeltaParquetFileFormatBase2(
.map(spillableDvInfo =>
new DeletionVector.DeletionVectorInfo(
spillableDvInfo.serializedBitmap.getDataHostBuffer(),
false,
spillableDvInfo.rowGroupOffsets,
spillableDvInfo.rowGroupNumRows
))
Expand Down Expand Up @@ -1193,7 +1194,7 @@ class GpuDeltaParquetFileFormatBase2(
.zip(batchExtra.perFileEntries)
.map { case (loaded, entry) =>
new DeletionVector.DeletionVectorInfo(
loaded.gpuBitmap.getDataHostBuffer(), entry.rowGroupOffsets, entry.rowGroupNumRows)
loaded.gpuBitmap.getDataHostBuffer(), false, entry.rowGroupOffsets, entry.rowGroupNumRows)
}.toArray
// MakeParquetTableWithDVProducer closes the dataBuffer and the bitmaps in dvInfos.
MakeParquetTableWithDVProducer(useChunkedReader, maxChunkedReaderMemoryUsageSizeBytes,
Expand Down
5 changes: 3 additions & 2 deletions ...b173/src/main/scala/com/nvidia/spark/rapids/delta/GpuDeltaParquetFileFormatNativeDV.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ case class GpuDeltaParquetFileFormatNativeDV(
val (rowGroupOffsets, rowGroupNumRows) =
RapidsDeletionVectors.getRowGroupMetadata(chunkedBlocks)
val maybeDvInfo = maybeSerializedDV.map(serializedDV =>
new DeletionVector.DeletionVectorInfo(serializedDV, rowGroupOffsets, rowGroupNumRows))
new DeletionVector.DeletionVectorInfo(serializedDV, false, rowGroupOffsets, rowGroupNumRows))

val hostBuf = dataBuffer.getDataHostBuffer()
// Duplicate request is ok, and start to use the GPU just after the host
Expand Down Expand Up @@ -752,6 +752,7 @@ case class GpuDeltaParquetFileFormatNativeDV(
.map(spillableDvInfo =>
new DeletionVector.DeletionVectorInfo(
spillableDvInfo.serializedBitmap.getDataHostBuffer(),
false,
spillableDvInfo.rowGroupOffsets,
spillableDvInfo.rowGroupNumRows
))
Expand Down Expand Up @@ -1350,7 +1351,7 @@ case class GpuDeltaParquetFileFormatNativeDV(
.zip(batchExtra.perFileEntries)
.map { case (loaded, entry) =>
new DeletionVector.DeletionVectorInfo(
loaded.gpuBitmap.getDataHostBuffer(), entry.rowGroupOffsets, entry.rowGroupNumRows)
loaded.gpuBitmap.getDataHostBuffer(), false, entry.rowGroupOffsets, entry.rowGroupNumRows)
}.toArray
// MakeParquetTableWithDVProducer closes the dataBuffer and the bitmaps in dvInfos.
MakeParquetTableWithDVProducer(useChunkedReader, maxChunkedReaderMemoryUsageSizeBytes,
Expand Down
Loading