Add the missing DeletionVectorInfo constructor parameter [databricks] - #15408
Merged
Conversation
Signed-off-by: Jihoon Son <ghoonson@gmail.com>
8 tasks
abellina
approved these changes
Jul 28, 2026
Collaborator
Author
|
build |
Contributor
Greptile SummaryThis PR restores compatibility with the updated
Confidence Score: 5/5The PR appears safe to merge, with the constructor update applied consistently across the affected shared and Databricks deletion-vector paths. The change supplies the newly required boolean parameter at every corresponding construction site and preserves the existing behavior of treating these bitmaps as deletion filters. Important Files Changed
Reviews (1): Last reviewed commit: "fix line length" | Re-trigger Greptile |
Collaborator
|
Build |
mythrocks
approved these changes
Jul 28, 2026
8 tasks
3 tasks
Ko-dany
pushed a commit
to acceldata-io/spark-rapids
that referenced
this pull request
Aug 6, 2026
…atabricks] (NVIDIA#15408) NVIDIA/cudf@5beaa59 changed the signature of `DeletionVectorInfo` constructor. The premerge CI is failing because of this change. This PR fixes it by setting the new `isRetention` parameter to false. It preserves the current behavior which assumes all deletion vectors are the deletion filter (`isRetention=false`). This change is covered by existing deletion vector tests in `delta_lake_test.py` and `delta_lake_delete_test.py`. Documentation - [ ] Updated for new or modified user-facing features or behaviors - [x] No user-facing change Testing - [ ] Added or modified tests to cover new code paths - [x] Covered by existing tests (Please provide the names of the existing tests in the PR description.) - [ ] Not required Performance - [ ] Tests ran and results are added in the PR description - [ ] Issue filed with a link in the PR description - [x] Not required --------- Signed-off-by: Jihoon Son <ghoonson@gmail.com> (cherry picked from commit eb9ffb1)
Ko-dany
pushed a commit
to acceldata-io/spark-rapids
that referenced
this pull request
Aug 6, 2026
…atabricks] (NVIDIA#15408) NVIDIA/cudf@5beaa59 changed the signature of `DeletionVectorInfo` constructor. The premerge CI is failing because of this change. This PR fixes it by setting the new `isRetention` parameter to false. It preserves the current behavior which assumes all deletion vectors are the deletion filter (`isRetention=false`). This change is covered by existing deletion vector tests in `delta_lake_test.py` and `delta_lake_delete_test.py`. Documentation - [ ] Updated for new or modified user-facing features or behaviors - [x] No user-facing change Testing - [ ] Added or modified tests to cover new code paths - [x] Covered by existing tests (Please provide the names of the existing tests in the PR description.) - [ ] Not required Performance - [ ] Tests ran and results are added in the PR description - [ ] Issue filed with a link in the PR description - [x] Not required --------- Signed-off-by: Jihoon Son <ghoonson@gmail.com> (cherry picked from commit eb9ffb1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NVIDIA/cudf@5beaa59 changed the signature of
DeletionVectorInfoconstructor. The premerge CI is failing because of this change.This PR fixes it by setting the new
isRetentionparameter to false. It preserves the current behavior which assumes all deletion vectors are the deletion filter (isRetention=false). This change is covered by existing deletion vector tests indelta_lake_test.pyanddelta_lake_delete_test.py.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance