Skip to content

Add the missing DeletionVectorInfo constructor parameter [databricks] - #15408

Merged
jihoonson merged 2 commits into
NVIDIA:release/26.08from
jihoonson:fix-dvinfo-2608
Jul 28, 2026
Merged

Add the missing DeletionVectorInfo constructor parameter [databricks]#15408
jihoonson merged 2 commits into
NVIDIA:release/26.08from
jihoonson:fix-dvinfo-2608

Conversation

@jihoonson

Copy link
Copy Markdown
Collaborator

Description

NVIDIA/cudf@5beaa59 changed the signature of DeletionVectorInfo constructor. The premerge CI is failing because of this change.

This PR fixes it by setting the new isRetention parameter to false. It preserves the current behavior which assumes all deletion vectors are the deletion filter (isRetention=false). This change is covered by existing deletion vector tests in delta_lake_test.py and delta_lake_delete_test.py.

Checklists

Documentation

  • Updated for new or modified user-facing features or behaviors
  • No user-facing change

Testing

  • Added or modified tests to cover new code paths
  • Covered by existing tests
    (Please provide the names of the existing tests in the PR description.)
  • Not required

Performance

  • Tests ran and results are added in the PR description
  • Issue filed with a link in the PR description
  • Not required

Signed-off-by: Jihoon Son <ghoonson@gmail.com>
@jihoonson

Copy link
Copy Markdown
Collaborator Author

build

@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR restores compatibility with the updated DeletionVectorInfo constructor while preserving deletion-filter semantics.

  • Passes isRetention = false at all three shared Delta 3.3–4.1 deletion-vector construction paths.
  • Applies the equivalent constructor update to the DBR 17.3 native deletion-vector implementation.

Confidence Score: 5/5

The PR appears safe to merge, with the constructor update applied consistently across the affected shared and Databricks deletion-vector paths.

The change supplies the newly required boolean parameter at every corresponding construction site and preserves the existing behavior of treating these bitmaps as deletion filters.

Important Files Changed

Filename Overview
delta-lake/common/src/main/delta-33x-41x/scala/com/nvidia/spark/rapids/delta/common/GpuDeltaParquetFileFormatBase2.scala Updates all shared deletion-vector reader paths to supply the new constructor parameter consistently, with no actionable defect identified.
delta-lake/delta-spark400db173/src/main/scala/com/nvidia/spark/rapids/delta/GpuDeltaParquetFileFormatNativeDV.scala Applies the matching constructor update across all DBR 17.3 native deletion-vector reader paths, with no actionable defect identified.

Reviews (1): Last reviewed commit: "fix line length" | Re-trigger Greptile

@mythrocks

Copy link
Copy Markdown
Collaborator

Build

@sameerz sameerz added the bug Something isn't working label Jul 28, 2026
@jihoonson
jihoonson merged commit eb9ffb1 into NVIDIA:release/26.08 Jul 28, 2026
58 checks passed
Ko-dany pushed a commit to acceldata-io/spark-rapids that referenced this pull request Aug 6, 2026
…atabricks] (NVIDIA#15408)

NVIDIA/cudf@5beaa59
changed the signature of `DeletionVectorInfo` constructor. The premerge
CI is failing because of this change.

This PR fixes it by setting the new `isRetention` parameter to false. It
preserves the current behavior which assumes all deletion vectors are
the deletion filter (`isRetention=false`). This change is covered by
existing deletion vector tests in `delta_lake_test.py` and
`delta_lake_delete_test.py`.

Documentation
- [ ] Updated for new or modified user-facing features or behaviors
- [x] No user-facing change

Testing
- [ ] Added or modified tests to cover new code paths
- [x] Covered by existing tests
(Please provide the names of the existing tests in the PR description.)
- [ ] Not required

Performance
- [ ] Tests ran and results are added in the PR description
- [ ] Issue filed with a link in the PR description
- [x] Not required

---------

Signed-off-by: Jihoon Son <ghoonson@gmail.com>
(cherry picked from commit eb9ffb1)
Ko-dany pushed a commit to acceldata-io/spark-rapids that referenced this pull request Aug 6, 2026
…atabricks] (NVIDIA#15408)

NVIDIA/cudf@5beaa59
changed the signature of `DeletionVectorInfo` constructor. The premerge
CI is failing because of this change.

This PR fixes it by setting the new `isRetention` parameter to false. It
preserves the current behavior which assumes all deletion vectors are
the deletion filter (`isRetention=false`). This change is covered by
existing deletion vector tests in `delta_lake_test.py` and
`delta_lake_delete_test.py`.

Documentation
- [ ] Updated for new or modified user-facing features or behaviors
- [x] No user-facing change

Testing
- [ ] Added or modified tests to cover new code paths
- [x] Covered by existing tests
(Please provide the names of the existing tests in the PR description.)
- [ ] Not required

Performance
- [ ] Tests ran and results are added in the PR description
- [ ] Issue filed with a link in the PR description
- [x] Not required

---------

Signed-off-by: Jihoon Son <ghoonson@gmail.com>
(cherry picked from commit eb9ffb1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants