Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Sep 28, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Expanded integration test waivers to skip additional scenarios (e.g., Eagle, ngram, LLaMA, Qwen), referencing known issues to stabilize CI.
    • Reduces noisy failures in pipelines by marking affected tests as SKIP.
    • No impact on product features, behavior, or performance; release artifacts remain unchanged.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250928_LLM_FUNCTION_TEST_1419 branch from 4f277cd to 3ac8894 Compare September 29, 2025 02:11
@xinhe-nv xinhe-nv marked this pull request as ready for review September 29, 2025 02:11
@xinhe-nv xinhe-nv enabled auto-merge (squash) September 29, 2025 02:12
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

📝 Walkthrough

Walkthrough

Added new SKIP entries to tests/integration/test_lists/waives.txt to expand the list of waived integration tests (including Eagle, ngram, Llama, Qwen, and related scenarios) with NV bug references. No other files were modified.

Changes

Cohort / File(s) Summary
Test waivers update
tests/integration/test_lists/waives.txt
Appended multiple SKIP annotations for additional integration tests (Eagle, ngram, Llama, Qwen, multimodal, etc.), referencing NV bug IDs. No removals or edits to existing entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description only contains a one-line note “waive failed cases” and does not follow the repository’s template: it lacks the required summary header or @coderabbitai summary, the ## Description and ## Test Coverage sections, and the checklist items, so it fails to provide the structured context and details expected. Please update the description to include the template’s @coderabbitai summary annotation, a detailed ## Description explaining what is being changed and why, a ## Test Coverage section listing relevant tests, and ensure the PR Checklist items are acknowledged as appropriate.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[None][chore] Add failed cases into waives.txt" clearly and concisely summarizes the primary change of adding entries to the waiver list and follows the repository’s title template by specifying type and context. It directly relates to the modifications in tests/integration/test_lists/waives.txt without unnecessary detail or noise.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28b9a81 and 3ac8894.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

359-370: New waivers follow established format

Entries are well-formed (path, selector, SKIP reason) and align with existing grouping near similar Eagle/ngram/long-context waives, so no action needed.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20196 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250928_LLM_FUNCTION_TEST_1419 branch 3 times, most recently from abf48eb to 663859f Compare September 29, 2025 03:53
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20196 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15231 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20207 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20207 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #15240 (Partly Tested) completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250928_LLM_FUNCTION_TEST_1419 branch from 663859f to c47264e Compare September 29, 2025 04:49
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20212 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20212 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15244 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250928_LLM_FUNCTION_TEST_1419 branch from c47264e to f659428 Compare September 29, 2025 07:11
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20231 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20232 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20231 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20232 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #20212 (Partly Tested) for commit f659428

@xinhe-nv xinhe-nv merged commit 20e6cd3 into NVIDIA:main Sep 29, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250928_LLM_FUNCTION_TEST_1419 branch September 29, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants