Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Nov 2, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated skip list configuration with additional entries for disaggregation-related test cases and improved test coverage scenarios.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251103_LLM_FUNCTION_CLUSTER_TEST_1114 branch from 945e815 to 9e33b13 Compare November 4, 2025 05:38
@xinhe-nv xinhe-nv marked this pull request as ready for review November 4, 2025 05:56
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Nov 4, 2025

/bot run --skip-test

@xinhe-nv xinhe-nv requested a review from jieli-matrix November 4, 2025 05:56
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

📝 Walkthrough

Walkthrough

The pull request adds multiple new SKIP entries to the integration test waiver list, excluding various failing test cases related to disaggregation and LLM configurations from integration test execution.

Changes

Cohort / File(s) Summary
Test waiver list updates
tests/integration/test_lists/waives.txt
Adds multiple SKIP entries for disaggregation-related and LLM test cases

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Homogeneous changes consisting solely of list entries
  • No logic modifications or structural changes
  • Straightforward verification of test case identifiers

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • jieli-matrix

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is severely incomplete, missing all required template sections including Description, Test Coverage, and PR Checklist. Provide a complete description following the template: explain what failed cases were added and why, detail the test coverage, and complete the PR checklist items.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding failed test cases to the waives.txt file, which matches the summary of changes.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ec6a6b and 9e33b13.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/waives.txt
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

392-403: No issues detected — the newly added waive entries are valid and non-duplicative.

Verification confirmed that all 12 new test entries (lines 392–403) are unique within the file with no duplicate conflicts. All entries follow the correct format and reference valid bug tracker URLs.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23467 [ run ] triggered by Bot. Commit: 9e33b13

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23467 [ run ] completed with state SUCCESS. Commit: 9e33b13
/LLM/main/L0_MergeRequest_PR pipeline #17668 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251103_LLM_FUNCTION_CLUSTER_TEST_1114 branch from 9e33b13 to 2852211 Compare November 5, 2025 02:40
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Nov 5, 2025

/bot reuse-pipeline

@xinhe-nv xinhe-nv enabled auto-merge (squash) November 5, 2025 02:47
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23563 [ reuse-pipeline ] triggered by Bot. Commit: 2852211

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23563 [ reuse-pipeline ] completed with state SUCCESS. Commit: 2852211
Reusing PR_Github #23467 (Partly Tested) for commit 2852211

@xinhe-nv xinhe-nv merged commit cc4aa29 into NVIDIA:main Nov 5, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251103_LLM_FUNCTION_CLUSTER_TEST_1114 branch November 5, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants