Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Aug 21, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Added three SKIP entries to the integration test skip list to exclude specific accuracy/disaggregated-serving scenarios from CI; entries reference NV defect tickets 5347051, 5471106, and 5471108.
    • No skip removals, no changes to product functionality. Estimated review effort: low/medium.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 21, 2025

📝 Walkthrough

Walkthrough

Added three SKIP entries to tests/integration/test_lists/waives.txt to exclude specific accuracy/disaggregated-serving tests, each referencing an NV bug ID. No other files or public APIs were changed.

Changes

Cohort / File(s) Summary of Changes
Test waiver manifest updates
tests/integration/test_lists/waives.txt
Added SKIP entries for: (1) accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_auto_dtype[mtp_nextn=0-overlap_scheduler=False] (nvbugs/5347051), (2) accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_eagle3[eagle3_one_model=False-overlap_scheduler=False] (nvbugs/5471106), (3) accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_tp_pp_symmetric[MMLU-tp2pp2] (nvbugs/5471108).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • yiqingy0

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d50c34f and 71ddd93.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)

322-324: Optional: add a cleanup signal (TTL/owner) for these waivers.

To prevent test coverage from silently eroding, consider annotating waivers with a short-lived TTL or owner tag (if your infra supports comments like “owner:team, expires:2025-09-21”). Otherwise, please track a follow-up to remove once the linked NV bugs are resolved.

If helpful, I can add a small pre-commit check that flags waivers older than N days or lacking an owner/expires field.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ba0a86e and ed65f28.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (2)
tests/integration/test_lists/waives.txt (2)

322-324: LGTM: targeted waivers with bug IDs; format matches existing patterns.

  • Entries follow the established "path::test SKIP (reason/link)" convention.
  • Good separation of param variants; note we already waive the sibling case with overlap_scheduler=True on Line 269, so adding the False variant here is appropriate to cover both paths.

322-324: Waiver List Verification Passed

Thanks for adding the new test waivers. I ran the provided self-check script and confirmed:

  • Each of the three new waivers appears exactly once.
  • Both overlap_scheduler=True and overlap_scheduler=False variants are present for TestDeepSeekV3Lite::test_auto_dtype.
  • All new lines include the required “ SKIP (” format.

All checks passed—no further changes needed.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250821_LLM_FUNCTION_TEST_1121 branch from ed65f28 to da61ecf Compare August 21, 2025 08:52
@xinhe-nv xinhe-nv marked this pull request as ready for review August 21, 2025 08:52
@xinhe-nv xinhe-nv enabled auto-merge (squash) August 21, 2025 08:52
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250821_LLM_FUNCTION_TEST_1121 branch from da61ecf to a3deaa9 Compare August 21, 2025 09:10
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #16039 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250821_LLM_FUNCTION_TEST_1121 branch from a3deaa9 to d50c34f Compare August 21, 2025 13:58
@tensorrt-cicd
Copy link
Collaborator

PR_Github #16039 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #12060 completed with status: 'FAILURE'

Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250821_LLM_FUNCTION_TEST_1121 branch from d50c34f to 71ddd93 Compare August 22, 2025 02:25
@LarryXFly LarryXFly disabled auto-merge August 22, 2025 02:39
@LarryXFly LarryXFly merged commit 4017f7c into NVIDIA:main Aug 22, 2025
4 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250821_LLM_FUNCTION_TEST_1121 branch August 27, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants