-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[None][chore] Add failed cases into waives.txt #7109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[None][chore] Add failed cases into waives.txt #7109
Conversation
📝 WalkthroughWalkthroughAdded three SKIP entries to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
322-324: Optional: add a cleanup signal (TTL/owner) for these waivers.To prevent test coverage from silently eroding, consider annotating waivers with a short-lived TTL or owner tag (if your infra supports comments like “owner:team, expires:2025-09-21”). Otherwise, please track a follow-up to remove once the linked NV bugs are resolved.
If helpful, I can add a small pre-commit check that flags waivers older than N days or lacking an owner/expires field.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
tests/integration/test_lists/waives.txt (2)
322-324: LGTM: targeted waivers with bug IDs; format matches existing patterns.
- Entries follow the established "path::test SKIP (reason/link)" convention.
- Good separation of param variants; note we already waive the sibling case with overlap_scheduler=True on Line 269, so adding the False variant here is appropriate to cover both paths.
322-324: Waiver List Verification PassedThanks for adding the new test waivers. I ran the provided self-check script and confirmed:
- Each of the three new waivers appears exactly once.
- Both
overlap_scheduler=Trueandoverlap_scheduler=Falsevariants are present forTestDeepSeekV3Lite::test_auto_dtype.- All new lines include the required “ SKIP (” format.
All checks passed—no further changes needed.
ed65f28 to
da61ecf
Compare
da61ecf to
a3deaa9
Compare
|
/bot run |
|
PR_Github #16039 [ run ] triggered by Bot |
a3deaa9 to
d50c34f
Compare
|
PR_Github #16039 [ run ] completed with state |
Signed-off-by: Xin He (SW-GPU) <[email protected]>
d50c34f to
71ddd93
Compare
waive failed cases.
Summary by CodeRabbit