[None][chore] Update CI allowlist 2025-08-25 #7229
Conversation
📝 WalkthroughWalkthroughThe CI workflow file Changes
Sequence Diagram(s)(omitted — change is a data-only update to an allowlist; no control-flow diagram needed) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/blossom-ci.yml (2)
43-44: Remove duplicate usernames to avoid confusion and future merge churn.I spotted at least these duplicates in the JSON array: "ixlmar" (appears twice) and "heyuhhh" (appears twice). Duplicates don’t break contains([...], github.actor), but pruning them reduces noise and risk of accidental conflicts when editing this line later.
Apply this minimal diff to drop the later duplicates:
-..."pamelap-nvidia","ixlmar","GalSha",... +..."pamelap-nvidia","GalSha",...-..."pengbowang-nv","lancelly","heyuhhh","mayani-nv",... +..."pengbowang-nv","lancelly","mayani-nv",...If you want, I can generate an automated check that fails CI on future duplicates.
43-44: Refactor: externalize the array for maintainability (shorter condition, easier edits).This single mega-line is hard to review and edit safely. Consider moving the JSON to an env var (folded multi-line string) and referencing it in the condition. Functionally identical, but far more maintainable.
Proposed refactor:
jobs: Authorization: name: Authorization runs-on: blossom + env: + # JSON array of authorized commenters + AUTHORIZED_COMMENTERS: >- + ["byshiue","chuangz0","funatiq","hypdeb","jdemouth-nvidia","joyang-nv","lowsfer","Tabrizian","yweng0828", + "Shixiaowei02","MartinMarciniszyn","schetlur-nv","dcampora","pcastonguay","Naveassaf","lfr-0531","nekorobov", + "... keep list here (deduped) ...", + "kris1025","karljang","zheyuf"] outputs: args: ${{ env.args }} # This job only runs for pull request comments if: | - (startsWith(github.event.comment.body, '/bot run') || + (startsWith(github.event.comment.body, '/bot run') || startsWith(github.event.comment.body, '/bot skip --comment') || startsWith(github.event.comment.body, '/bot reuse-pipeline') || - startsWith(github.event.comment.body, '/bot kill')) && contains( - fromJson('["byshiue", "... very long list ...", "zheyuf"]'), - github.actor) + startsWith(github.event.comment.body, '/bot kill')) && + contains(fromJson(env.AUTHORIZED_COMMENTERS), github.actor)Benefits:
- Easier code reviews and smaller diffs when the list changes.
- Lower risk of JSON typos.
- Keeps the if-expression concise.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/blossom-ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
.github/workflows/blossom-ci.yml (1)
43-44: Allowlist expansion matches PR objective; gating logic remains correct.The updated array cleanly widens authorized commenters and preserves the existing prefix checks for supported /bot commands. No structural or syntax issues with the if-expression.
yuanjingx87
force-pushed
the
user/yuanjingx/update_allowlist
branch
from
09027f5 to
30bf0d3
Compare
|
/bot skip --comment "Allow list update, no need to run CI" |
yuanjingx87
force-pushed
the
user/yuanjingx/update_allowlist
branch
from
30bf0d3 to
67623a8
Compare
|
PR_Github #16485 [ skip ] triggered by Bot |
|
PR_Github #16485 [ skip ] completed with state |
Signed-off-by: Yuanjing Xue <[email protected]>
Signed-off-by: Yuanjing Xue <[email protected]>
yuanjingx87
force-pushed
the
user/yuanjingx/update_allowlist
branch
from
67623a8 to
1e3f01e
Compare
|
/bot reuse-pipeline |
|
PR_Github #16516 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #16516 [ reuse-pipeline ] completed with state |
|
/bot skip --comment "Allow list update, no need to run CI" |
|
PR_Github #16519 [ skip ] triggered by Bot |
|
PR_Github #16519 [ skip ] completed with state |
5 participants
Description
Update allow list
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit