Skip to content

Conversation

@yuanjingx87
Copy link
Collaborator

@yuanjingx87 yuanjingx87 commented Oct 30, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow authorization configuration to expand the set of authorized commenters on automated processes.

Description

Update allow list

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yuanjing Xue <[email protected]>
@yuanjingx87 yuanjingx87 requested review from a team as code owners October 30, 2025 17:56
@yuanjingx87
Copy link
Collaborator Author

/bot skip --comment "no CI needed"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23080 [ skip ] triggered by Bot. Commit: c81964d

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

📝 Walkthrough

Walkthrough

The authorization condition in the blossom-ci workflow was extended by adding usernames to the fromJson array of allowed authors, enabling additional commenters to trigger CI runs without modifying surrounding control flow or other logic.

Changes

Cohort / File(s) Summary
CI Authorization Allowlist
\.github/workflows/blossom-ci\.yml
Extended JSON array of authorized commenters by adding new usernames to the fromJson list

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple configuration change with homogeneous additions to an authorization allowlist
  • Minimal logic complexity or risk
  • No control flow or functional logic modifications

Possibly related PRs

Suggested reviewers

  • schetlur-nv
  • tburt-nv
  • zeroepoch

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description is largely incomplete and does not adequately follow the provided template. The "Description" section contains only a single vague sentence ("Update allow list") without explaining what the allow list is, why it needs to be updated, what specific changes are being made, or the business/technical rationale. The "Test Coverage" section is entirely empty with no test information provided, despite the template explicitly requesting a clear list of relevant tests. While the PR title follows the correct format and a checklist is included, the core descriptive content required to understand the pull request is insufficient. The raw summary indicates changes to a JSON authorization array in the blossom-ci workflow, but this context is absent from the PR description itself, making it difficult for reviewers to understand the scope and purpose of the changes. The author should expand the "Description" section to clearly explain what the allow list change entails, why it is necessary, and which new usernames are being added to the authorization list. The "Test Coverage" section must be completed with details on what tests validate the changes to the blossom-ci workflow configuration, or an explanation of why no additional tests are needed for this infrastructure change. The PR description should be concrete and specific rather than relying solely on the title or external context.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[None][infra] Update allow list 20251030" follows the required template format with an appropriate type tag ([infra]) and clearly relates to the main change in the pull request. According to the raw summary, the PR extends the authorized authors list in the blossom-ci workflow, which directly corresponds to "updating an allow list." While the title is relatively concise and could be more specific about the purpose of the allow list, it is sufficiently clear that a teammate scanning the Git history would recognize this as infrastructure maintenance related to authorization configuration. The inclusion of the date adds specificity even if slightly redundant.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec31363 and c81964d.

📒 Files selected for processing (1)
  • .github/workflows/blossom-ci.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: xinhe-nv
PR: NVIDIA/TensorRT-LLM#8534
File: scripts/format_test_list.py:1-6
Timestamp: 2025-10-22T06:53:47.017Z
Learning: The file `scripts/format_test_list.py` in the TensorRT-LLM repository does not require the NVIDIA Apache-2.0 copyright header.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23080 [ skip ] completed with state SUCCESS. Commit: c81964d
Skipping testing for commit c81964d

@yuanjingx87 yuanjingx87 enabled auto-merge (squash) October 30, 2025 22:31
@yuanjingx87 yuanjingx87 merged commit fe670af into NVIDIA:main Oct 30, 2025
8 of 11 checks passed
fredricz-20070104 pushed a commit to fredricz-20070104/TensorRT-LLM that referenced this pull request Nov 5, 2025
Signed-off-by: Yuanjing Xue <[email protected]>
Signed-off-by: FredricZ-2007 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants