[None][infra] Update the allow list of CI trigger #6168
Conversation
WalkthroughThe update modifies the Blossom-CI GitHub Actions workflow by expanding the list of authorized GitHub usernames permitted to trigger specific bot commands. No changes were made to the workflow's logic or structure; only additional usernames were appended to the authorization check. Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/blossom-ci.yml (2)
43-44: Duplicate usernames – eliminate redundancy
"ixlmar"appears three times in the array. While harmless at runtime, it clutters the allow-list.- ... "ixlmar", ... "ixlmar", ... + ... "ixlmar", ...
43-44: Allow-list is now hard to read & maintainThe ever-growing single-line JSON string (~4 kB) mixes spacing styles. Consider:
- Moving the usernames to a separate file (e.g.
.github/allowed-users.json) and loading it in a prior step, or- Replacing the hard-coded list with a GitHub team/organization membership check.
Either approach improves readability and avoids future merge conflicts.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/blossom-ci.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/blossom-ci.yml (1)
43-44: Close to GitHub Actions 10 kB expression limitGitHub limits conditional expressions to 10 kB. With the current growth rate, the
fromJson(...)string may soon exceed this cap and break the workflow.Please verify the current size and plan a refactor before it becomes an operational issue.
Signed-off-by: tensorrt-cicd <[email protected]>
|
/bot skip --comment "Not tested by L0" |
chzblych
changed the title
chzblych
changed the title
|
PR_Github #12292 [ skip ] triggered by Bot |
|
PR_Github #12292 [ skip ] completed with state |
Signed-off-by: tensorrt-cicd <[email protected]> Co-authored-by: tensorrt-cicd <[email protected]>
Signed-off-by: tensorrt-cicd <[email protected]> Co-authored-by: tensorrt-cicd <[email protected]>
Signed-off-by: tensorrt-cicd <[email protected]> Co-authored-by: tensorrt-cicd <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
3 participants
Summary by CodeRabbit
Description
Test CodeRabbit <- This line should exist after rebasing.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.