Repository navigation
[None][refactor] define a shared multimodal model protocol - #20906
Draft
yechank-nvidia wants to merge 1 commit into
Draft
yechank-nvidia wants to merge 1 commit into
yechank-nvidia wants to merge 1 commit into
Conversation
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Define one
SupportsMultimodalcontract for model capabilities, encoder execution, item scheduling, fusion, and model-owned cache access. The executor uses this contract;MultimodalModelMixinprovides the existing shared implementation. Independent implementations can opt in with a class marker.Reuse the existing cache through public accessors, including the existing initialization hook. Accept Nemotron's read-only encoder-group property and align five encoder entry-point annotations with the mixin's
Sequenceinput. Encoder computations, cache ownership, and tensor return values are preserved.Developed independently on main (
9619d5b2ee), without depending on batching #20897 or handoff #20902. Config-only support hooks match encoder-DP #17330 and attention-backend #20802; their defaults declare no support. Batching's encoded Params-view returns will be incorporated after it lands. The model onboarding guide documents these roles.Validation
9619d5b2ee.PR Checklist