Repository navigation
[TRTLLM-12869][refactor] reuse encoder layouts with a compatible handoff - #20902
Draft
yechank-nvidia wants to merge 23 commits into
Draft
yechank-nvidia wants to merge 23 commits into
yechank-nvidia wants to merge 23 commits into
Conversation
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Use common item selection for partial-cache misses so prompt order, modality-local payload indices, and canonical output lengths stay aligned. Reuse validated request metadata and contiguous tensor views during input preparation. Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
…adata Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
… hashing Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #20897 (
bab3171542), after #20391. Review the handoff-only changes.Description
Let prefill reuse an encoder's completed prompt/layout instead of rebuilding it. Encoded items and optional finalized layout use one versioned payload, with model-selected, P-owned state for decode.
Existing Dynamo remains compatible. Keep the existing
DisaggregatedParamsconstructor fields, attributes, processor hook, and default result output. New consumers explicitly opt in:The new method is a beta API addition. Both formats feed the common execution Params; postprocessing preserves the payload and each consumer's selected output. Existing APIs are not deprecated in this PR. Announce a transition period before a later removal.
Coordinated consumer: ai-dynamo/dynamo#17185, which also retains its older-backend fallback.
Test Coverage
AIPerf, peak-memory comparison, and GPU-isolated Dynamo E/P/D remain pending. Local NIXL P/D initialization did not complete on this node and is not counted as a pass. No new model/modality support or performance gain is claimed.
PR Checklist