Skip to content

[None][chore] Add failed cases into waives.txt#11363

Merged
jieli-matrix merged 2 commits intoNVIDIA:mainfrom
xinhe-nv:user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282
Feb 10, 2026
Merged

[None][chore] Add failed cases into waives.txt#11363
jieli-matrix merged 2 commits intoNVIDIA:mainfrom
xinhe-nv:user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Feb 8, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip configurations to exclude specific model test scenarios from the test suite.

@jieli-matrix jieli-matrix marked this pull request as ready for review February 10, 2026 03:17
@jieli-matrix jieli-matrix enabled auto-merge (squash) February 10, 2026 03:17
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

This PR adds two SKIP entries to the test waiver list for Llama3 guided decoding tests with eagle3, marking them as skipped in the integration test suite.

Changes

Cohort / File(s) Summary
Test Waiver Updates
tests/integration/test_lists/waives.txt
Added SKIP entries for two Llama3 guided decoding with eagle3 test cases (llguidance and xgrammar variants).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • StanleySun639
  • LarryXFly
  • crazydemo
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is minimal and lacks detail about why these specific test cases are being waived and their context. Expand the description to explain which tests are being waived, why they failed, and the conditions under which the waive applies.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format and clearly indicates this is a chore that adds failed test cases to the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jieli-matrix jieli-matrix self-assigned this Feb 10, 2026
@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282 branch from 684a373 to 741efbe Compare February 10, 2026 05:49
@jieli-matrix
Copy link
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35424 [ run ] triggered by Bot. Commit: 741efbe

@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282 branch from 741efbe to e5fb7ef Compare February 10, 2026 06:29
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35446 [ run ] triggered by Bot. Commit: e5fb7ef

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282 branch 2 times, most recently from 91adc86 to e227532 Compare February 10, 2026 08:23
@tensorrt-cicd
Copy link
Collaborator

PR_Github #35446 [ run ] completed with state SUCCESS. Commit: e5fb7ef
/LLM/main/L0_MergeRequest_PR pipeline #27379 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35478 [ reuse-pipeline ] triggered by Bot. Commit: e227532

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282 branch from e227532 to 24bb071 Compare February 10, 2026 09:35
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35480 [ reuse-pipeline ] triggered by Bot. Commit: 24bb071

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35478 [ reuse-pipeline ] completed with state ABORTED. Commit: e227532
Can't reuse PR_Github #35446 (Partly Tested) with status: SUCCESS

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282 branch from 24bb071 to c9c074b Compare February 10, 2026 09:53
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282 branch from c9c074b to 3ae5e9d Compare February 10, 2026 09:56
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35494 [ reuse-pipeline ] triggered by Bot. Commit: 3ae5e9d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35480 [ reuse-pipeline ] completed with state ABORTED. Commit: 24bb071
Can't reuse PR_Github #35446 (Partly Tested) with status: SUCCESS

@tensorrt-cicd
Copy link
Collaborator

PR_Github #35494 [ reuse-pipeline ] completed with state SUCCESS. Commit: 3ae5e9d
Reusing PR_Github #35446 (Partly Tested) for commit 3ae5e9d

@jieli-matrix jieli-matrix merged commit 6e0659d into NVIDIA:main Feb 10, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260208_LLM_FUNCTION_CLUSTER_TEST_1282 branch February 11, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments