Skip to content

[None][chore] Add failed cases into waives.txt#10993

Merged
jieli-matrix merged 3 commits intoNVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260126_LLM_FUNCTION_TEST_1870
Jan 27, 2026
Merged

[None][chore] Add failed cases into waives.txt#10993
jieli-matrix merged 3 commits intoNVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260126_LLM_FUNCTION_TEST_1870

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 26, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip list to exclude two test scenarios from execution.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
…ION_TEST_1870

Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
@jieli-matrix jieli-matrix marked this pull request as ready for review January 27, 2026 09:23
@jieli-matrix jieli-matrix enabled auto-merge (squash) January 27, 2026 09:23
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

Two test cases are added to the waives list to skip execution: one for OpenAI GPT OSS 120B guided decoding and another for Llama 3.1 8B with the PTP quickstart advanced ngram test. No functional changes are present.

Changes

Cohort / File(s) Summary
Test Waiver Entries
tests/integration/test_lists/waives.txt
Added two SKIP entries for failing integration tests: test_e2e.py::test_openai_chat_guided_decoding[openai/gpt-oss-120b] and test_e2e.py::test_ptp_quickstart_advanced_ngram[Llama-3.1-8B-Instruct-llama-3.1-model/Llama-3.1-8B-Instruct]

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too minimal and lacks required sections like explanation of the issue, solution details, and test coverage information from the template. Expand the description to include why these specific test cases are failing and need to be waived, and reference any relevant test coverage or issue tracking.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding failed test cases to waives.txt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33715 [ run ] triggered by Bot. Commit: 1bdd718

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33715 [ run ] completed with state SUCCESS. Commit: 1bdd718
/LLM/main/L0_MergeRequest_PR pipeline #26004 (Partly Tested) completed with status: 'SUCCESS'

@jieli-matrix
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33724 [ reuse-pipeline ] triggered by Bot. Commit: 1bdd718

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33724 [ reuse-pipeline ] completed with state SUCCESS. Commit: 1bdd718
Reusing PR_Github #33715 (Partly Tested) for commit 1bdd718

@jieli-matrix jieli-matrix merged commit 552aa32 into NVIDIA:main Jan 27, 2026
7 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260126_LLM_FUNCTION_TEST_1870 branch January 28, 2026 01:19
@jieli-matrix jieli-matrix self-assigned this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants