Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Feb 2, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Added skip entry to test configuration list for specific LLM API PyTorch integration test variant.

@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260203_LLM_FUNCTION_TEST_1888 branch from 866f32c to bda6dd8 Compare February 3, 2026 03:17
@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260203_LLM_FUNCTION_TEST_1888 branch from 06fd67b to ca5724f Compare February 3, 2026 05:32
@jieli-matrix jieli-matrix marked this pull request as ready for review February 3, 2026 05:33
@jieli-matrix jieli-matrix enabled auto-merge (squash) February 3, 2026 05:34
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@jieli-matrix jieli-matrix self-assigned this Feb 3, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

A test entry for accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_1gpu[v1_kv_cache-True-True-triton-auto] was added to the test waives skip list to exclude it from test execution.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Added skip entry for TestGPTOSS::test_w4_1gpu test with v1_kv_cache parameters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • StanleySun639
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required template sections including detailed explanation of the issue, test coverage information, and PR checklist completion. Expand the description to include: detailed explanation of which test cases were added and why they failed, relevant test coverage details, and completion of the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding failed test cases to the waives.txt file, which directly matches the pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34569 [ run ] triggered by Bot. Commit: d2985dc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34569 [ run ] completed with state SUCCESS. Commit: d2985dc
/LLM/main/L0_MergeRequest_PR pipeline #26677 (Partly Tested) completed with status: 'SUCCESS'

@jieli-matrix
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34588 [ reuse-pipeline ] triggered by Bot. Commit: 8dda38d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34588 [ reuse-pipeline ] completed with state SUCCESS. Commit: 8dda38d
Reusing PR_Github #34569 (Partly Tested) for commit 8dda38d

@jieli-matrix jieli-matrix merged commit b7767f6 into NVIDIA:main Feb 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants