Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 25, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Expanded the integration test waivers list to skip additional test cases during automated test runs.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv marked this pull request as ready for review January 26, 2026 05:23
@xinhe-nv xinhe-nv enabled auto-merge (squash) January 26, 2026 05:24
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

Modified the test waiver list by adding three new SKIP entries for failing integration tests. Each entry includes a corresponding NVIDIA bug identifier. No functional code changes were made; only the test skip configuration was extended.

Changes

Cohort / File(s) Change Summary
Test Waiver Configuration
tests/integration/test_lists/waives.txt
Added 3 SKIP entries for integration tests with nvbugs references, expanding the set of explicitly waived tests

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • jieli-matrix
  • StanleySun639
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required sections such as detailed explanation of changes, test coverage information, and PR checklist items specified in the template. Expand the description to include: (1) why these specific test cases are being waived, (2) which test cases were added and their nvbugs IDs, and (3) complete the PR checklist items as shown in the repository template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding failed test cases to the waives.txt file, which matches the changeset modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33527 [ run ] triggered by Bot. Commit: 918becb

@xinhe-nv
Copy link
Collaborator Author

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33530 [ run ] triggered by Bot. Commit: 21bdcac

@xinhe-nv xinhe-nv requested a review from jieli-matrix January 26, 2026 05:51
@tensorrt-cicd
Copy link
Collaborator

PR_Github #33530 [ run ] completed with state SUCCESS. Commit: 21bdcac
/LLM/main/L0_MergeRequest_PR pipeline #25867 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33541 [ reuse-pipeline ] triggered by Bot. Commit: b18eeb7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33541 [ reuse-pipeline ] completed with state SUCCESS. Commit: b18eeb7
Reusing PR_Github #33530 (Partly Tested) for commit b18eeb7

@xinhe-nv xinhe-nv merged commit d3406cb into NVIDIA:main Jan 26, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260125_LLM_FUNCTION_CLUSTER_TEST_1246 branch January 26, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants