Skip to content

[None][chore] Add failed cases into waives.txt#10992

Closed
xinhe-nv wants to merge 7 commits intoNVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260126_LLM_FUNCTION_TEST_1867
Closed

[None][chore] Add failed cases into waives.txt#10992
xinhe-nv wants to merge 7 commits intoNVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260126_LLM_FUNCTION_TEST_1867

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 26, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Refined test waiver and skip list configurations for improved test infrastructure management across multiple test scenarios.

✏️ Tip: You can customize this high-level summary in your review settings.

@jieli-matrix jieli-matrix self-assigned this Jan 29, 2026
@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260126_LLM_FUNCTION_TEST_1867 branch from 5cc6b52 to de01750 Compare January 29, 2026 04:29
@jieli-matrix jieli-matrix marked this pull request as ready for review January 29, 2026 04:29
@jieli-matrix jieli-matrix enabled auto-merge (squash) January 29, 2026 04:29
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Updated the test waiver list to modify skip entries for integration tests. One existing entry was reformatted, and multiple new SKIP entries were added for various test paths and model variants covering full execution, disaggregated accuracy, and vendor-specific test cases.

Changes

Cohort / File(s) Summary
Test Waiver List
tests/integration/test_lists/waives.txt
Reformatted one existing skip entry for test_openai_chat_guided_decoding[openai/gpt-oss-120b]. Added nine new SKIP entries for test cases spanning full:sm120, full:sm_120, accuracy/disaggregated, and model/vendor qualifier variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • StanleySun639
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks required sections from the template, including clear explanation of the issue/solution, test coverage details, and the PR checklist. Expand the description to include: detailed explanation of which tests failed and why they were waived, relevant test coverage information, and completion of the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding failed test cases to the waives.txt file, which aligns with the file modifications summarized.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@tests/integration/test_lists/waives.txt`:
- Line 362: The waiver entry
"test_e2e.py::test_openai_chat_guided_decoding[openai/gpt-oss-120b] SKIP" is
missing a bug URL for traceability; update the waives file by appending the same
style of bug reference used in the nearby entries (e.g., the bug URL pattern
present for lines 281 and 363-369) to this line so maintainers can track the
issue and know when to re-enable the test.
- Line 281: Update the incorrect prefix and missing bug link: replace the entry
"full:sm_120/accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_eagle3_4gpus[cutlass-one_model-overlap_scheduler]
SKIP (https://nvbugs/5849562)" to use "full:sm120/..." (remove the underscore so
it matches the sm120 convention used elsewhere, e.g., skip_no_sm120 and
test_ptp_quickstart_advanced_2gpus_sm120), and add the missing bug URL to the
"test_e2e.py::test_openai_chat_guided_decoding[openai/gpt-oss-120b] SKIP" entry
so it includes a bug reference like the other SKIP lines.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33972 [ run ] triggered by Bot. Commit: de01750

@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33973 [ run ] triggered by Bot. Commit: 4a702e2

@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33978 [ run ] triggered by Bot. Commit: caa41ef

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33978 [ run ] completed with state SUCCESS. Commit: caa41ef
/LLM/main/L0_MergeRequest_PR pipeline #26211 (Partly Tested) completed with status: 'SUCCESS'

@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260126_LLM_FUNCTION_TEST_1867 branch 2 times, most recently from 25fbf91 to ed69e5d Compare January 29, 2026 06:51
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list "RTXPro6000-PyTorch-1, RTXPro6000D-PyTorch-2, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@jieli-matrix
Copy link
Collaborator

/bot run --stage-list "RTXPro6000D-PyTorch-1, RTXPro6000D-PyTorch-2, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34003 [ run ] triggered by Bot. Commit: ed69e5d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34005 [ run ] triggered by Bot. Commit: ed69e5d

jieli-matrix and others added 7 commits January 29, 2026 15:20
Signed-off-by: Jie Li <lijie@nvidia.com>
Signed-off-by: Jie Li <lijie@nvidia.com>
Signed-off-by: Jie Li <lijie@nvidia.com>
Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
Signed-off-by: Jie Li <lijie@nvidia.com>
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list "RTXPro6000D-PyTorch-1, RTXPro6000D-PyTorch-2, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"

@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20260126_LLM_FUNCTION_TEST_1867 branch from 7660f53 to 2142cc3 Compare January 29, 2026 07:22
@tensorrt-cicd
Copy link
Collaborator

PR_Github #34007 [ run ] triggered by Bot. Commit: 2142cc3

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34007 [ run ] completed with state SUCCESS. Commit: 2142cc3
/LLM/main/L0_MergeRequest_PR pipeline #26235 (Partly Tested) completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

auto-merge was automatically disabled February 10, 2026 09:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants