test(cli): cover sandbox oclif command adapters

[cv]

Summary

Remove broad coverage ignores from sandbox oclif adapters whose parser behavior can now be tested in-process.

Stack Navigation

• Position: 40 of 60
• Previous PR: #2937 — test(cli): cover global oclif command adapters
• Next PR: #2939 — refactor(cli): split share oclif commands

Changes

• Removed file-level V8 ignores from sandbox connect, lifecycle, inspection, doctor, logs, policy/channel, snapshot, skill, and shields adapters.
• Added direct command-adapter coverage for connect/lifecycle option mapping, inspection actions, doctor flags, and shields flags.
• Reused existing command-family tests for logs, policy/channel mutation, snapshot, and skill adapters.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• New Features

  • Introduced sandbox:doctor command for sandbox and gateway health diagnostics
  • Added parent commands for skill and snapshot operations
  • Added --tail/-n and --since options to logs command

• Improvements

  • Channel argument now required for all channel mutation commands
  • Format flag for config get strictly validates to json or yaml options
  • Added -y shorthand for yes flag in destroy and rebuild commands
  • CLI commands now display helpful usage examples

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0b402844-f00b-4b11-91df-02546480a8c4

📥 Commits

Reviewing files that changed from the base of the PR and between 8a6ecbc and 6133caa.

📒 Files selected for processing (1)

• src/lib/skill-install-cli-command.ts

---

📝 Walkthrough

Walkthrough

The PR updates CLI command infrastructure across multiple adapter files: requiring arguments in channel commands, adding CLI usage examples to 11 commands, migrating 2 commands to NemoClawCommand, introducing a new sandbox:doctor command, extending the logs runtime bridge to support tail and since options, and adding comprehensive test coverage for CLI command adapters.

Changes

CLI Command Metadata and Argument Updates

Layer / File(s)	Summary
Argument Requirements src/lib/channels-mutate-cli-commands.ts	channel argument made required (required: true) for all four channel mutation commands.
New Sandbox Doctor Command src/lib/sandbox-doctor-cli-command.ts	New SandboxDoctorCliCommand class added with required sandboxName argument, optional --json flag, and implementation that invokes runSandboxDoctor with diagnostics output.
Base Class Migrations src/lib/destroy-cli-command.ts, src/lib/rebuild-cli-command.ts	Both DestroyCliCommand and RebuildCliCommand migrated from Command to NemoClawCommand base class; yes flag gains -y shorthand in both.
Runtime Bridge Interface Updates src/lib/sandbox-logs-cli-command.ts	SandboxLogsRuntimeBridge.sandboxLogs signature expanded from (sandboxName: string, follow: boolean) to (sandboxName: string, options: SandboxLogsOptions) to support follow, lines (tail), and since parameters.
Options Object Wiring src/lib/destroy-cli-command.ts, src/lib/rebuild-cli-command.ts	run() methods updated to pass typed options objects ({ force, yes } and { force, verbose, yes } respectively) to sandbox actions instead of legacy string arrays.
Flag Refinements src/lib/policy-mutate-cli-commands.ts, src/lib/shields-cli-commands.ts	PolicyAddCommand flags --from-file and --from-dir marked mutually exclusive; ShieldsDownCommand.timeout switched to use shieldsTimeoutDurationFlag helper.
Inspection Command Improvements src/lib/sandbox-inspection-cli-command.ts	SandboxConfigGetCommand.format flag updated with constrained options: ["json", "yaml"]; manual runtime validation removed.
New Skill and Snapshot Commands src/lib/skill-install-cli-command.ts, src/lib/snapshot-cli-commands.ts	Added SkillCliCommand and SnapshotCommand as parent commands; made skillPath argument required in SkillInstallCliCommand.
CLI Examples and Documentation src/lib/channels-mutate-cli-commands.ts, src/lib/connect-cli-command.ts, src/lib/policy-mutate-cli-commands.ts, src/lib/sandbox-inspection-cli-command.ts, src/lib/sandbox-logs-cli-command.ts, src/lib/skill-install-cli-command.ts, src/lib/snapshot-cli-commands.ts	Added or expanded static examples arrays to 11 commands with representative CLI invocations; removed v8 ignore coverage suppression comments from 5 files.
Test Coverage src/lib/sandbox-oclif-command-adapters.test.ts	New Vitest suite with 3 test cases verifying CLI flag-to-option mapping for connect/destroy/rebuild, inspection commands, doctor, and shields commands.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• NVIDIA/NemoClaw#2816: Concurrent refactoring of the same CLI adapter files and runtime-bridge dependencies, updating imports and usages alongside command metadata changes.

Suggested reviewers

• cjagwani

Poem

🐰 CLI commands now dance with grace,
Examples guide each case,
Options flow where strings once lay,
Doctor checks the sandbox way,
A healthier interface, hip hip hooray! 🎉

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/coverage-sandbox-oclif-adapters

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cjagwani]

Approved as part of stack from #2886 (auto-approve: CI green, no scope/behavior flags).