test(cli): cover oclif metadata routing helpers

[cv]

Summary

Remove broad coverage ignores from oclif command metadata and routing helpers now that they are directly unit-tested.

Stack Navigation

• Position: 38 of 60
• Previous PR: #2930 — refactor(cli): project public help through oclif
• Next PR: #2937 — test(cli): cover global oclif command adapters

Changes

• Removed file-level V8 ignores from command-registry.ts and oclif-dispatch.ts.
• Added direct dispatch coverage for global command routes, nested sandbox routes, usage errors, and unknown actions.
• Kept coverage focused on helper behavior instead of source-shape assertions.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• New Features

  • Enhanced command routing and dispatch system for improved CLI command handling.

• Improvements

  • Updated command flags with clearer confirmation syntax (--yes, --force options).
  • Improved sandbox logs flag configuration.
  • Better help and usage error messaging for invalid command requests.
  • Refined --version flag behavior.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4a2922da-d01b-43f2-b1c5-5b823414cbfe

📥 Commits

Reviewing files that changed from the base of the PR and between 3978c32 and 864eb30.

📒 Files selected for processing (3)

• src/lib/command-registry.ts
• src/lib/oclif-dispatch.test.ts
• src/lib/oclif-dispatch.ts

---

📝 Walkthrough

Walkthrough

A new dispatch layer (oclif-dispatch.ts) maps CLI commands to oclif command IDs and handles routing logic for global and sandbox-scoped commands, with special handling for nested subcommands, help flags, and unknown actions. The CommandDef interface adds a commandId field, and the command registry is updated with new IDs and expanded flag syntax.

Changes

Command Dispatch Layer

Layer / File(s)	Summary
Data Shape src/lib/command-registry.ts	CommandDef interface adds commandId: string field. All COMMANDS registry entries are populated with commandId values, and flag strings are updated with expanded syntax (e.g., sandbox logs, rebuild, destroy, and config commands).
Dispatch Core src/lib/oclif-dispatch.ts	New module exports DispatchResult union type (oclif, help, usage error, unknown subcommand, unknown action) and two resolver functions. resolveGlobalOclifDispatch routes global commands including tunnel, credentials, and --version handling. resolveSandboxOclifDispatch uses flat and nested routing tables to map sandbox actions to oclif commands or return structured errors.
Tests src/lib/oclif-dispatch.test.ts	New test block validates resolveGlobalOclifDispatch for simple/nested commands and --version. Expanded sandbox tests cover nested channels operations, invalid config/shields requests returning usageError, and unknownAction dispatch for unsupported actions. Snapshot test verifies oclif dispatch routing.

Sequence Diagram

sequenceDiagram
    participant CLI as CLI Input
    participant Dispatch as Dispatch Layer
    participant Result as DispatchResult
    participant Oclif as oclif Executor
    
    CLI->>Dispatch: command + args
    alt Global Command Route
        Dispatch->>Dispatch: Check GLOBAL_ROUTES
        Dispatch->>Dispatch: Handle special cases<br/>(tunnel, credentials, --version)
    else Sandbox Command Route
        Dispatch->>Dispatch: Check FLAT_SANDBOX_ROUTES
        alt Found in Flat Routes
            Dispatch->>Result: Return OclifDispatch
        else Try Nested Routes
            Dispatch->>Dispatch: Parse nested subcommands
            Dispatch->>Dispatch: Validate against route config
            alt Valid Subcommand
                Dispatch->>Result: Return OclifDispatch
            else Invalid or Help Flag
                Dispatch->>Result: Return Help/UsageError/<br/>UnknownSubcommand
            end
        end
    end
    
    Result-->>CLI: DispatchResult
    alt OclifDispatch
        Result->>Oclif: commandId + args
        Oclif-->>CLI: command execution
    else Help/Error/Unknown
        Result-->>CLI: structured outcome
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A dispatch layer hops into place,
Commands now carry their ID case,
Routes unfold like clover leaves green,
Global and sandbox flows in between,
Help flags flutter as the code takes flight!

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/coverage-routing-helpers

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cjagwani]

Approved as part of stack from #2886 (auto-approve: CI green, no scope/behavior flags).