refactor(cli): split share oclif commands

[cv]

Summary

Split share oclif command classes out of the SSHFS action/helper module so parser adapters and action logic are independently testable.

Stack Navigation

• Position: 41 of 60
• Previous PR: #2938 — test(cli): cover sandbox oclif command adapters
• Next PR: #2940 — test(cli): narrow sandbox logs coverage ignores

Changes

• Added share-cli-commands.ts for the share parent and mount/unmount/status oclif adapters.
• Left SSHFS action helpers in share-command.ts.
• Updated the oclif command registry to import share command classes from the new adapter module.
• Added direct share adapter tests with mocked share actions.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• Tests

  • Added comprehensive unit tests for share CLI command adapters, including validation of parent usage routing and subcommand mapping to actions.

• Refactor

  • Reorganized share CLI command structure across modules for improved code organization.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6a90261f-d2b8-48a1-b49a-40b19baf66ca

📥 Commits

Reviewing files that changed from the base of the PR and between a3ee273 and 0e62d70.

📒 Files selected for processing (4)

• src/lib/oclif-commands.ts
• src/lib/share-cli-commands.test.ts
• src/lib/share-cli-commands.ts
• src/lib/share-command.ts

---

📝 Walkthrough

Walkthrough

A CLI command module reorganization moves the share command classes (ShareCommand, ShareMountCommand, ShareUnmountCommand, ShareStatusCommand) from share-command.ts to a new share-cli-commands.ts file, updates the import in oclif-commands.ts, and adds comprehensive unit tests for the moved commands.

Changes

Share Command Module Reorganization

Layer / File(s)	Summary
Core Logic Extraction src/lib/share-cli-commands.ts	New module defines ShareCommand, ShareMountCommand, ShareUnmountCommand, and ShareStatusCommand with oclif wiring. Commands delegate to existing runtime functions (runShareMount, runShareUnmount, runShareStatus, printShareUsageAndExit) imported from share-command. Includes sandboxNameArg helper and full usage/help text for each subcommand.
Legacy Module Cleanup src/lib/share-command.ts	Removes oclif command classes and sandboxNameArg constant. Preserves internal runtime functions and usage-printing logic that are now imported by share-cli-commands.
Import Wiring src/lib/oclif-commands.ts	Updates import source for ShareCommand and its subcommands from ./share-command to ./share-cli-commands. Public command mappings unchanged.
Tests & Verification src/lib/share-cli-commands.test.ts	Adds unit tests for parent command usage routing and subcommand argument-to-action mapping. Mocks runtime handlers and verifies correct argument payloads passed to each command action.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A hop, a skip, a folder move—
The share commands found their groove,
From one file split to two so clean,
The finest refactor ever seen!
Tests now guard what's on the way,
Unix pipes dance another day. 🥕

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/split-share-cli-commands

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cjagwani]

Approved as part of the oclif refactor stack — deep review confirmed the smoke flag (+1 throw) was a test mock, not production.

[prekshivyas]

LGTM. Clean file split — four share oclif Command classes (ShareCommand + Mount/Unmount/Status) move verbatim from share-command.ts into a new share-cli-commands.ts. SSHFS action helpers stay in share-command.ts and are imported by the new adapter module. Zero behavior change.

+60 lines of new direct adapter tests in share-cli-commands.test.ts.

CI: pr.yaml mostly green (lint/dco/check-hash/legacy-path-guard/changes PASS); macos-e2e/checks + pr-self-hosted builds still in flight at review time. No failures.