update and deprecate warning for Mic notebook #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fayejf <[email protected]>
Signed-off-by: fayejf <[email protected]>
Signed-off-by: fayejf <[email protected]>
Signed-off-by: fayejf <[email protected]>
Signed-off-by: fayejf <[email protected]>
titu1994
approved these changes
Mar 28, 2023
| @@ -29,9 +29,6 @@ | |||
| "BRANCH = 'r1.17.0'\n", | |||
| "!python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[asr]\n", | |||
| "\n", | |||
| "## Install TorchAudio\n", | |||
There was a problem hiding this comment.
Instead of removing it, just comment that it cannot be installed on cuda 12 for the time being
There was a problem hiding this comment.
this notebook does not need torchaudio
| "pip install pyaudio\n", | ||
| "```" | ||
| ] | ||
| }, | ||
| { |
There was a problem hiding this comment.
Revert, this notebook won't run without Torchaudio
There was a problem hiding this comment.
Or add back the instructions to install Torchaudio as below
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
* update Online_ASR_Microphone_Demo.ipynb Signed-off-by: fayejf <[email protected]> * update Online_Offline_Speech_Commands_Demo.ipynb Signed-off-by: fayejf <[email protected]> * update Online_Offline_Microphone_VAD_Demo.ipynb Signed-off-by: fayejf <[email protected]> * update Online_Offline_Microphone_VAD_Demo.ipynb \n Signed-off-by: fayejf <[email protected]> * remove 'each' Signed-off-by: fayejf <[email protected]> --------- Signed-off-by: fayejf <[email protected]>
fayejf
added a commit
that referenced
this pull request
Mar 28, 2023
* update Online_ASR_Microphone_Demo.ipynb * update Online_Offline_Speech_Commands_Demo.ipynb * update Online_Offline_Microphone_VAD_Demo.ipynb * update Online_Offline_Microphone_VAD_Demo.ipynb \n * remove 'each' --------- Signed-off-by: fayejf <[email protected]> Co-authored-by: fayejf <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
) * update Online_ASR_Microphone_Demo.ipynb * update Online_Offline_Speech_Commands_Demo.ipynb * update Online_Offline_Microphone_VAD_Demo.ipynb * update Online_Offline_Microphone_VAD_Demo.ipynb \n * remove 'each' --------- Signed-off-by: fayejf <[email protected]> Co-authored-by: fayejf <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
add warning about "The incompatibility of components could lead to failure of running this notebook locally with container, we might deprecate this notebook and provide a better tutorial in soon releases."
Collection: [ASR]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information