Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and deprecate warning for Mic notebook #6309

Merged

Conversation

github-actions[bot]
Copy link
Contributor

What does this PR do ?

add warning about "The incompatibility of components could lead to failure of running this notebook locally with container, we might deprecate this notebook and provide a better tutorial in soon releases."

Collection: [ASR]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

* update Online_ASR_Microphone_Demo.ipynb

Signed-off-by: fayejf <[email protected]>

* update Online_Offline_Speech_Commands_Demo.ipynb

Signed-off-by: fayejf <[email protected]>

* update Online_Offline_Microphone_VAD_Demo.ipynb

Signed-off-by: fayejf <[email protected]>

* update Online_Offline_Microphone_VAD_Demo.ipynb \n

Signed-off-by: fayejf <[email protected]>

* remove 'each'

Signed-off-by: fayejf <[email protected]>

---------

Signed-off-by: fayejf <[email protected]>
@fayejf fayejf merged commit da88efb into main Mar 28, 2023
@fayejf fayejf deleted the cherry-pick-main-37b613283158c9a0bf318c3468b7fda01873c3ab branch March 28, 2023 16:10
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
)

* update Online_ASR_Microphone_Demo.ipynb



* update Online_Offline_Speech_Commands_Demo.ipynb



* update Online_Offline_Microphone_VAD_Demo.ipynb



* update Online_Offline_Microphone_VAD_Demo.ipynb \n



* remove 'each'



---------

Signed-off-by: fayejf <[email protected]>
Co-authored-by: fayejf <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant