Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update and deprecate warning for Mic notebook #6307

Merged
merged 6 commits into from
Mar 28, 2023
Merged

update and deprecate warning for Mic notebook #6307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50a2be9
update Online_ASR_Microphone_Demo.ipynb
fayejf Mar 27, 2023
e8d3c92
update Online_Offline_Speech_Commands_Demo.ipynb
fayejf Mar 28, 2023
bc176a6
update Online_Offline_Microphone_VAD_Demo.ipynb
fayejf Mar 28, 2023
effd2e8
update Online_Offline_Microphone_VAD_Demo.ipynb \n
fayejf Mar 28, 2023
4a4840e
remove 'each'
fayejf Mar 28, 2023
f3fc1a3
Merge branch 'r1.17.0' into mic_notebook
fayejf Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions tutorials/asr/Online_ASR_Microphone_Demo.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
"BRANCH = 'r1.17.0'\n",
"!python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[asr]\n",
"\n",
"## Install TorchAudio\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing it, just comment that it cannot be installed on cuda 12 for the time being

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this notebook does not need torchaudio

"!pip install torchaudio>=0.13.0 -f https://download.pytorch.org/whl/torch_stable.html\n",
"\n",
"## Grab the config we'll use in this example\n",
"!mkdir configs"
]
Expand All @@ -42,8 +39,7 @@
"source": [
"This notebook demonstrates automatic speech recognition (ASR) from a microphone's stream in NeMo.\n",
"\n",
"It is **not a recommended** way to do inference in production workflows. If you are interested in \n",
"production-level inference using NeMo ASR models, please refer to NVIDIA RIVA: https://developer.nvidia.com/riva"
"It is **not a recommended** way to do inference in production workflows. And the incompatibility of components could lead to failure of running this notebook locally with container, we might deprecate this notebook and provide a better tutorial in soon releases. If you are interested in production-level inference using NeMo ASR models, please refer to NVIDIA RIVA: https://developer.nvidia.com/riva"
]
},
{
Expand All @@ -53,24 +49,11 @@
"The notebook requires PyAudio library to get a signal from an audio device.\n",
"For Ubuntu, please run the following commands to install it:\n",
"```\n",
"sudo apt-get install -y portaudio19-dev\n",
"sudo apt install python3-pyaudio\n",
"pip install pyaudio\n",
"```"
]
},
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert, this notebook won't run without Torchaudio

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or add back the instructions to install Torchaudio as below

"cell_type": "markdown",
"metadata": {},
"source": [
"This notebook requires the `torchaudio` library to be installed for MatchboxNet. Please follow the instructions available at the [torchaudio Github page](https://github.com/pytorch/audio#installation) to install the appropriate version of torchaudio.\n",
"\n",
"If you would like to install the latest version, please run the following command to install it:\n",
"\n",
"```\n",
"conda install -c pytorch torchaudio\n",
"```"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down Expand Up @@ -537,4 +520,4 @@
},
"nbformat": 4,
"nbformat_minor": 4
}
}
18 changes: 7 additions & 11 deletions tutorials/asr/Online_Offline_Microphone_VAD_Demo.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@
"This notebook demonstrates how to perform\n",
"1. [offline streaming inference on audio files (offline VAD)](#Offline-streaming-inference);\n",
"2. [finetuning](#Finetune) and use [posterior](#Posterior);\n",
"2. [vad postprocessing and threshold tuning](#VAD-postprocessing-and-Tuning-threshold);\n",
"3. [vad postprocessing and threshold tuning](#VAD-postprocessing-and-Tuning-threshold);\n",
"4. [online streaming inference](#Online-streaming-inference);\n",
"3. [online streaming inference from a microphone's stream](#Online-streaming-inference-through-microphone).\n"
"5. [online streaming inference from a microphone's stream](#Online-streaming-inference-through-microphone).\n",
"\n",
"Note the incompatibility of components could lead to failure of running this notebook locally with container, we might deprecate this notebook and provide a better tutorial in soon releases."
]
},
{
Expand All @@ -55,7 +57,7 @@
"The notebook requires PyAudio library to get a signal from an audio device.\n",
"For Ubuntu, please run the following commands to install it:\n",
"```\n",
"sudo apt-get install -y portaudio19-dev\n",
"sudo apt install python3-pyaudio\n",
"pip install pyaudio\n",
"```"
]
Expand All @@ -64,13 +66,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"This notebook requires the `torchaudio` library to be installed for MarbleNet. Please follow the instructions available at the [torchaudio Github page](https://github.com/pytorch/audio#installation) to install the appropriate version of torchaudio.\n",
"\n",
"If you would like to install the latest version, please run the following command to install it:\n",
"\n",
"```\n",
"conda install -c pytorch torchaudio\n",
"```"
"This notebook requires the `torchaudio` library to be installed for MarbleNet. Please follow the instructions available at the [torchaudio installer](https://github.com/NVIDIA/NeMo/blob/main/scripts/installers/install_torchaudio_latest.sh) and [torchaudio Github page](https://github.com/pytorch/audio#installation) to install the appropriate version of torchaudio.\n"
]
},
{
Expand Down Expand Up @@ -843,4 +839,4 @@
},
"nbformat": 4,
"nbformat_minor": 4
}
}
14 changes: 4 additions & 10 deletions tutorials/asr/Online_Offline_Speech_Commands_Demo.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"This notebook demonstrates offline and online (from a microphone's stream in NeMo) speech commands recognition "
"This notebook demonstrates offline and online (from a microphone's stream in NeMo) speech commands recognition. The incompatibility of components could lead to failure of running this notebook locally with container, we might deprecate this notebook and provide a better tutorial in soon releases."
]
},
{
Expand All @@ -49,7 +49,7 @@
"The notebook requires PyAudio library to get a signal from an audio device.\n",
"For Ubuntu, please run the following commands to install it:\n",
"```\n",
"sudo apt-get install -y portaudio19-dev\n",
"sudo apt install python3-pyaudio\n",
"pip install pyaudio\n",
"```"
]
Expand All @@ -58,13 +58,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"This notebook requires the `torchaudio` library to be installed for MatchboxNet. Please follow the instructions available at the [torchaudio Github page](https://github.com/pytorch/audio#installation) to install the appropriate version of torchaudio.\n",
"\n",
"If you would like to install the latest version, please run the following command to install it:\n",
"\n",
"```\n",
"conda install -c pytorch torchaudio\n",
"```"
"This notebook requires the `torchaudio` library to be installed for MatchboxNet. Please follow the instructions available at the [torchaudio installer](https://github.com/NVIDIA/NeMo/blob/main/scripts/installers/install_torchaudio_latest.sh) and [torchaudio Github page](https://github.com/pytorch/audio#installation) to install the appropriate version of torchaudio.\n"
]
},
{
Expand Down Expand Up @@ -741,4 +735,4 @@
},
"nbformat": 4,
"nbformat_minor": 4
}
}