Avoid unnecessarily accessing data loader with pipeline parallelism #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmoon10
commented
Mar 9, 2023
| for k in batch.keys(): | ||
| batch[k] = batch[k].cuda(non_blocking=True) if k in ['attention_mask'] else None | ||
| # Intermediate pipeline stage doesn't need any inputs | ||
| batch = {k: None for k in ['tokens', 'position_ids', 'attention_mask', 'labels']} |
There was a problem hiding this comment.
I'm uncertain how to handle this case. If we want to keep the same behavior, we need to access the data loader in the case self.get_attention_mask_from_fusion==False so that we can access attention_mask. But that will cause a hang. Do we just require self.get_attention_mask_from_fusion==True to support interleaved pipeline parallelism?
There was a problem hiding this comment.
I'm fine with this. Can you also default get_attention_mask_from_fusion to True in the megatron gpt config and the model?
okuchaiev
requested changes
Mar 20, 2023
Signed-off-by: Tim Moon <[email protected]>
timmoon10
force-pushed
the
interleaved-pipeline-bugfix
branch
2 times, most recently
from
9a012b5
to
ab9aaca
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
…6164) Signed-off-by: Tim Moon <[email protected]>
ericharper
pushed a commit
that referenced
this pull request
Mar 22, 2023
…6164) (#6267) Signed-off-by: Tim Moon <[email protected]> Co-authored-by: Tim Moon <[email protected]>
8 tasks
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
…VIDIA#6164) (NVIDIA#6267) Signed-off-by: Tim Moon <[email protected]> Co-authored-by: Tim Moon <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
I've been experiencing a hang in the first validation step when running GPT with interleaved pipeline parallelism. This first shows up in #6049, so it seems that accessing the data loader in middle pipeline stages is the root cause.
Collection: NLP
Changelog
Usage
No change in usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information