Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to get attention from fusion #6049

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Conversation

ericharper
Copy link
Collaborator

What does this PR do ?

Currently GPT gets the attention_mask from the fused softmax kernel.

If, the kernel isn't used, then the fallback to pytorch softmax breaks.

This PR makes it configurable to get attention_mask from the kernel.

Collection: NLP

Changelog

  • Update forward and loss func

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Contributor

@MaximumEntropy MaximumEntropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @erhoo82 to confirm if you are okay with the default value of the new arg as False.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2023

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Mar 4, 2023
@MaximumEntropy MaximumEntropy self-requested a review March 4, 2023 21:43
@MaximumEntropy MaximumEntropy merged commit 9fe6a8c into main Mar 4, 2023
@MaximumEntropy MaximumEntropy deleted the copy_attention_flag branch March 4, 2023 21:43
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: ericharper <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants