Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to set model in the eval mode during validation with virtual pipelining #6449

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

anmolgupt
Copy link
Contributor

…lining

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Apr 19, 2023
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM. Thanks!

@timmoon10
Copy link
Collaborator

timmoon10 commented Apr 19, 2023

I wonder if this is the cause of the hang we worked around in #6164. Nevermind, that's something related to the data loader.

@ericharper
Copy link
Collaborator

I wonder if this is the cause of the hang we worked around in #6164. Nevermind, that's something related to the data loader.

I had the same thought :D

@ericharper ericharper merged commit be362ef into NVIDIA:r1.17.0_pt_23.04 Apr 19, 2023
github-actions bot pushed a commit that referenced this pull request Apr 19, 2023
anmolgupt added a commit to anmolgupt/NeMo that referenced this pull request May 4, 2023
anmolgupt added a commit to anmolgupt/NeMo that referenced this pull request May 12, 2023
anmolgupt added a commit to anmolgupt/NeMo that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants