Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add table overflow handling #4441

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Docs: Add table overflow handling #4441

merged 1 commit into from
Jun 24, 2022

Conversation

nickolyamba
Copy link
Collaborator

What does this PR do ?

Add table overflow handling. In particular, this caused issues on the Scores page

Collection: None

Changelog

  • Setup section to overflow horizontally
  • Add scrolling to tables placed under section tags

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks !

@titu1994 titu1994 marked this pull request as ready for review June 24, 2022 20:26
@titu1994 titu1994 merged commit 4a520d2 into r1.10.0 Jun 24, 2022
@titu1994 titu1994 deleted the docs-table-css branch June 24, 2022 20:27
ericharper pushed a commit that referenced this pull request Jun 24, 2022
ericharper added a commit that referenced this pull request Jun 27, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* Fix ASR Typos in tutorials (#4384)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383)

Signed-off-by: tbartley94 <[email protected]>

Co-authored-by: tbartley94 <[email protected]>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <[email protected]>

* Punctuation and capitalization tests race condition (#4399)

* Add draft of race condition fixes

Signed-off-by: PeganovAnton <[email protected]>

* Minor improvements

Signed-off-by: PeganovAnton <[email protected]>

* More race condition fixes

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Fix tutorial typos and docs (#4415)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Add reconfigure on validation epoch start (#4393)

* Add reconfigure on validation epoch start

Signed-off-by: MaximumEntropy <[email protected]>

* Style

Signed-off-by: MaximumEntropy <[email protected]>

* Remove pdb

Signed-off-by: MaximumEntropy <[email protected]>

* switch branch (#4424)

Signed-off-by: fayejf <[email protected]>

* Add ASR Scores to Docs (#4412)

* Fix link

Signed-off-by: smajumdar <[email protected]>

* Correct model card

Signed-off-by: smajumdar <[email protected]>

* Add ASR Results to Docs

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Re-apply fixes from r1.9.0 (#4425)

Signed-off-by: Jocelyn Huang <[email protected]>

* Replace all with /content/ (#4427)

Signed-off-by: smajumdar <[email protected]>

* Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (#4405)

* cherry-pick pr 4317 and avoid signoff issue

Signed-off-by: fayejf <[email protected]>

* workaround for mp nb issue

Signed-off-by: fayejf <[email protected]>

* tdqm for mp functions in vad_utils

Signed-off-by: fayejf <[email protected]>

* style fix

Signed-off-by: fayejf <[email protected]>

* reflect comment

Signed-off-by: fayejf <[email protected]>

* remove

Signed-off-by: fayejf <[email protected]>

* [NLP] P&C Fix multi node cache issue, add pynini guard (#4410)

* add sleep to fix multi node cache issue, add pynini guard

Signed-off-by: ekmb <[email protected]>

* fix lgtm

Signed-off-by: ekmb <[email protected]>

* add tempfile

Signed-off-by: ekmb <[email protected]>

* savfe tmp file to the same dir

Signed-off-by: ekmb <[email protected]>

Co-authored-by: PeganovAnton <[email protected]>

* fix the notebook (#4438)

Signed-off-by: Yi Dong <[email protected]>

* update nemo version dialogue tutorial (#4437)

* docs: add table overflow handling for nested sections (#4441)

Co-authored-by: Nick Goncharenko <[email protected]>

* Docs: Decrease Font Size on Tables  (#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <[email protected]>

* unify intent slot dataset util functions in tutorials (#4445)

* Notebook bug fix: add subfolder (#4442)

* add subfolder

Signed-off-by: ekmb <[email protected]>

* exp_dir update

Signed-off-by: ekmb <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Fix typo in HiFi-GAN config's max steps (#4446)

Signed-off-by: Jocelyn Huang <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Updated notebook to fix batch configuration and precision bugs (#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <[email protected]>

* Deleted cell outputs

Signed-off-by: Virginia Adams <[email protected]>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Travis Bartley <[email protected]>
Co-authored-by: PeganovAnton <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: Yi Dong <[email protected]>
Co-authored-by: Zhilin Wang <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Virginia Adams <[email protected]>
ericharper pushed a commit that referenced this pull request Jul 1, 2022
ericharper added a commit that referenced this pull request Jul 1, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* Fix ASR Typos in tutorials (#4384)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383)

Signed-off-by: tbartley94 <[email protected]>

Co-authored-by: tbartley94 <[email protected]>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <[email protected]>

* Fix tutorial typos and docs (#4415)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Add ASR Scores to Docs (#4412)

* Fix link

Signed-off-by: smajumdar <[email protected]>

* Correct model card

Signed-off-by: smajumdar <[email protected]>

* Add ASR Results to Docs

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* docs: add table overflow handling for nested sections (#4441)

Co-authored-by: Nick Goncharenko <[email protected]>

* Docs: Decrease Font Size on Tables  (#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <[email protected]>

* Updated notebook to fix batch configuration and precision bugs (#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <[email protected]>

* Deleted cell outputs

Signed-off-by: Virginia Adams <[email protected]>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* fix branch in link (#4454)

Signed-off-by: ekmb <[email protected]>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <[email protected]>

* add measure units to serial

Signed-off-by: ekmb <[email protected]>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <[email protected]>

* fix test case

Signed-off-by: ekmb <[email protected]>

* update indentation (#4468)

Signed-off-by: Akshit Arora <[email protected]>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* Fix some 's' cases for IPA G2P (#4460)

Signed-off-by: Jocelyn Huang <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Refactor bias act fusion (#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <[email protected]>

* Update NMT config

Signed-off-by: MaximumEntropy <[email protected]>

* Update ci tests

Signed-off-by: MaximumEntropy <[email protected]>

* Empty

Signed-off-by: MaximumEntropy <[email protected]>

* Add kwargs to exact string match (#4479)

Signed-off-by: MaximumEntropy <[email protected]>

* Try fix (#4484)

Signed-off-by: MaximumEntropy <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Travis Bartley <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Virginia Adams <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: Akshit Arora <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
XuesongYang pushed a commit that referenced this pull request Jul 5, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* Fix ASR Typos in tutorials (#4384)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383)

Signed-off-by: tbartley94 <[email protected]>

Co-authored-by: tbartley94 <[email protected]>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <[email protected]>

* Fix tutorial typos and docs (#4415)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Add ASR Scores to Docs (#4412)

* Fix link

Signed-off-by: smajumdar <[email protected]>

* Correct model card

Signed-off-by: smajumdar <[email protected]>

* Add ASR Results to Docs

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* docs: add table overflow handling for nested sections (#4441)

Co-authored-by: Nick Goncharenko <[email protected]>

* Docs: Decrease Font Size on Tables  (#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <[email protected]>

* Updated notebook to fix batch configuration and precision bugs (#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <[email protected]>

* Deleted cell outputs

Signed-off-by: Virginia Adams <[email protected]>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* fix branch in link (#4454)

Signed-off-by: ekmb <[email protected]>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <[email protected]>

* add measure units to serial

Signed-off-by: ekmb <[email protected]>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <[email protected]>

* fix test case

Signed-off-by: ekmb <[email protected]>

* update indentation (#4468)

Signed-off-by: Akshit Arora <[email protected]>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* Fix some 's' cases for IPA G2P (#4460)

Signed-off-by: Jocelyn Huang <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Refactor bias act fusion (#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <[email protected]>

* Update NMT config

Signed-off-by: MaximumEntropy <[email protected]>

* Update ci tests

Signed-off-by: MaximumEntropy <[email protected]>

* Empty

Signed-off-by: MaximumEntropy <[email protected]>

* Add kwargs to exact string match (#4479)

Signed-off-by: MaximumEntropy <[email protected]>

* Try fix (#4484)

Signed-off-by: MaximumEntropy <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Travis Bartley <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Virginia Adams <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: Akshit Arora <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
arendu pushed a commit that referenced this pull request Jul 21, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* Fix ASR Typos in tutorials (#4384)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383)

Signed-off-by: tbartley94 <[email protected]>

Co-authored-by: tbartley94 <[email protected]>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <[email protected]>

* Fix tutorial typos and docs (#4415)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Add ASR Scores to Docs (#4412)

* Fix link

Signed-off-by: smajumdar <[email protected]>

* Correct model card

Signed-off-by: smajumdar <[email protected]>

* Add ASR Results to Docs

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* docs: add table overflow handling for nested sections (#4441)

Co-authored-by: Nick Goncharenko <[email protected]>

* Docs: Decrease Font Size on Tables  (#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <[email protected]>

* Updated notebook to fix batch configuration and precision bugs (#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <[email protected]>

* Deleted cell outputs

Signed-off-by: Virginia Adams <[email protected]>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* fix branch in link (#4454)

Signed-off-by: ekmb <[email protected]>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <[email protected]>

* add measure units to serial

Signed-off-by: ekmb <[email protected]>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <[email protected]>

* fix test case

Signed-off-by: ekmb <[email protected]>

* update indentation (#4468)

Signed-off-by: Akshit Arora <[email protected]>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* Fix some 's' cases for IPA G2P (#4460)

Signed-off-by: Jocelyn Huang <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Refactor bias act fusion (#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <[email protected]>

* Update NMT config

Signed-off-by: MaximumEntropy <[email protected]>

* Update ci tests

Signed-off-by: MaximumEntropy <[email protected]>

* Empty

Signed-off-by: MaximumEntropy <[email protected]>

* Add kwargs to exact string match (#4479)

Signed-off-by: MaximumEntropy <[email protected]>

* Try fix (#4484)

Signed-off-by: MaximumEntropy <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Travis Bartley <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Virginia Adams <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: Akshit Arora <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Signed-off-by: arendu <[email protected]>
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* Fix ASR Typos in tutorials (NVIDIA#4384)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383)

Signed-off-by: tbartley94 <[email protected]>

Co-authored-by: tbartley94 <[email protected]>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <[email protected]>

* Punctuation and capitalization tests race condition (NVIDIA#4399)

* Add draft of race condition fixes

Signed-off-by: PeganovAnton <[email protected]>

* Minor improvements

Signed-off-by: PeganovAnton <[email protected]>

* More race condition fixes

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Fix tutorial typos and docs (NVIDIA#4415)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Add reconfigure on validation epoch start (NVIDIA#4393)

* Add reconfigure on validation epoch start

Signed-off-by: MaximumEntropy <[email protected]>

* Style

Signed-off-by: MaximumEntropy <[email protected]>

* Remove pdb

Signed-off-by: MaximumEntropy <[email protected]>

* switch branch (NVIDIA#4424)

Signed-off-by: fayejf <[email protected]>

* Add ASR Scores to Docs (NVIDIA#4412)

* Fix link

Signed-off-by: smajumdar <[email protected]>

* Correct model card

Signed-off-by: smajumdar <[email protected]>

* Add ASR Results to Docs

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Re-apply fixes from r1.9.0 (NVIDIA#4425)

Signed-off-by: Jocelyn Huang <[email protected]>

* Replace all with /content/ (NVIDIA#4427)

Signed-off-by: smajumdar <[email protected]>

* Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (NVIDIA#4405)

* cherry-pick pr 4317 and avoid signoff issue

Signed-off-by: fayejf <[email protected]>

* workaround for mp nb issue

Signed-off-by: fayejf <[email protected]>

* tdqm for mp functions in vad_utils

Signed-off-by: fayejf <[email protected]>

* style fix

Signed-off-by: fayejf <[email protected]>

* reflect comment

Signed-off-by: fayejf <[email protected]>

* remove

Signed-off-by: fayejf <[email protected]>

* [NLP] P&C Fix multi node cache issue, add pynini guard (NVIDIA#4410)

* add sleep to fix multi node cache issue, add pynini guard

Signed-off-by: ekmb <[email protected]>

* fix lgtm

Signed-off-by: ekmb <[email protected]>

* add tempfile

Signed-off-by: ekmb <[email protected]>

* savfe tmp file to the same dir

Signed-off-by: ekmb <[email protected]>

Co-authored-by: PeganovAnton <[email protected]>

* fix the notebook (NVIDIA#4438)

Signed-off-by: Yi Dong <[email protected]>

* update nemo version dialogue tutorial (NVIDIA#4437)

* docs: add table overflow handling for nested sections (NVIDIA#4441)

Co-authored-by: Nick Goncharenko <[email protected]>

* Docs: Decrease Font Size on Tables  (NVIDIA#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <[email protected]>

* unify intent slot dataset util functions in tutorials (NVIDIA#4445)

* Notebook bug fix: add subfolder (NVIDIA#4442)

* add subfolder

Signed-off-by: ekmb <[email protected]>

* exp_dir update

Signed-off-by: ekmb <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Fix typo in HiFi-GAN config's max steps (NVIDIA#4446)

Signed-off-by: Jocelyn Huang <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <[email protected]>

* Deleted cell outputs

Signed-off-by: Virginia Adams <[email protected]>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Travis Bartley <[email protected]>
Co-authored-by: PeganovAnton <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: Yi Dong <[email protected]>
Co-authored-by: Zhilin Wang <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Virginia Adams <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* Fix ASR Typos in tutorials (NVIDIA#4384)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383)

Signed-off-by: tbartley94 <[email protected]>

Co-authored-by: tbartley94 <[email protected]>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <[email protected]>

* Fix tutorial typos and docs (NVIDIA#4415)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Add ASR Scores to Docs (NVIDIA#4412)

* Fix link

Signed-off-by: smajumdar <[email protected]>

* Correct model card

Signed-off-by: smajumdar <[email protected]>

* Add ASR Results to Docs

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* docs: add table overflow handling for nested sections (NVIDIA#4441)

Co-authored-by: Nick Goncharenko <[email protected]>

* Docs: Decrease Font Size on Tables  (NVIDIA#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <[email protected]>

* Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <[email protected]>

* Deleted cell outputs

Signed-off-by: Virginia Adams <[email protected]>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* fix branch in link (NVIDIA#4454)

Signed-off-by: ekmb <[email protected]>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (NVIDIA#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (NVIDIA#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <[email protected]>

* add measure units to serial

Signed-off-by: ekmb <[email protected]>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <[email protected]>

* fix test case

Signed-off-by: ekmb <[email protected]>

* update indentation (NVIDIA#4468)

Signed-off-by: Akshit Arora <[email protected]>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (NVIDIA#4469)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* Fix some 's' cases for IPA G2P (NVIDIA#4460)

Signed-off-by: Jocelyn Huang <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Refactor bias act fusion (NVIDIA#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <[email protected]>

* Update NMT config

Signed-off-by: MaximumEntropy <[email protected]>

* Update ci tests

Signed-off-by: MaximumEntropy <[email protected]>

* Empty

Signed-off-by: MaximumEntropy <[email protected]>

* Add kwargs to exact string match (NVIDIA#4479)

Signed-off-by: MaximumEntropy <[email protected]>

* Try fix (NVIDIA#4484)

Signed-off-by: MaximumEntropy <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Travis Bartley <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Virginia Adams <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: Akshit Arora <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* Fix ASR Typos in tutorials (NVIDIA#4384)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383)

Signed-off-by: tbartley94 <[email protected]>

Co-authored-by: tbartley94 <[email protected]>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <[email protected]>

* Punctuation and capitalization tests race condition (NVIDIA#4399)

* Add draft of race condition fixes

Signed-off-by: PeganovAnton <[email protected]>

* Minor improvements

Signed-off-by: PeganovAnton <[email protected]>

* More race condition fixes

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Improve error message

Signed-off-by: PeganovAnton <[email protected]>

* Fix tutorial typos and docs (NVIDIA#4415)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Add reconfigure on validation epoch start (NVIDIA#4393)

* Add reconfigure on validation epoch start

Signed-off-by: MaximumEntropy <[email protected]>

* Style

Signed-off-by: MaximumEntropy <[email protected]>

* Remove pdb

Signed-off-by: MaximumEntropy <[email protected]>

* switch branch (NVIDIA#4424)

Signed-off-by: fayejf <[email protected]>

* Add ASR Scores to Docs (NVIDIA#4412)

* Fix link

Signed-off-by: smajumdar <[email protected]>

* Correct model card

Signed-off-by: smajumdar <[email protected]>

* Add ASR Results to Docs

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Re-apply fixes from r1.9.0 (NVIDIA#4425)

Signed-off-by: Jocelyn Huang <[email protected]>

* Replace all with /content/ (NVIDIA#4427)

Signed-off-by: smajumdar <[email protected]>

* Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (NVIDIA#4405)

* cherry-pick pr 4317 and avoid signoff issue

Signed-off-by: fayejf <[email protected]>

* workaround for mp nb issue

Signed-off-by: fayejf <[email protected]>

* tdqm for mp functions in vad_utils

Signed-off-by: fayejf <[email protected]>

* style fix

Signed-off-by: fayejf <[email protected]>

* reflect comment

Signed-off-by: fayejf <[email protected]>

* remove

Signed-off-by: fayejf <[email protected]>

* [NLP] P&C Fix multi node cache issue, add pynini guard (NVIDIA#4410)

* add sleep to fix multi node cache issue, add pynini guard

Signed-off-by: ekmb <[email protected]>

* fix lgtm

Signed-off-by: ekmb <[email protected]>

* add tempfile

Signed-off-by: ekmb <[email protected]>

* savfe tmp file to the same dir

Signed-off-by: ekmb <[email protected]>

Co-authored-by: PeganovAnton <[email protected]>

* fix the notebook (NVIDIA#4438)

Signed-off-by: Yi Dong <[email protected]>

* update nemo version dialogue tutorial (NVIDIA#4437)

* docs: add table overflow handling for nested sections (NVIDIA#4441)

Co-authored-by: Nick Goncharenko <[email protected]>

* Docs: Decrease Font Size on Tables  (NVIDIA#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <[email protected]>

* unify intent slot dataset util functions in tutorials (NVIDIA#4445)

* Notebook bug fix: add subfolder (NVIDIA#4442)

* add subfolder

Signed-off-by: ekmb <[email protected]>

* exp_dir update

Signed-off-by: ekmb <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Fix typo in HiFi-GAN config's max steps (NVIDIA#4446)

Signed-off-by: Jocelyn Huang <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <[email protected]>

* Deleted cell outputs

Signed-off-by: Virginia Adams <[email protected]>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Travis Bartley <[email protected]>
Co-authored-by: PeganovAnton <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: Yi Dong <[email protected]>
Co-authored-by: Zhilin Wang <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Virginia Adams <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* Fix ASR Typos in tutorials (NVIDIA#4384)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383)

Signed-off-by: tbartley94 <[email protected]>

Co-authored-by: tbartley94 <[email protected]>
(cherry picked from commit 0322b15)

Co-authored-by: Travis Bartley <[email protected]>

* Fix tutorial typos and docs (NVIDIA#4415)

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Fix typos

Signed-off-by: smajumdar <[email protected]>

* Add ASR Scores to Docs (NVIDIA#4412)

* Fix link

Signed-off-by: smajumdar <[email protected]>

* Correct model card

Signed-off-by: smajumdar <[email protected]>

* Add ASR Results to Docs

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* Update info

Signed-off-by: smajumdar <[email protected]>

* docs: add table overflow handling for nested sections (NVIDIA#4441)

Co-authored-by: Nick Goncharenko <[email protected]>

* Docs: Decrease Font Size on Tables  (NVIDIA#4444)

* docs: add table overflow handling for nested sections

* docs: set table font-size to small

Co-authored-by: Nick Goncharenko <[email protected]>

* Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447)

* Updated notebook to fix batch configuration and precision bugs

Signed-off-by: Virginia Adams <[email protected]>

* Deleted cell outputs

Signed-off-by: Virginia Adams <[email protected]>

* Set datasets back to full dataset

Signed-off-by: Virginia Adams <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* fix branch in link (NVIDIA#4454)

Signed-off-by: ekmb <[email protected]>

* [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (NVIDIA#4459)

* [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (NVIDIA#4463)

* remove constraints from word graph det

Signed-off-by: ekmb <[email protected]>

* add measure units to serial

Signed-off-by: ekmb <[email protected]>

* revert serial changes, update jenkins path

Signed-off-by: ekmb <[email protected]>

* fix test case

Signed-off-by: ekmb <[email protected]>

* update indentation (NVIDIA#4468)

Signed-off-by: Akshit Arora <[email protected]>

* t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (NVIDIA#4469)

Signed-off-by: Hoo Chang Shin <[email protected]>

Co-authored-by: Hoo Chang Shin <[email protected]>

* Fix some 's' cases for IPA G2P (NVIDIA#4460)

Signed-off-by: Jocelyn Huang <[email protected]>

Co-authored-by: Eric Harper <[email protected]>

* Refactor bias act fusion (NVIDIA#4376)

* Refactor bias act fusion

Signed-off-by: MaximumEntropy <[email protected]>

* Update NMT config

Signed-off-by: MaximumEntropy <[email protected]>

* Update ci tests

Signed-off-by: MaximumEntropy <[email protected]>

* Empty

Signed-off-by: MaximumEntropy <[email protected]>

* Add kwargs to exact string match (NVIDIA#4479)

Signed-off-by: MaximumEntropy <[email protected]>

* Try fix (NVIDIA#4484)

Signed-off-by: MaximumEntropy <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Travis Bartley <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Nick Goncharenko <[email protected]>
Co-authored-by: Virginia Adams <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: Akshit Arora <[email protected]>
Co-authored-by: khcs <[email protected]>
Co-authored-by: Hoo Chang Shin <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants