-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NLP] P&C Fix multi node cache issue, add pynini guard #4410
Conversation
Signed-off-by: ekmb <[email protected]>
This pull request introduces 1 alert and fixes 1 when merging 9a531f8 into 5846696 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: ekmb <[email protected]>
This pull request fixes 1 alert when merging 53a0501 into 5846696 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging f603901 into 5846696 - view on LGTM.com fixed alerts:
|
nemo/collections/nlp/data/token_classification/punctuation_capitalization_dataset.py
Show resolved
Hide resolved
Signed-off-by: ekmb <[email protected]>
This pull request fixes 1 alert when merging 41cbaa7 into 3370680 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging e73f0a4 into ba57ea9 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging edfe282 into fc13bda - view on LGTM.com fixed alerts:
|
* add sleep to fix multi node cache issue, add pynini guard Signed-off-by: ekmb <[email protected]> * fix lgtm Signed-off-by: ekmb <[email protected]> * add tempfile Signed-off-by: ekmb <[email protected]> * savfe tmp file to the same dir Signed-off-by: ekmb <[email protected]> Co-authored-by: PeganovAnton <[email protected]>
* update branch Signed-off-by: ericharper <[email protected]> * Fix ASR Typos in tutorials (#4384) * Fix typos Signed-off-by: smajumdar <[email protected]> * Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383) Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> (cherry picked from commit 0322b15) Co-authored-by: Travis Bartley <[email protected]> * Punctuation and capitalization tests race condition (#4399) * Add draft of race condition fixes Signed-off-by: PeganovAnton <[email protected]> * Minor improvements Signed-off-by: PeganovAnton <[email protected]> * More race condition fixes Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Fix tutorial typos and docs (#4415) * Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]> * Add reconfigure on validation epoch start (#4393) * Add reconfigure on validation epoch start Signed-off-by: MaximumEntropy <[email protected]> * Style Signed-off-by: MaximumEntropy <[email protected]> * Remove pdb Signed-off-by: MaximumEntropy <[email protected]> * switch branch (#4424) Signed-off-by: fayejf <[email protected]> * Add ASR Scores to Docs (#4412) * Fix link Signed-off-by: smajumdar <[email protected]> * Correct model card Signed-off-by: smajumdar <[email protected]> * Add ASR Results to Docs Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Re-apply fixes from r1.9.0 (#4425) Signed-off-by: Jocelyn Huang <[email protected]> * Replace all with /content/ (#4427) Signed-off-by: smajumdar <[email protected]> * Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (#4405) * cherry-pick pr 4317 and avoid signoff issue Signed-off-by: fayejf <[email protected]> * workaround for mp nb issue Signed-off-by: fayejf <[email protected]> * tdqm for mp functions in vad_utils Signed-off-by: fayejf <[email protected]> * style fix Signed-off-by: fayejf <[email protected]> * reflect comment Signed-off-by: fayejf <[email protected]> * remove Signed-off-by: fayejf <[email protected]> * [NLP] P&C Fix multi node cache issue, add pynini guard (#4410) * add sleep to fix multi node cache issue, add pynini guard Signed-off-by: ekmb <[email protected]> * fix lgtm Signed-off-by: ekmb <[email protected]> * add tempfile Signed-off-by: ekmb <[email protected]> * savfe tmp file to the same dir Signed-off-by: ekmb <[email protected]> Co-authored-by: PeganovAnton <[email protected]> * fix the notebook (#4438) Signed-off-by: Yi Dong <[email protected]> * update nemo version dialogue tutorial (#4437) * docs: add table overflow handling for nested sections (#4441) Co-authored-by: Nick Goncharenko <[email protected]> * Docs: Decrease Font Size on Tables (#4444) * docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]> * unify intent slot dataset util functions in tutorials (#4445) * Notebook bug fix: add subfolder (#4442) * add subfolder Signed-off-by: ekmb <[email protected]> * exp_dir update Signed-off-by: ekmb <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Fix typo in HiFi-GAN config's max steps (#4446) Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Updated notebook to fix batch configuration and precision bugs (#4447) * Updated notebook to fix batch configuration and precision bugs Signed-off-by: Virginia Adams <[email protected]> * Deleted cell outputs Signed-off-by: Virginia Adams <[email protected]> * Set datasets back to full dataset Signed-off-by: Virginia Adams <[email protected]> Co-authored-by: Eric Harper <[email protected]> * update branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Travis Bartley <[email protected]> Co-authored-by: PeganovAnton <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: fayejf <[email protected]> Co-authored-by: Jocelyn <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Yi Dong <[email protected]> Co-authored-by: Zhilin Wang <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Virginia Adams <[email protected]>
* update branch Signed-off-by: ericharper <[email protected]> * Fix ASR Typos in tutorials (NVIDIA#4384) * Fix typos Signed-off-by: smajumdar <[email protected]> * Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383) Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> (cherry picked from commit 0322b15) Co-authored-by: Travis Bartley <[email protected]> * Punctuation and capitalization tests race condition (NVIDIA#4399) * Add draft of race condition fixes Signed-off-by: PeganovAnton <[email protected]> * Minor improvements Signed-off-by: PeganovAnton <[email protected]> * More race condition fixes Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Fix tutorial typos and docs (NVIDIA#4415) * Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]> * Add reconfigure on validation epoch start (NVIDIA#4393) * Add reconfigure on validation epoch start Signed-off-by: MaximumEntropy <[email protected]> * Style Signed-off-by: MaximumEntropy <[email protected]> * Remove pdb Signed-off-by: MaximumEntropy <[email protected]> * switch branch (NVIDIA#4424) Signed-off-by: fayejf <[email protected]> * Add ASR Scores to Docs (NVIDIA#4412) * Fix link Signed-off-by: smajumdar <[email protected]> * Correct model card Signed-off-by: smajumdar <[email protected]> * Add ASR Results to Docs Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Re-apply fixes from r1.9.0 (NVIDIA#4425) Signed-off-by: Jocelyn Huang <[email protected]> * Replace all with /content/ (NVIDIA#4427) Signed-off-by: smajumdar <[email protected]> * Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (NVIDIA#4405) * cherry-pick pr 4317 and avoid signoff issue Signed-off-by: fayejf <[email protected]> * workaround for mp nb issue Signed-off-by: fayejf <[email protected]> * tdqm for mp functions in vad_utils Signed-off-by: fayejf <[email protected]> * style fix Signed-off-by: fayejf <[email protected]> * reflect comment Signed-off-by: fayejf <[email protected]> * remove Signed-off-by: fayejf <[email protected]> * [NLP] P&C Fix multi node cache issue, add pynini guard (NVIDIA#4410) * add sleep to fix multi node cache issue, add pynini guard Signed-off-by: ekmb <[email protected]> * fix lgtm Signed-off-by: ekmb <[email protected]> * add tempfile Signed-off-by: ekmb <[email protected]> * savfe tmp file to the same dir Signed-off-by: ekmb <[email protected]> Co-authored-by: PeganovAnton <[email protected]> * fix the notebook (NVIDIA#4438) Signed-off-by: Yi Dong <[email protected]> * update nemo version dialogue tutorial (NVIDIA#4437) * docs: add table overflow handling for nested sections (NVIDIA#4441) Co-authored-by: Nick Goncharenko <[email protected]> * Docs: Decrease Font Size on Tables (NVIDIA#4444) * docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]> * unify intent slot dataset util functions in tutorials (NVIDIA#4445) * Notebook bug fix: add subfolder (NVIDIA#4442) * add subfolder Signed-off-by: ekmb <[email protected]> * exp_dir update Signed-off-by: ekmb <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Fix typo in HiFi-GAN config's max steps (NVIDIA#4446) Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447) * Updated notebook to fix batch configuration and precision bugs Signed-off-by: Virginia Adams <[email protected]> * Deleted cell outputs Signed-off-by: Virginia Adams <[email protected]> * Set datasets back to full dataset Signed-off-by: Virginia Adams <[email protected]> Co-authored-by: Eric Harper <[email protected]> * update branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Travis Bartley <[email protected]> Co-authored-by: PeganovAnton <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: fayejf <[email protected]> Co-authored-by: Jocelyn <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Yi Dong <[email protected]> Co-authored-by: Zhilin Wang <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Virginia Adams <[email protected]> Signed-off-by: David Mosallanezhad <[email protected]>
* update branch Signed-off-by: ericharper <[email protected]> * Fix ASR Typos in tutorials (NVIDIA#4384) * Fix typos Signed-off-by: smajumdar <[email protected]> * Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383) Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> (cherry picked from commit 0322b15) Co-authored-by: Travis Bartley <[email protected]> * Punctuation and capitalization tests race condition (NVIDIA#4399) * Add draft of race condition fixes Signed-off-by: PeganovAnton <[email protected]> * Minor improvements Signed-off-by: PeganovAnton <[email protected]> * More race condition fixes Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Improve error message Signed-off-by: PeganovAnton <[email protected]> * Fix tutorial typos and docs (NVIDIA#4415) * Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]> * Add reconfigure on validation epoch start (NVIDIA#4393) * Add reconfigure on validation epoch start Signed-off-by: MaximumEntropy <[email protected]> * Style Signed-off-by: MaximumEntropy <[email protected]> * Remove pdb Signed-off-by: MaximumEntropy <[email protected]> * switch branch (NVIDIA#4424) Signed-off-by: fayejf <[email protected]> * Add ASR Scores to Docs (NVIDIA#4412) * Fix link Signed-off-by: smajumdar <[email protected]> * Correct model card Signed-off-by: smajumdar <[email protected]> * Add ASR Results to Docs Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Re-apply fixes from r1.9.0 (NVIDIA#4425) Signed-off-by: Jocelyn Huang <[email protected]> * Replace all with /content/ (NVIDIA#4427) Signed-off-by: smajumdar <[email protected]> * Fix hanging issue by multiprocessing in SD tutorial and add ETA for VAD processing (NVIDIA#4405) * cherry-pick pr 4317 and avoid signoff issue Signed-off-by: fayejf <[email protected]> * workaround for mp nb issue Signed-off-by: fayejf <[email protected]> * tdqm for mp functions in vad_utils Signed-off-by: fayejf <[email protected]> * style fix Signed-off-by: fayejf <[email protected]> * reflect comment Signed-off-by: fayejf <[email protected]> * remove Signed-off-by: fayejf <[email protected]> * [NLP] P&C Fix multi node cache issue, add pynini guard (NVIDIA#4410) * add sleep to fix multi node cache issue, add pynini guard Signed-off-by: ekmb <[email protected]> * fix lgtm Signed-off-by: ekmb <[email protected]> * add tempfile Signed-off-by: ekmb <[email protected]> * savfe tmp file to the same dir Signed-off-by: ekmb <[email protected]> Co-authored-by: PeganovAnton <[email protected]> * fix the notebook (NVIDIA#4438) Signed-off-by: Yi Dong <[email protected]> * update nemo version dialogue tutorial (NVIDIA#4437) * docs: add table overflow handling for nested sections (NVIDIA#4441) Co-authored-by: Nick Goncharenko <[email protected]> * Docs: Decrease Font Size on Tables (NVIDIA#4444) * docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]> * unify intent slot dataset util functions in tutorials (NVIDIA#4445) * Notebook bug fix: add subfolder (NVIDIA#4442) * add subfolder Signed-off-by: ekmb <[email protected]> * exp_dir update Signed-off-by: ekmb <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Fix typo in HiFi-GAN config's max steps (NVIDIA#4446) Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447) * Updated notebook to fix batch configuration and precision bugs Signed-off-by: Virginia Adams <[email protected]> * Deleted cell outputs Signed-off-by: Virginia Adams <[email protected]> * Set datasets back to full dataset Signed-off-by: Virginia Adams <[email protected]> Co-authored-by: Eric Harper <[email protected]> * update branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Travis Bartley <[email protected]> Co-authored-by: PeganovAnton <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: fayejf <[email protected]> Co-authored-by: Jocelyn <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Yi Dong <[email protected]> Co-authored-by: Zhilin Wang <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Virginia Adams <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Signed-off-by: ekmb [email protected]
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information