Merge r1.10.0 main #4486

ericharper · 2022-07-01T18:49:03Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: ericharper <[email protected]>

* Fix typos Signed-off-by: smajumdar <[email protected]> * Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383) Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> (cherry picked from commit 0322b15) Co-authored-by: Travis Bartley <[email protected]>

* Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]>

* Fix link Signed-off-by: smajumdar <[email protected]> * Correct model card Signed-off-by: smajumdar <[email protected]> * Add ASR Results to Docs Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]>

Co-authored-by: Nick Goncharenko <[email protected]>

* docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]>

* Updated notebook to fix batch configuration and precision bugs Signed-off-by: Virginia Adams <[email protected]> * Deleted cell outputs Signed-off-by: Virginia Adams <[email protected]> * Set datasets back to full dataset Signed-off-by: Virginia Adams <[email protected]> Co-authored-by: Eric Harper <[email protected]>

Signed-off-by: ekmb <[email protected]>

…aints from word graph (#4463) * remove constraints from word graph det Signed-off-by: ekmb <[email protected]> * add measure units to serial Signed-off-by: ekmb <[email protected]> * revert serial changes, update jenkins path Signed-off-by: ekmb <[email protected]> * fix test case Signed-off-by: ekmb <[email protected]>

Signed-off-by: Akshit Arora <[email protected]>

Signed-off-by: Hoo Chang Shin <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]>

Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]>

* Refactor bias act fusion Signed-off-by: MaximumEntropy <[email protected]> * Update NMT config Signed-off-by: MaximumEntropy <[email protected]> * Update ci tests Signed-off-by: MaximumEntropy <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]>

Signed-off-by: MaximumEntropy <[email protected]>

Signed-off-by: ericharper <[email protected]>

titu1994

Looks great!

titu1994 · 2022-07-01T18:50:43Z

Jenkinsfile

@@ -3040,7 +3040,7 @@ pipeline {
        model.hidden_size=64 \
        model.num_attention_heads=8 \
        model.activation='swiglu' \
-        model.bias_gelu_fusion=False \
+        model.bias_activation_fusion=False \


I assume this isn't backward compatible change, try to reduce such breaking changes if possible.

lgtm-com · 2022-07-01T18:59:40Z

This pull request fixes 1 alert when merging 52501f0 into 23f6a95 - view on LGTM.com

fixed alerts:

1 for Unused local variable

* update branch Signed-off-by: ericharper <[email protected]> * Fix ASR Typos in tutorials (#4384) * Fix typos Signed-off-by: smajumdar <[email protected]> * Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383) Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> (cherry picked from commit 0322b15) Co-authored-by: Travis Bartley <[email protected]> * Fix tutorial typos and docs (#4415) * Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]> * Add ASR Scores to Docs (#4412) * Fix link Signed-off-by: smajumdar <[email protected]> * Correct model card Signed-off-by: smajumdar <[email protected]> * Add ASR Results to Docs Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * docs: add table overflow handling for nested sections (#4441) Co-authored-by: Nick Goncharenko <[email protected]> * Docs: Decrease Font Size on Tables (#4444) * docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]> * Updated notebook to fix batch configuration and precision bugs (#4447) * Updated notebook to fix batch configuration and precision bugs Signed-off-by: Virginia Adams <[email protected]> * Deleted cell outputs Signed-off-by: Virginia Adams <[email protected]> * Set datasets back to full dataset Signed-off-by: Virginia Adams <[email protected]> Co-authored-by: Eric Harper <[email protected]> * fix branch in link (#4454) Signed-off-by: ekmb <[email protected]> * [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459) * [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (#4463) * remove constraints from word graph det Signed-off-by: ekmb <[email protected]> * add measure units to serial Signed-off-by: ekmb <[email protected]> * revert serial changes, update jenkins path Signed-off-by: ekmb <[email protected]> * fix test case Signed-off-by: ekmb <[email protected]> * update indentation (#4468) Signed-off-by: Akshit Arora <[email protected]> * t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469) Signed-off-by: Hoo Chang Shin <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]> * Fix some 's' cases for IPA G2P (#4460) Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Refactor bias act fusion (#4376) * Refactor bias act fusion Signed-off-by: MaximumEntropy <[email protected]> * Update NMT config Signed-off-by: MaximumEntropy <[email protected]> * Update ci tests Signed-off-by: MaximumEntropy <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]> * Add kwargs to exact string match (#4479) Signed-off-by: MaximumEntropy <[email protected]> * Try fix (#4484) Signed-off-by: MaximumEntropy <[email protected]> * update branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Travis Bartley <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Virginia Adams <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Akshit Arora <[email protected]> Co-authored-by: khcs <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]> Co-authored-by: Jocelyn <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]>

* update branch Signed-off-by: ericharper <[email protected]> * Fix ASR Typos in tutorials (#4384) * Fix typos Signed-off-by: smajumdar <[email protected]> * Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (#4383) Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> (cherry picked from commit 0322b15) Co-authored-by: Travis Bartley <[email protected]> * Fix tutorial typos and docs (#4415) * Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]> * Add ASR Scores to Docs (#4412) * Fix link Signed-off-by: smajumdar <[email protected]> * Correct model card Signed-off-by: smajumdar <[email protected]> * Add ASR Results to Docs Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * docs: add table overflow handling for nested sections (#4441) Co-authored-by: Nick Goncharenko <[email protected]> * Docs: Decrease Font Size on Tables (#4444) * docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]> * Updated notebook to fix batch configuration and precision bugs (#4447) * Updated notebook to fix batch configuration and precision bugs Signed-off-by: Virginia Adams <[email protected]> * Deleted cell outputs Signed-off-by: Virginia Adams <[email protected]> * Set datasets back to full dataset Signed-off-by: Virginia Adams <[email protected]> Co-authored-by: Eric Harper <[email protected]> * fix branch in link (#4454) Signed-off-by: ekmb <[email protected]> * [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459) * [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (#4463) * remove constraints from word graph det Signed-off-by: ekmb <[email protected]> * add measure units to serial Signed-off-by: ekmb <[email protected]> * revert serial changes, update jenkins path Signed-off-by: ekmb <[email protected]> * fix test case Signed-off-by: ekmb <[email protected]> * update indentation (#4468) Signed-off-by: Akshit Arora <[email protected]> * t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469) Signed-off-by: Hoo Chang Shin <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]> * Fix some 's' cases for IPA G2P (#4460) Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Refactor bias act fusion (#4376) * Refactor bias act fusion Signed-off-by: MaximumEntropy <[email protected]> * Update NMT config Signed-off-by: MaximumEntropy <[email protected]> * Update ci tests Signed-off-by: MaximumEntropy <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]> * Add kwargs to exact string match (#4479) Signed-off-by: MaximumEntropy <[email protected]> * Try fix (#4484) Signed-off-by: MaximumEntropy <[email protected]> * update branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Travis Bartley <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Virginia Adams <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Akshit Arora <[email protected]> Co-authored-by: khcs <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]> Co-authored-by: Jocelyn <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Signed-off-by: arendu <[email protected]>

* update branch Signed-off-by: ericharper <[email protected]> * Fix ASR Typos in tutorials (NVIDIA#4384) * Fix typos Signed-off-by: smajumdar <[email protected]> * Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383) Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> (cherry picked from commit 0322b15) Co-authored-by: Travis Bartley <[email protected]> * Fix tutorial typos and docs (NVIDIA#4415) * Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]> * Add ASR Scores to Docs (NVIDIA#4412) * Fix link Signed-off-by: smajumdar <[email protected]> * Correct model card Signed-off-by: smajumdar <[email protected]> * Add ASR Results to Docs Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * docs: add table overflow handling for nested sections (NVIDIA#4441) Co-authored-by: Nick Goncharenko <[email protected]> * Docs: Decrease Font Size on Tables (NVIDIA#4444) * docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]> * Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447) * Updated notebook to fix batch configuration and precision bugs Signed-off-by: Virginia Adams <[email protected]> * Deleted cell outputs Signed-off-by: Virginia Adams <[email protected]> * Set datasets back to full dataset Signed-off-by: Virginia Adams <[email protected]> Co-authored-by: Eric Harper <[email protected]> * fix branch in link (NVIDIA#4454) Signed-off-by: ekmb <[email protected]> * [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (NVIDIA#4459) * [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (NVIDIA#4463) * remove constraints from word graph det Signed-off-by: ekmb <[email protected]> * add measure units to serial Signed-off-by: ekmb <[email protected]> * revert serial changes, update jenkins path Signed-off-by: ekmb <[email protected]> * fix test case Signed-off-by: ekmb <[email protected]> * update indentation (NVIDIA#4468) Signed-off-by: Akshit Arora <[email protected]> * t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (NVIDIA#4469) Signed-off-by: Hoo Chang Shin <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]> * Fix some 's' cases for IPA G2P (NVIDIA#4460) Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Refactor bias act fusion (NVIDIA#4376) * Refactor bias act fusion Signed-off-by: MaximumEntropy <[email protected]> * Update NMT config Signed-off-by: MaximumEntropy <[email protected]> * Update ci tests Signed-off-by: MaximumEntropy <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]> * Add kwargs to exact string match (NVIDIA#4479) Signed-off-by: MaximumEntropy <[email protected]> * Try fix (NVIDIA#4484) Signed-off-by: MaximumEntropy <[email protected]> * update branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Travis Bartley <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Virginia Adams <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Akshit Arora <[email protected]> Co-authored-by: khcs <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]> Co-authored-by: Jocelyn <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Signed-off-by: David Mosallanezhad <[email protected]>

* update branch Signed-off-by: ericharper <[email protected]> * Fix ASR Typos in tutorials (NVIDIA#4384) * Fix typos Signed-off-by: smajumdar <[email protected]> * Quick wav2vec fix. In-place operation adding convolutional positions to encoder was overwriting leaf history. Wasn't caught on previous torch versions. (NVIDIA#4383) Signed-off-by: tbartley94 <[email protected]> Co-authored-by: tbartley94 <[email protected]> (cherry picked from commit 0322b15) Co-authored-by: Travis Bartley <[email protected]> * Fix tutorial typos and docs (NVIDIA#4415) * Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]> * Add ASR Scores to Docs (NVIDIA#4412) * Fix link Signed-off-by: smajumdar <[email protected]> * Correct model card Signed-off-by: smajumdar <[email protected]> * Add ASR Results to Docs Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * Update info Signed-off-by: smajumdar <[email protected]> * docs: add table overflow handling for nested sections (NVIDIA#4441) Co-authored-by: Nick Goncharenko <[email protected]> * Docs: Decrease Font Size on Tables (NVIDIA#4444) * docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]> * Updated notebook to fix batch configuration and precision bugs (NVIDIA#4447) * Updated notebook to fix batch configuration and precision bugs Signed-off-by: Virginia Adams <[email protected]> * Deleted cell outputs Signed-off-by: Virginia Adams <[email protected]> * Set datasets back to full dataset Signed-off-by: Virginia Adams <[email protected]> Co-authored-by: Eric Harper <[email protected]> * fix branch in link (NVIDIA#4454) Signed-off-by: ekmb <[email protected]> * [TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (NVIDIA#4459) * [TN] Bug fix: expand serial coverage of unknown symbol, remove constraints from word graph (NVIDIA#4463) * remove constraints from word graph det Signed-off-by: ekmb <[email protected]> * add measure units to serial Signed-off-by: ekmb <[email protected]> * revert serial changes, update jenkins path Signed-off-by: ekmb <[email protected]> * fix test case Signed-off-by: ekmb <[email protected]> * update indentation (NVIDIA#4468) Signed-off-by: Akshit Arora <[email protected]> * t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (NVIDIA#4469) Signed-off-by: Hoo Chang Shin <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]> * Fix some 's' cases for IPA G2P (NVIDIA#4460) Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Refactor bias act fusion (NVIDIA#4376) * Refactor bias act fusion Signed-off-by: MaximumEntropy <[email protected]> * Update NMT config Signed-off-by: MaximumEntropy <[email protected]> * Update ci tests Signed-off-by: MaximumEntropy <[email protected]> * Empty Signed-off-by: MaximumEntropy <[email protected]> * Add kwargs to exact string match (NVIDIA#4479) Signed-off-by: MaximumEntropy <[email protected]> * Try fix (NVIDIA#4484) Signed-off-by: MaximumEntropy <[email protected]> * update branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Travis Bartley <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Nick Goncharenko <[email protected]> Co-authored-by: Virginia Adams <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Akshit Arora <[email protected]> Co-authored-by: khcs <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]> Co-authored-by: Jocelyn <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Signed-off-by: Hainan Xu <[email protected]>

ericharper and others added 17 commits July 1, 2022 12:44

update branch

aabab37

Signed-off-by: ericharper <[email protected]>

Fix tutorial typos and docs (#4415)

27e61e5

* Fix typos Signed-off-by: smajumdar <[email protected]> * Fix typos Signed-off-by: smajumdar <[email protected]>

docs: add table overflow handling for nested sections (#4441)

c513a5f

Co-authored-by: Nick Goncharenko <[email protected]>

Docs: Decrease Font Size on Tables (#4444)

e7fd300

* docs: add table overflow handling for nested sections * docs: set table font-size to small Co-authored-by: Nick Goncharenko <[email protected]>

fix branch in link (#4454)

c61a9b7

Signed-off-by: ekmb <[email protected]>

[TTS] [bugfix] German FastPitch HiFi-GAN tutorial and lr (#4459)

aebc8db

update indentation (#4468)

52beceb

Signed-off-by: Akshit Arora <[email protected]>

t5-rpe-fix targeting r1.10.0; raise exception for PP>2. (#4469)

1d4854b

Signed-off-by: Hoo Chang Shin <[email protected]> Co-authored-by: Hoo Chang Shin <[email protected]>

Fix some 's' cases for IPA G2P (#4460)

06e958a

Signed-off-by: Jocelyn Huang <[email protected]> Co-authored-by: Eric Harper <[email protected]>

Add kwargs to exact string match (#4479)

e27e5a0

Signed-off-by: MaximumEntropy <[email protected]>

Try fix (#4484)

d2e69de

Signed-off-by: MaximumEntropy <[email protected]>

update branch

52501f0

Signed-off-by: ericharper <[email protected]>

ericharper requested a review from titu1994 July 1, 2022 18:49

titu1994 approved these changes Jul 1, 2022

View reviewed changes

ericharper merged commit 8a172df into main Jul 1, 2022

ericharper deleted the merge_r1.10.0_main branch July 1, 2022 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge r1.10.0 main #4486

Merge r1.10.0 main #4486

ericharper commented Jul 1, 2022

titu1994 left a comment

titu1994 Jul 1, 2022

lgtm-com bot commented Jul 1, 2022

Merge r1.10.0 main #4486

Merge r1.10.0 main #4486

Conversation

ericharper commented Jul 1, 2022

What does this PR do ?

Changelog

Usage

Before your PR is "Ready for review"

Who can review?

Additional Information

titu1994 left a comment

Choose a reason for hiding this comment

titu1994 Jul 1, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Jul 1, 2022