chore: nightly sync main into dev (20_05_2026) - #4900
Closed
svcnvidia-nemo-ci wants to merge 72 commits into
Closed
Conversation
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
…al tests` (#4730) Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com> Co-authored-by: Cory Ye <44509866+cspades@users.noreply.github.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com>
Signed-off-by: Ajay Balasa <abalasa@nvidia.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Tuomas Rintamaki <trintamaki@nvidia.com> Co-authored-by: Tyler Poon <tylerpoon@gmail.com> Co-authored-by: Collin McCarthy <cmccarthy@nvidia.com> Co-authored-by: Matthieu Le <matthieul@nvidia.com> Co-authored-by: Piotr Zelasko <pzelasko@nvidia.com> Co-authored-by: Ehsan Hosseini Asl <ehosseiniasl@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
…parallel_size * expert_tensor_parallel_size (#4678) Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Co-authored-by: Jorge Albericio <jalbericiola@nvidia.com>
#4509) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
#4492) Signed-off-by: Xiaowei Ren <xren@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
…parallelism correctly (#4687)
svcnvidia-nemo-ci
force-pushed
the
main2dev/20_05_2026
branch
from
May 21, 2026 05:03
2a43665 to
e2bb47c
Compare
Contributor
Author
|
/ok to test e2bb47c |
Member
|
/ok to test 66191ac |
Member
|
/ok to test a921dff |
Signed-off-by: Deyu Fu <deyuf@nvidia.com>
Contributor
|
/ok to test cc2a48b |
FDecaYed
requested changes
May 27, 2026
FDecaYed
left a comment
Contributor
There was a problem hiding this comment.
2 UT still failing. One seems nccl error that might be machine or CI related, does not seem due to the merge. The other I seems due to code accidentally dropped during merge, which I added back and merge with tot. Launching UT again now
Contributor
Author
|
Superseded by today's nightly sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly sync of
mainintodev. Brings in 65 commits frommainsince the last sync.Python-only line stats: +14649 / -3066 across 185 files.
Files where main's version was taken (in addition to skill list)
The dev-feature audit's strict line-by-line comparison flagged a number of files where
mainintentionally rewrote the code that dev's older versions had. Each was verified by tracing back to a specific main-only commit:examples/post_training/modelopt/*.py,*.md,*.sh,megatron/post_training/*.py14aaa7e0eModernize post-training modelopt example scripts (#4807)megatron/core/resharding/**,tests/unit_tests/resharding/test_planner.py20bf831darefit clean up and refactoring (#4762)megatron/core/transformer/moe/experts.py,megatron/core/transformer/moe/moe_layer.py,megatron/core/transformer/transformer_layer.py6815c0fefCombine GEMM + SwiGLU fused MLP PRs (#4636)megatron/core/transformer/transformer_block.py,megatron/training/arguments.py, plus introduction ofmegatron/core/recompute.pye41b37002Refactor CUDA graph API (#4292)tests/test_utils/python_scripts/compare_golden_values_kl.py,skills/update-golden-values/SKILL.mdf744215afAdd bump-base-image skill and update golden value comparison (#4733)megatron/core/models/vision/radio.py,megatron/core/models/multimodal/llava_model.py6853b4793Add LLaVA audio (sound) model support (#4402)tests/unit_tests/dist_checkpointing/test_pipeline_parallel_layout.pyand MSC default flip inarguments.py95bba946cDisable MSC by default; opt in via --enable-msc (#4629)tests/unit_tests/test_layer_wise_optimizer.py,megatron/core/optimizer/__init__.py(model_chunks=...conditional)c1e938b03Integrate LayerWiseDistributedOptimizer with DDP buffer infrastructure (#4509)tests/unit_tests/training/config/test_container_base.py0dc36dfc6[training migration] Migrate mamba builder (#4550)megatron/training/training.py,initialize.py,utils.py,datasets/data_samplers.py,megatron/core/optimizer/layer_wise_optimizer.pyDev-only additions preserved across the merge
TEFusedDenseMLPclass inmegatron/core/extensions/transformer_engine.py(plus thedense_grouped_gemmselection wiring ingpt_layer_specs.py)._maybe_record_overload_factor(...)invocation inmoe_layer.py.enable_hyper_connections,num_residual_streams,mhc_*,use_fused_mhc) andHyperConnectionTransformerLayerreferences intransformer_config.py/transformer_layer.py.paged_stash_*imports andstash_contextwrapping insideTEGroupedMLP._fused_forward.LinearCrossEntropyModuleandpaged_stash_init_chunk_handlerimports ingpt_model.py.mhc_multistream,mhc_enabledpaths inmulti_token_prediction.py(combined with main'sInferenceMode.is_active()andpadding_maskplumbing).cp_groupswap inMTPBlock.forwarddriven bypacked_seq_params.cp_group.input_idsplumbing through MoE forward stack (router.py,moe_layer.py,transformer_layer.py, and the recompute path via a newinput_idskwarg added tomegatron/core/recompute.py:checkpointed_forward).--inference-dynamic-batching-cuda-graph-max-tokensand--cuda-graph-impl=full_iterationingpt_dynamic_inference_..._zmqtest config.moe_routeradded tocuda_graph_modulesinnemotron3_super_release_gb200.gpt3_mcore_te_tp2_pp2_mhctest case alongside main's newgpt3_mcore_te_tp2_pp1_gdn_no_nvrx_*cases intests/test_utils/recipes/h100/gpt.yaml.Files restored / handled specially
megatron/training/checkpointing.py: dropped dev'sexcept ModuleNotFoundErrorlegacy fallback becausemegatron/legacy/fp16_deprecated/loss_scaler.pywas intentionally deleted on main (10b514bf5"fully remove legacy code (fully remove legacy code #4759)").pyproject.toml,uv.lock,docker/Dockerfile.ci.dev, and.github/CODEOWNERSverbatim per skill convention.API mismatches resolved
attention.py/multi_latent_attention.py: kept dev'sattn_proj_manager.group_offload(...)API (the merged tree'sFineGrainedActivationOffloadingInterfaceexposesgroup_offload, not main'sgroup_commit).gated_delta_net.py: took main's_resolve_cu_seqlens(..., cp_size=...)signature including the divisibility check, since callers now passcp_size=self.cp_size.transformer_layer.py: switched to main'sas_mlp_submodule/submodules.mlp(...)construction pattern; kept dev's**moe_kwargs(includinginput_ids) plumbing.gpt_layer_specs.pyget_mlp_module_spec_for_backend: combined dev'sdense_grouped_gemmselection with main'sas_mlp_submoduleclassmethod dispatch andMlpBuilderreturn type.How this diff was produced
Conflict resolution followed the nightly-sync skill: started from
origin/dev, rangit merge origin/main --no-edit, resolved 47 conflicting paths surgically (preserving dev-only features unless I could identify a specific main commit removing them), ranblack+isortover the 185 changed Python files, regenerated nothing inuv.lock, and audited with the pre-push hook before pushing.🤖 Generated with Claude Code