chore: nightly sync main into dev (18_05_2026) - #4857
Closed
svcnvidia-nemo-ci wants to merge 59 commits into
Closed
Conversation
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
…al tests` (#4730) Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com> Co-authored-by: Cory Ye <44509866+cspades@users.noreply.github.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com>
Signed-off-by: Ajay Balasa <abalasa@nvidia.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Tuomas Rintamaki <trintamaki@nvidia.com> Co-authored-by: Tyler Poon <tylerpoon@gmail.com> Co-authored-by: Collin McCarthy <cmccarthy@nvidia.com> Co-authored-by: Matthieu Le <matthieul@nvidia.com> Co-authored-by: Piotr Zelasko <pzelasko@nvidia.com> Co-authored-by: Ehsan Hosseini Asl <ehosseiniasl@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
…parallel_size * expert_tensor_parallel_size (#4678) Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Co-authored-by: Jorge Albericio <jalbericiola@nvidia.com>
#4509) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
#4492) Signed-off-by: Xiaowei Ren <xren@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
…parallelism correctly (#4687)
svcnvidia-nemo-ci
force-pushed
the
main2dev/18_05_2026
branch
from
May 19, 2026 01:37
d4b5d34 to
7acc30f
Compare
Contributor
Author
|
/ok to test 7acc30f |
svcnvidia-nemo-ci
force-pushed
the
main2dev/18_05_2026
branch
from
May 19, 2026 02:55
7acc30f to
c1edd9b
Compare
Contributor
Author
|
/ok to test c1edd9b |
Contributor
Author
|
Superseded by today's nightly sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly main → dev sync for 18_05_2026.
origin/mainintoorigin/dev.mainon genuine conflicts, preserving dev-only additions, applying file-specific overrides).Files where main's version was taken
Per the nightly-sync skill, these training-side files reference dev-only args/APIs main has since removed/renamed, so they were overridden with main's version:
megatron/training/training.pymegatron/training/initialize.pymegatron/training/utils.pymegatron/training/datasets/data_samplers.pyFiles preserved from dev (override-from-dev)
Per the skill, the dependency-management triple and CODEOWNERS were kept at dev's version:
.github/CODEOWNERS(governance: dev's reviewer assignments)pyproject.toml(dev superset: includesfast-hadamard-transform,nvidia-resiliency-ext)uv.lockdocker/Dockerfile.ci.devNo git source reconciliation was needed — dev's
[tool.uv.sources]is already a superset of main's.API mismatches detected and fixed
Per skill's API Mismatch Detection (Phase 1):
megatron/core/transformer/multi_latent_attention.py—off_interface.group_commit(...)(main's API) was leaking into dev'sgroup_offload-based interface. Rewrote theattn_projblock to useattn_proj_manager.group_offload(...)matching dev'sFineGrainedActivationOffloadingInterface.megatron/core/models/gpt/gpt_model.py— main's version dropped theLinearCrossEntropyModuleandpaged_stash_init_chunk_handlerimports but the merged file still uses both symbols (line 253 and 493). Restored the two imports from dev's version.megatron/core/models/gpt/gpt_layer_specs.py— main no longer usesTEFusedDenseMLP(replaced bynot_none(TEFusedMLP)), but the import block still imported it (dev's). Removed the unused import and the correspondingNoneplaceholder.megatron/core/transformer/moe/experts.py— dev'snullcontextimport was orphaned after main removed thestash_contextusage that relied on it. Removed the unused import.Files restored after deletion
None this run — the three files missing from dev (
multi-approval-bot.yml,tests/test_utils/recipes/h100/bert.yaml,.../t5.yaml) were intentionally absent on dev:multi-approval-bot.ymlwas explicitly removed by dev PR ci: Remove multi-approval action from dev branch #3576.unit-tests.yamlin that directory).Formatting
Ran
black --skip-magic-trailing-comma --skip-string-normalization(24.10.0) andisort(5.13.2) on all changed Python files. Verified both pass--checkon the autoformat scope (megatron/core/+tests/). Pylint and ruff also clean on changed files.Merge conflict summary
44 conflicted files (click to expand)
The full
git show --remerge-diff HEADis large (~8500 lines) and not inlined; reviewers can produce it locally with:Test plan
Nemo_CICD_Test)🤖 Generated by the nightly main-to-dev sync bot.