Skip to content

[Dev][Cherry-Pick Main] Remove legacy grouped gemm and grouped mlp - #4774

Merged
yaox12 merged 2 commits into
NVIDIA:devfrom
yaox12:xiny/remove_legacy_gmm
May 14, 2026
Merged

[Dev][Cherry-Pick Main] Remove legacy grouped gemm and grouped mlp#4774
yaox12 merged 2 commits into
NVIDIA:devfrom
yaox12:xiny/remove_legacy_gmm

Conversation

@yaox12

@yaox12 yaox12 commented May 13, 2026

Copy link
Copy Markdown
Member

What does this PR do ?

Some changes from #3410 and #3770 are missing in main to dev sync. So cherry-pick them manually.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

dimapihtar and others added 2 commits May 12, 2026 21:05
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
(cherry picked from commit 2caa681)
Co-authored-by: Xin Yao <xiny@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
(cherry picked from commit 40dce4e)
@yaox12
yaox12 requested review from a team as code owners May 13, 2026 04:10
@copy-pr-bot

copy-pr-bot Bot commented May 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12

yaox12 commented May 13, 2026

Copy link
Copy Markdown
Member Author

/ok to test 7943d55

@yaox12 yaox12 changed the title [Dev][Cherry-Pick] Remove legacy grouped gemm and grouped mlp [Dev][Cherry-Pick Main] Remove legacy grouped gemm and grouped mlp May 13, 2026
@yaox12
yaox12 enabled auto-merge May 13, 2026 06:13
@yaox12
yaox12 added this pull request to the merge queue May 14, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25838005381

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25841588519

Merged via the queue into NVIDIA:dev with commit 341e9f7 May 14, 2026
67 checks passed
@yaox12
yaox12 deleted the xiny/remove_legacy_gmm branch May 14, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants