Skip to content

[Cleanup] Remove the deprecated GroupedMLP - #3410

Merged
yaox12 merged 17 commits into
NVIDIA:mainfrom
dimapihtar:remove_grouped_mlp
Mar 4, 2026
Merged

[Cleanup] Remove the deprecated GroupedMLP#3410
yaox12 merged 17 commits into
NVIDIA:mainfrom
dimapihtar:remove_grouped_mlp

Conversation

@dimapihtar

Copy link
Copy Markdown
Contributor

What does this PR do ?

removes deprecated GroupedMLP as a part of MLM cleanup.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
dimapihtar requested review from a team as code owners February 13, 2026 13:13
@copy-pr-bot

copy-pr-bot Bot commented Feb 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dimapihtar dimapihtar added complexity: high Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Feb 13, 2026
@ko3n1g
ko3n1g requested a review from a team February 13, 2026 13:13
@dimapihtar

Copy link
Copy Markdown
Contributor Author

/ok to test bf8c790

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar

Copy link
Copy Markdown
Contributor Author

/ok to test b4ec06f

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar

Copy link
Copy Markdown
Contributor Author

/ok to test bada61d

@yaox12

yaox12 commented Mar 2, 2026

Copy link
Copy Markdown
Member

/ok to test 2700edb

@yaox12
yaox12 enabled auto-merge March 2, 2026 09:17
@yaox12 yaox12 mentioned this pull request Mar 2, 2026
6 tasks
@yaox12

yaox12 commented Mar 4, 2026

Copy link
Copy Markdown
Member

/ok to test f3e34c8

@yaox12

yaox12 commented Mar 4, 2026

Copy link
Copy Markdown
Member

/ok to test 017de80

@yaox12 yaox12 changed the title remove deprecated GroupedMLP [Cleanup] Remove the deprecated GroupedMLP Mar 4, 2026
@yaox12

yaox12 commented Mar 4, 2026

Copy link
Copy Markdown
Member

/ok to test 004d424

@yaox12
yaox12 added this pull request to the merge queue Mar 4, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22658274472

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 4, 2026
@yaox12
yaox12 added this pull request to the merge queue Mar 4, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22659506142

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22660823141

Merged via the queue into NVIDIA:main with commit 2caa681 Mar 4, 2026
50 of 53 checks passed
liuyun7345 added a commit to liuyun7345/Megatron-LM that referenced this pull request Mar 10, 2026
The deprecated GroupedMLP was removed in PR NVIDIA#3410, so the
nv-grouped-gemm package is no longer needed.

Changes:
- Remove nv-grouped-gemm from dev and lts optional dependencies
- Remove nv-grouped-gemm from uv no-build-isolation-package list
- Remove grouped_gemm wheel build/install from Docker script

Fixes NVIDIA#3711

Made-with: Cursor
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: high Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants