chore: remove nv-grouped-gemm dependency - #3770
Merged
yaox12 merged 7 commits intoMar 20, 2026
Merged
Conversation
The deprecated GroupedMLP was removed in PR NVIDIA#3410, so the nv-grouped-gemm package is no longer needed. Changes: - Remove nv-grouped-gemm from dev and lts optional dependencies - Remove nv-grouped-gemm from uv no-build-isolation-package list - Remove grouped_gemm wheel build/install from Docker script Fixes NVIDIA#3711 Made-with: Cursor
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
svcnvidia-nemo-ci
marked this pull request as draft
March 10, 2026 10:12
liuyun7345
marked this pull request as ready for review
March 10, 2026 14:07
Member
|
/ok to test f6b7bd2 |
Member
|
/ok to test e0b9957 |
Member
|
/ok to test 2d92a86 |
ko3n1g
approved these changes
Mar 19, 2026
Contributor
|
/ok to test 91e5fcf |
Member
|
/ok to test 1ac8fa5 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23322436422 |
5 tasks
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
Co-authored-by: Xin Yao <xiny@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
Co-authored-by: Xin Yao <xiny@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
Co-authored-by: Xin Yao <xiny@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
Co-authored-by: Xin Yao <xiny@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the
nv-grouped-gemmpackage dependency since the deprecatedGroupedMLPwas removed in PR #3410. The package is no longer usedanywhere in the codebase.
Changes
pyproject.toml: Removenv-grouped-gemmfromdevandltsoptional dependencies, and from
[tool.uv] no-build-isolation-packagedocker/common/install_source_wheels.sh: Removegrouped_gemmwheel build and installation logic (including the reference to the
non-existent
build_groupedgemm.shscript)Verification
import grouped_gemmorfrom grouped_gemm— the package has zero runtime usageTEGroupedMLPuses TransformerEngine'sGroupedLinearinternally,not
nv-grouped-gemm--moe-grouped-gemmCLI flag andmoe_grouped_gemmconfigfield remain unchanged (they control TE's grouped GEMM, not the
removed package)
Fixes #3711