Skip to content

[20251111] Ko3n1g/chore/main to dev - #2211

Merged
ko3n1g merged 29 commits into
NVIDIA:devfrom
ko3n1g:ko3n1g/chore/main-to-dev
Nov 14, 2025
Merged

[20251111] Ko3n1g/chore/main to dev#2211
ko3n1g merged 29 commits into
NVIDIA:devfrom
ko3n1g:ko3n1g/chore/main-to-dev

Conversation

@ko3n1g

@ko3n1g ko3n1g commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

tdene and others added 18 commits November 6, 2025 11:39
@tdene
Add BytesIO to safe_globals (NVIDIA#2074)
10146c6
@dimapihtar
add deprecation warning for legacy tokenizer system (NVIDIA#2145)
f167a85 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@ko3n1g
replay: ci: Bump LTS container (NVIDIA#2157)
23a1dca 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@tdene
Hotfix to unit tests on hopper FA3 (bis) (NVIDIA#2179)
0abff08
@AAnoosheh
Fix has_modelopt_state() for native Torch checkpoint format (NVIDIA#2160
0981e3c 
)

Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
@ko3n1g
chore: Remove codeowners (NVIDIA#2175)
c63b921 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@santhnm2 @tdene
Fix FP8 inference with sequence parallelism (NVIDIA#2009)
9aa14ed 
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Co-authored-by: Teodor-Dumitru Ene <34819528+tdene@users.noreply.github.com>
@AAnoosheh
Replace ModelOpt generation server (NVIDIA#2147)
0f8fb9b 
Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
@santhnm2 @tdene
Add hybrid model support for dynamic inference engine (NVIDIA#1907)
e07c4a4 
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Co-authored-by: Teodor-Dumitru Ene <tene@nvidia.com>
@tdene @ArEsKay3
Async task and event loop safety in Megatron Core (NVIDIA#2025)
82e846d 
Co-authored-by: Robert Kirby <ArEsKay3@users.noreply.github.com>
@tdene
Rename skip_prompt_log_probs (NVIDIA#2181)
c193bf5
@lmcafee-nvidia @ArEsKay3
Mcore Bot @tdene
Dynamic inference context | UVM only. (NVIDIA#1983)
d6979d6 
Co-authored-by: Robert Kirby <rkirby@nvidia.com>
Co-authored-by: Mcore Bot <mcore-bot@nvidia.com>
Co-authored-by: Teodor-Dumitru Ene <tene@nvidia.com>
@ko3n1g
Update copy-pr-bot.yaml [skip ci]
a59223d 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Revert "Dynamic inference context | UVM only. (NVIDIA#1983)"
7055186 
This reverts commit d6979d6.
@ko3n1g
ci: Run auto-update-copy-pr-bot only on forks (NVIDIA#2191)
75f7d50 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@mathemakitten
Inference throughput tests: refactor goldens to be in list format (NV…
2fef6bb 
…IDIA#2072)
@negvet @ko3n1g
Enable TE custom quantization recipe (NVIDIA#2005)
1f6cde8 
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: root <Evgeny>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: root <Evgeny>
@ko3n1g
Merge remote-tracking branch 'github/main' into dev
d7d71e0 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
ko3n1g requested review from a team as code owners November 11, 2025 10:45
@copy-pr-bot

copy-pr-bot Bot commented Nov 11, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g changed the base branch from main to dev November 11, 2025 10:45
@ko3n1g
ko3n1g removed the request for review from a team November 11, 2025 10:45
@ko3n1g
ko3n1g force-pushed the ko3n1g/chore/main-to-dev branch from ce6e035 to bfbf13f Compare November 14, 2025 08:35
@ko3n1g

ko3n1g commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test
bfbf13f

@ko3n1g

ko3n1g commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test bfbf13f

@ko3n1g
attempt to fix lockfile
34d5fda 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 34d5fda

@ko3n1g
pydantic
d86384d 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test d86384d

@ko3n1g
"pydantic<1.8.0",
5d8d08f 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
lockfile
fe3ede3 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test fe3ede3

@ko3n1g
bump
21a481a 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 21a481a

@ko3n1g
revert EO
d79833b 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
lock
36b897c 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 36b897c

@ko3n1g
revert dependency change
f699c3a 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g

ko3n1g commented Nov 14, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test f699c3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FDecaYed FDecaYed FDecaYed approved these changes

Assignees

No one assigned

Labels

dev branch Dev branch related issues and development

Projects

None yet

Milestone

Core 0.16

Development

Successfully merging this pull request may close these issues.

10 participants

@ko3n1g @FDecaYed @Victarry @tdene @dimapihtar @AAnoosheh @santhnm2 @lmcafee-nvidia @mathemakitten @negvet