Dynamic inference context | UVM only. - #1983
Merged
lmcafee-nvidia merged 85 commits intoNov 10, 2025
Merged
Conversation
… lmcafee/dyn-inf-unified-memory
Contributor
Author
|
/ok to test a54cec9 |
Contributor
Author
|
/ok to test 4593de3 |
Contributor
Author
|
/ok to test 20f1981 |
Contributor
Author
|
/ok to test 9b6125d |
Contributor
Author
|
/ok to test 96c1f00 |
Contributor
Author
|
/ok to test ee078e5 |
Contributor
Author
|
/ok to test 5e6f38d |
shanmugamr1992
approved these changes
Nov 8, 2025
kvareddy
reviewed
Nov 9, 2025
| that live on the GPU. The total buffer size (stored in unified memory) | ||
| is 2x this value, with the the other half of the buffer reserved for | ||
| paused requests that live on the CPU. | ||
| max_tokens (int): Max number of tokens to use for forward passes. This is |
Contributor
There was a problem hiding this comment.
How does the max_tokens argument work with chunked prefill support?
Contributor
Author
There was a problem hiding this comment.
I haven't had any issues running with chunked prefill. Is there something I should check?
Contributor
Author
|
/ok to test 4db13d4 |
Contributor
Author
|
/ok to test d493a98 |
Contributor
Author
|
/ok to test f4f60a9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Dynamic inference context
memory_bufferonly supports unified memory (i.e., GPU tensor is no longer an option).Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.